Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp216160rwn; Fri, 16 Sep 2022 18:50:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM73KPpy7D7p6NwISnyIO5mu1OGnP9zaTDchQyQwwZvE4xmFwL+Oi8SH+Kt7dvASl24q9pcs X-Received: by 2002:a05:6402:11c8:b0:451:7220:6343 with SMTP id j8-20020a05640211c800b0045172206343mr6168232edw.184.1663379434098; Fri, 16 Sep 2022 18:50:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663379434; cv=none; d=google.com; s=arc-20160816; b=ZxnSJcz4hDE1PbOIxi7SQb7umvqbvBnMWnTuVpD8ZB5v1wyxnKVVf943h5DvkVXL1M k06nvdNg0tUpT7qOCaZNbevTaBr16Jn4gfPk8HGRMVjXJP0u1rQJluW81XGEKVSvtxhJ 8W5iURCxrfqMPClblj6tVunYx9rQafpyM9vnhqGd1G4osIppAyx5mIglSCWTK0+N4d9K w0cC2tuFOntfDpKNkeHooKItmDhGanb0ZF2MbInYpdBagz9cJvVQRKAPc6a5RkIGutvx 3C02QPaiIkGDox0va47JrR2CMg7w6QYxacgnPcTQyStytIF2M6gkDAupvuH+y5+O4YU1 6jzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BlVQwXVfr3GW5iAF6OT2YMTv6rkyyGCnSP6Ag3jREYU=; b=0MtVVwL4TsDPeOHlgoQj+w8lC2A8BwJw1Db+9tKIXw1QAJ11MlexuD49qFt5Psar9+ zvuq4bJNjJND0iLvdXTcY42+OR0O92rW03FcEHcxaT0isocXYKAwaQNe1b7c4xn0zxJ6 LUam28385OWb5jz98glyrnkvtiv1dC+rdJJdqR6ZaZNqYU8b0a5irL36ZKQOpedM5mMl rHTvVVkF/uLv86Eno4xFnr72Yw5EgXIj6uaJ/xKPGhA8I9dfIBOV5xEKdm/c/kqYMf4u 9vYz4DwA+GqEN1DKdsrnZRSk2EFJSmSQc0p/97ei+PIeXnyXuZSzWy3xljSCjOkEKo4q eiwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=KP+HNwDE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a056402268400b00451e1aae675si3521387edd.547.2022.09.16.18.50.08; Fri, 16 Sep 2022 18:50:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=KP+HNwDE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229771AbiIQBcW (ORCPT + 99 others); Fri, 16 Sep 2022 21:32:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbiIQBcT (ORCPT ); Fri, 16 Sep 2022 21:32:19 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1462BD106 for ; Fri, 16 Sep 2022 18:32:16 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id u131so8158434oie.5 for ; Fri, 16 Sep 2022 18:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=BlVQwXVfr3GW5iAF6OT2YMTv6rkyyGCnSP6Ag3jREYU=; b=KP+HNwDETUuPHLPcIapFdjnoF2cUScO3YXyr8jfUFet6LzZxXtjL1a9d5PDo4/pRYG 8cdGuQDun45WLXn09gwMq4miu1+Wfmgf5C10SUtvLKiJylwDvbIGKFfHpydRHY1XlmjD K4Snl08qVjp19NDbWD0K/wYGVVR1PRdZuW+4u8dKOKo0+G8pjFNiQTGPC2jjurepOjQF 0h7kbUTkGqbz423D0olnF+OATvKeTZ5SJqIjxYUKnpRtOf56nC+x1rkBSPExdpc5gZJd 6oQk/O20nbHyGdOFiiLUJZ3EifAF3rSX6cXNMFIQ59Xp/X2vjnv6yz5HBLZd4clS878g ZD1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=BlVQwXVfr3GW5iAF6OT2YMTv6rkyyGCnSP6Ag3jREYU=; b=F6jaB1nzv/vRsVAD1e02Y5l0LjSgLVoEOgj3jPkPP96Nl3mNmLXmAfrlmnkqBj5Khg MQbgD5PDLSqU9yqMBTLxXiJF+EvZOuyUZRaLUJXg8euJ1WR11pf6/L1h03H/aFvVuvOc rWJuWWvQYTIqby7qPZyCItIytMmMRjeyviQZezTxEV9DPk1sEdL308+slCiEjprRDIWG wtTGVuF/u1VZc5sQ1lUrxHFfatr+o9ptWVj3Uepugc+7Ve+2hyVgdDM94yy2Cxwmf2VR rmOGb8WFhdrc4VcZkciO4cnhcrmfDpKRx2Gc9+hx2clWDde8dxgbA/TfC/n82kIIYbH9 Oeqw== X-Gm-Message-State: ACrzQf0lOVdXffpTQAVy4xKhDu6WVlsfp/Jqm5dzULb5gsvMd9saHPuT HVyqg9ShB9rD5s46iyhrp5emc5mmwwIraJ6K68vpAA== X-Received: by 2002:a05:6808:49:b0:350:77ce:3368 with SMTP id v9-20020a056808004900b0035077ce3368mr956893oic.195.1663378336284; Fri, 16 Sep 2022 18:32:16 -0700 (PDT) MIME-Version: 1.0 References: <20220916103817.9490-1-guoren@kernel.org> <20220916103817.9490-2-guoren@kernel.org> In-Reply-To: <20220916103817.9490-2-guoren@kernel.org> From: Andy Chiu Date: Sat, 17 Sep 2022 02:32:01 +0100 Message-ID: Subject: Re: [PATCH 1/3] riscv: ftrace: Fixup panic by disabling preemption To: guoren@kernel.org Cc: arnd@arndb.de, palmer@rivosinc.com, rostedt@goodmis.org, greentime.hu@sifive.com, zong.li@sifive.com, jrtc27@jrtc27.com, mingo@redhat.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yes, by disabling preemption and ensuring all sub-functions called by the busy waiting loop of stop_machine, which happens to be true on non-preemptive kernels, solve the problem from the original implementation. Andy Chiu