Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: remove unused parameter of
 am65_cpsw_nuss_common_open()
To:     <davem@davemloft.net>, <kuba@kernel.org>
CC:     <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lipeng321@huawei.com>, <lanhao@huawei.com>,
        <shenjian15@huawei.com>
References: <20220916023541.23415-1-huangguangbin2@huawei.com>
From:   "huangguangbin (A)" <huangguangbin2@huawei.com>
Message-ID: <5fa1abb7-a6df-b78c-0faf-af06d56e9e75@huawei.com>
Date:   Sat, 17 Sep 2022 10:03:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20220916023541.23415-1-huangguangbin2@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Sorry, please ignore this patch because target tree name is
not specified in the subject and not cc s-vadapalli@ti.com.

I will send this patch again.


On 2022/9/16 10:35, Guangbin Huang wrote:
> From: Jian Shen <shenjian15@huawei.com>
> 
> The inptu parameter 'features' is unused now. so remove it.
> 
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
> ---
>   drivers/net/ethernet/ti/am65-cpsw-nuss.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index 7ef5d8208a4e..4f8f3dda7764 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -363,8 +363,7 @@ static void am65_cpsw_init_host_port_emac(struct am65_cpsw_common *common);
>   static void am65_cpsw_init_port_switch_ale(struct am65_cpsw_port *port);
>   static void am65_cpsw_init_port_emac_ale(struct am65_cpsw_port *port);
>   
> -static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common,
> -				      netdev_features_t features)
> +static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common)
>   {
>   	struct am65_cpsw_host *host_p = am65_common_get_host(common);
>   	int port_idx, i, ret;
> @@ -577,7 +576,7 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev)
>   	for (i = 0; i < common->tx_ch_num; i++)
>   		netdev_tx_reset_queue(netdev_get_tx_queue(ndev, i));
>   
> -	ret = am65_cpsw_nuss_common_open(common, ndev->features);
> +	ret = am65_cpsw_nuss_common_open(common);
>   	if (ret)
>   		return ret;
>   
>