Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220915085757.258608-1-zhaogongyi@huawei.com> <20220915085757.258608-2-zhaogongyi@huawei.com>
In-Reply-To: <20220915085757.258608-2-zhaogongyi@huawei.com>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Sat, 17 Sep 2022 14:39:27 +0900
Message-ID: <CAC5umyhUteOFg1Q+rxU01axu_Rt2gadTqi9NxLESiqNyLtHaZA@mail.gmail.com>
Subject: Re: [PATCH -next v2 1/5] docs: notifier-error-inject: fix non-working
 usage of negative values
To:     Zhao Gongyi <zhaogongyi@huawei.com>
Cc:     linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>, david@redhat.com,
        osalvador@suse.de, shuah@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2022=E5=B9=B49=E6=9C=8815=E6=97=A5(=E6=9C=A8) 18:01 Zhao Gongyi <zhaogongyi=
@huawei.com>:
>
> Fault injection uses debugfs in a way that the provided values via
> sysfs are interpreted as u64. Providing negative numbers results in
> an error:
>
>   # cd sys/kernel/debug/notifier-error-inject/memory
>   #  echo -12 > actions/MEM_GOING_ONLINE/error
>   -bash: echo: write error: Invalid argument
>
> Update the docs and examples to use "printf %#x <val>" in these cases.

I'd rather fix the notifier-error-inject module than change the user interf=
ace.
I'll send a patch, so could you check if that solves the problem.