Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp198040rwb; Sat, 17 Sep 2022 03:41:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM791ppL7PTXSGBKxDkKnseBdjhFTypN9Pxy6nqVjdm0CBboBvAkWM88JrtbhjbVJ88tzd71 X-Received: by 2002:a17:906:5a5a:b0:770:86d0:fd8 with SMTP id my26-20020a1709065a5a00b0077086d00fd8mr6472654ejc.164.1663411264874; Sat, 17 Sep 2022 03:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663411264; cv=none; d=google.com; s=arc-20160816; b=aVMu7Vi6amWXMJwTcM0UbiYgB5Qq6gnqUEdUQPoiUAy8IiqJsS5iWF4yZPdqa3gt8P +m7qiYud+dv7ejscu9xG1MUp5sMPmw5k33HmUZcBCTaDY1RpiqheQwOMkq8psaWL94rY kmjKIH7uhauAbKIY0MeQIXrqPF+2SFU1IAKMQ7SBl965PGuJgS+1NwRXmCGC9KDS89Ay W5ZEF4IHhclZu93Ju+vHuhmviQNNxuvznAclNtZNxN6rlWdRscyfamSUINvfVvN+5GaM zhaxoBtTco1DVo0EdxV5kauvsLCzNnD9Jy9/LWKLid0GFoYWY6uT+CfwbvqU9Oxxf5LN b80Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vYXGRMnXDGzFTJgY3kHS17GK9P7aOsjP3JZ3wjSy3xE=; b=VJo3jOLxIQz1cM4aguU5sRnV4EMQ7QwzaxVUU9FNhRKUY3xPc1itg2xHGpoOMmabJo VeRXg79/ZOFOyNCWsnoAlvOSsvwwsCwQV+P9jBrgyNvuraX55f+h6ZzWu4BieTfIsK/X Q4UetNVwvjcwvbSOOi9rBHSPtUBejhaJ2MaOYBj2C67OyF3s2ZeCPGSzdb/Bayqyzyin fxomUAtIi5m2/G5lG4UWLLvnaeOCNjoXfxm9nZS4d4l4SONk4lPE9x5wCbzU2K1dLVAL 9SQNh7G/xGO5jR2HcQHsnO3Lushh2Gk66IrQhpR39mC55VfKIuD1wL9JdooF2SPci56Y 8KoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hd42-20020a17090796aa00b0072f1c8d0e62si23611632ejc.95.2022.09.17.03.40.36; Sat, 17 Sep 2022 03:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbiIQKdF (ORCPT + 99 others); Sat, 17 Sep 2022 06:33:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbiIQKc1 (ORCPT ); Sat, 17 Sep 2022 06:32:27 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C790531DD3; Sat, 17 Sep 2022 03:32:26 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MV6d045sszpSv4; Sat, 17 Sep 2022 18:29:40 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 17 Sep 2022 18:32:24 +0800 From: Jason Yan To: , CC: , , , , , , , Jason Yan Subject: [PATCH 6/7] scsi: pm8001: use dev_and_phy_addr_same() instead of open coded Date: Sat, 17 Sep 2022 18:43:10 +0800 Message-ID: <20220917104311.1878250-7-yanaijie@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220917104311.1878250-1-yanaijie@huawei.com> References: <20220917104311.1878250-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sas address comparation of domain device and expander phy is open coded. Now we can replace it with dev_and_phy_addr_same(). Signed-off-by: Jason Yan --- drivers/scsi/pm8001/pm8001_sas.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index 8e3f2f9ddaac..bb1b1722f3ee 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -649,8 +649,7 @@ static int pm8001_dev_found_notify(struct domain_device *dev) for (phy_id = 0; phy_id < parent_dev->ex_dev.num_phys; phy_id++) { phy = &parent_dev->ex_dev.ex_phy[phy_id]; - if (SAS_ADDR(phy->attached_sas_addr) - == SAS_ADDR(dev->sas_addr)) { + if (dev_and_phy_addr_same(dev, phy)) { pm8001_device->attached_phy = phy_id; break; } -- 2.31.1