Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp201581rwb; Sat, 17 Sep 2022 03:46:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4wQ3Bdm4vOEFMYEcpPKS1m3VlJhjx2YNDYKGxg6Z3diq8s21vDM3GoM/MwccrcwrPRn8m5 X-Received: by 2002:a63:2ac4:0:b0:41d:95d8:45b6 with SMTP id q187-20020a632ac4000000b0041d95d845b6mr8400769pgq.132.1663411567965; Sat, 17 Sep 2022 03:46:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663411567; cv=none; d=google.com; s=arc-20160816; b=jycYKGytpyhkSmYsrfoMD2Ma97JWHYu9B70jXrqRFIOtvidXQDInup8sxa7vxrfTGG hH9H1PhnKQU3kJS+K0ziX+2Ov5lhfb4LPJFEDzV/mbFs6o3JAZf5EJY+NgeWgn9r9PoF spYBdbwVSUlArYHw7NxWKDPQnztB9hrJeQah7I+x6WnxNXVHQcaYMoyNwD1y6NfGRAiX bVmvqJAhK8NGmHe0q1EM+78fN30dG7+dZ6BuRqjxLCkxemOKLaqXJJfBQmVZioBp1ftG 8W2G3RURoOxvo2qsEmrRBdDmwCJuZCB9+WA45Q15DrBSdsIPAmbd/w5z97/seWDFM23b XRdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AElQa3Q935MLH46luLam5a3YiDLmcf0g3MyhcbDCpSc=; b=lAcn3yehM8aBGbKlOSAppPS0yYwVAjhA/2zkzlsSA031ZuTA66cWLxRiRC1FFgDDCn iGSbkJLpo8celVz3qp7vV/073+BYTMmEAyyItINzsFZPCDR6tMP5Q+fWLl+igdz8Rcdt 4a7DINKBM0c44tJSm4Kf4mE0nKrQz9zeaG8ZxTHnbOS9Mr3ogXB1+jKTxXw/mZTD7Pjs jMAj6OrB6eKtlqEfMpr9MBbeoUImbSy2tN5Gx90WMzKvtxlncgjQEyTkEfuAIyuK0OxC pNU8s1tA6P9BOeDNXo8PXlw0kPk4aIIafu0UmBtwS950mdrcxadYlF15zYNvG7FDCxjy DdwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q60-20020a17090a4fc200b002025f0f2926si5086582pjh.93.2022.09.17.03.45.55; Sat, 17 Sep 2022 03:46:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229655AbiIQKdC (ORCPT + 99 others); Sat, 17 Sep 2022 06:33:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbiIQKc1 (ORCPT ); Sat, 17 Sep 2022 06:32:27 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44FE831DC4; Sat, 17 Sep 2022 03:32:26 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MV6d001SDzpSvH; Sat, 17 Sep 2022 18:29:39 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 17 Sep 2022 18:32:24 +0800 From: Jason Yan To: , CC: , , , , , , , Jason Yan Subject: [PATCH 5/7] scsi: hisi_sas: use dev_and_phy_addr_same() instead of open coded Date: Sat, 17 Sep 2022 18:43:09 +0800 Message-ID: <20220917104311.1878250-6-yanaijie@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220917104311.1878250-1-yanaijie@huawei.com> References: <20220917104311.1878250-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sas address comparation of domain device and expander phy is open coded. Now we can replace it with dev_and_phy_addr_same(). Signed-off-by: Jason Yan --- drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 33af5b8dede2..4a11b717d03b 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -797,8 +797,7 @@ static int hisi_sas_dev_found(struct domain_device *device) for (phy_no = 0; phy_no < phy_num; phy_no++) { phy = &parent_dev->ex_dev.ex_phy[phy_no]; - if (SAS_ADDR(phy->attached_sas_addr) == - SAS_ADDR(device->sas_addr)) + if (dev_and_phy_addr_same(device, phy)) break; } -- 2.31.1