Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp210948rwb; Sat, 17 Sep 2022 04:00:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Now9vaTfgkYrH09Ek1Hsp+V7cKiU7ep37uc37O69oZ755P4bC/RU0WzKHlI1UI7iDnCin X-Received: by 2002:a17:902:d550:b0:178:6155:9b7a with SMTP id z16-20020a170902d55000b0017861559b7amr3942664plf.38.1663412402774; Sat, 17 Sep 2022 04:00:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663412402; cv=none; d=google.com; s=arc-20160816; b=pJjakaCyHIB7NDCC9Tqhh1duK9Hw4rEj2qoFw2pyxlet2cFDhh/Xe0r3f4sZLSEgfh 97v7PUZNojMPsMgxXza21SWwbb+SjkuWJKXoQc865bkfRFxnwPkfL4RpciHcXduenLfx 4Eo4kZAPwH8TDadnQN026dyLCD5xKxvaBown9eNwisuisNdwTM3X79J8TjGVyIV78IjY G0yPfXB8YuzpAgNT2WmPzJdotZIzJo/LDBawchoVWWwtnbCqCgUcs4Ia8DWIAGOi+O0m PxqUcyVIklwmCXqADky5bbQ2fFUFpeJDDjsPqFAulvo3ZLTaAEOH1CH2Xg1MohPoeUBE Or2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=84SuN5y49qgQmnigFDWUpb4inH1twN6NpMcvJIChkVA=; b=ku2lOkmqG3Ro8aOvVnfA7nk2QQ7ribG6PV+Z/rjOVV9v05KMHMsciPv5hqc5Ak+rjn +XxEsAvxD3P9embFRCIY5EEfMerSzTuR9PEtnm0ABsZ7EXz0S/PFspibLXhHHK1jVYnU y1sy11Ny18vdkxEgjW1gwnxqs3jJ73pvT3txwuKSZUYioqDzA3OnTFzQv63Qasi9xU6R Bgdn/ccLGQLBcOpreUXLbJ42z527nsCFOQZnTYePR7d+bImgGoIrEb5nhMUu/ZZeEQjl 9WzGMAhMTvH/AAQd8kYNOdJ6h7ZCTxWO94eqD2c/JCZjRJpQqiwl6MMZX2tuNgspMQQK 1bnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ovU/AECA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j15-20020a170903024f00b0016dd44dbe61si21765735plh.505.2022.09.17.03.59.51; Sat, 17 Sep 2022 04:00:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="ovU/AECA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229596AbiIQKql (ORCPT + 99 others); Sat, 17 Sep 2022 06:46:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiIQKqj (ORCPT ); Sat, 17 Sep 2022 06:46:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 432323BC48; Sat, 17 Sep 2022 03:46:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D2D8F613EA; Sat, 17 Sep 2022 10:46:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 438E6C433B5; Sat, 17 Sep 2022 10:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663411598; bh=Mk9u72C3NZotIzny4010l2UK4Jk0C0zgSamSFp0eYLE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ovU/AECAhGCtUPHtyXf+cmG7XLMCzz1w34ApEph+MfD/hCEi/3BpaeuHZSav5gXKa Slbh4uIjXsKGXmzv3MkxIiIo0FrrwtS0ADB5NRjWQZvx7E3W3awO/8rOLELKY/SqBx mm0tzLYgY6QEGOl2WazmhbHW4LS/n55UyaaA4dZEzbJX7MgyEoQWTWddE6AbKaAd9E fZy5d1aNSYIxNN/JAhYM9sBXDqNNIc1uLW7Jd/kCWHBqDTvwFgb3y6ZrKJN65FpDVG e0Y9cBKdGop2XTUsJlQHXCAlpvdLeR0wJcm4zSypfgDre145IERsJxRkTKPlZkvs7e Zy0JWdRhAW1Sg== Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-1278624b7c4so55623924fac.5; Sat, 17 Sep 2022 03:46:38 -0700 (PDT) X-Gm-Message-State: ACgBeo3as5QJba7/pcYV2FdurLFEuJolMlIhxx6xr0Rof8dPcWxYAc2i ZGPztfx/4afkCyoeQgIlGRaDlw+L3ZyDEofUSGE= X-Received: by 2002:a05:6870:a78e:b0:12b:542b:e5b2 with SMTP id x14-20020a056870a78e00b0012b542be5b2mr10574980oao.112.1663411597397; Sat, 17 Sep 2022 03:46:37 -0700 (PDT) MIME-Version: 1.0 References: <20220916103817.9490-1-guoren@kernel.org> <20220916103817.9490-2-guoren@kernel.org> In-Reply-To: From: Guo Ren Date: Sat, 17 Sep 2022 18:46:24 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] riscv: ftrace: Fixup panic by disabling preemption To: Andy Chiu Cc: arnd@arndb.de, palmer@rivosinc.com, rostedt@goodmis.org, greentime.hu@sifive.com, zong.li@sifive.com, jrtc27@jrtc27.com, mingo@redhat.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks! I would add your Signed-off-by: Andy Chiu as the first author, next. On Sat, Sep 17, 2022 at 9:32 AM Andy Chiu wrote: > > Yes, by disabling preemption and ensuring all sub-functions called by > the busy waiting loop of stop_machine, which happens to be true on > non-preemptive kernels, solve the problem from the original > implementation. > > Andy Chiu -- Best Regards Guo Ren