Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Sep 2022 08:30:28 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     linux-iio@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, mranostay@ti.com,
        jpanis@baylibre.com, gwendal@chromium.org, bleung@chromium.org,
        groeck@chromium.org, jic23@kernel.org, david@lechnology.com,
        robertcnelson@gmail.com
Subject: Re: [PATCH v2 4/4] counter: Introduce the COUNTER_COMP_ARRAY
 component type
Message-ID: <YyW95IoDkZl70V4a@fedora>
References: <cover.1663372750.git.william.gray@linaro.org>
 <f35ffc511f78148a10eb73b7d8abbe6c5d676973.1663372750.git.william.gray@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7cjrr8ZiGM7f26cT"
Content-Disposition: inline
In-Reply-To: <f35ffc511f78148a10eb73b7d8abbe6c5d676973.1663372750.git.william.gray@linaro.org>
Precedence: bulk


--7cjrr8ZiGM7f26cT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 16, 2022 at 08:39:28PM -0400, William Breathitt Gray wrote:
> +static int counter_array_attrs_create(struct device *const dev,
> +				      struct counter_attribute_group *const group,
> +				      const struct counter_comp *const comp,
> +				      const enum counter_scope scope,
> +				      void *const parent, const size_t id)
> +{
> +	const struct counter_array *const array = comp->priv;
> +	struct counter_comp ext = *comp;
> +	struct counter_array *element;
> +	size_t idx;
> +	int err;
> +
> +	/* Create an attribute for each array element */
> +	for (idx = 0; idx < array->length; idx++) {
> +		/* Set index for array element extension */
> +		element = ext.priv;
> +		element->idx = idx;

This is unintentionally overwriting the array length and thus skipping
the subsequent array elements. Instead, element should be a copy of the
array rather than a pointer to it. I'll fix this in a v3 release.

William Breathitt Gray

--7cjrr8ZiGM7f26cT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYyW95AAKCRC1SFbKvhIj
Kzx7AQDEzWxbBm3BxMXg8qMoL0Jgn5Swc8ZTmkDZsypU7P+klwEAl5icUdc8Qbii
gVuh9WqOSMihHfqIY54MxQ02rLbgyQU=
=tWcE
-----END PGP SIGNATURE-----

--7cjrr8ZiGM7f26cT--