Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp354443rwb; Sat, 17 Sep 2022 06:29:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6TRBUlRpgoNoqjWN15bvzzK6ZMDVb/qKJHgm0zbkKneWShh1YRakuvdmFuFl+UEZFSmLEz X-Received: by 2002:a05:6a00:c91:b0:540:f165:b049 with SMTP id a17-20020a056a000c9100b00540f165b049mr9736388pfv.76.1663421357541; Sat, 17 Sep 2022 06:29:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663421357; cv=none; d=google.com; s=arc-20160816; b=DREB+gglFXLVsE1Dd5X/z/4BN35r9YxwlAiecOtyyzjfR/0a0IXIWeV2Uv7DFizIcJ b3DYvrEPCFi05761A336EcnJX6gkbqplPI8++oBJ7IeFDpWHKU29fbNtB+3lsxnK48H6 /ZPhw6ClrcNuzu8nukj64ujz3izxayDzeDjzWgfJblKybNxinrtn5XiYxCd10TkcXBdz qa/pVLei0R0M/m1w50Ny3S73snyoNiP0ejYOoVXgh5Um+7HGGAlbwXdbYf+NPnEV0gtB rp+nT0msHaj6UruNSgnUf3mNPYpMC8YQIpYOnjE64S1n/W46BedJAGRtrdcR1Hc7FQOP Cl1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=pXoA/1PhdrJxSq5g9FR05libeTkLRCKcCDLg+9JaFyA=; b=h7PxRsicOJ05WwS4mOldHi/HWGojDgsVWOlWGVGC5oqEQvVqwJFpcAb1yNvS6LttO6 BN+6tW9p1RZUcOus8ZOXCgIhN2GLu7U5+8BIX5er8+rOPICKDAH8sQXYfcwuK6uHqQbP UGl5Yw4X+mZK5OPeXamPF9+zX6tEt+/plqJOPSK1Z23aGaqbm/h+l4jDCqtikp0gN11J n5cZztakpR6zj5ttPkJONep3WfNm4kKXuHPaBDcJ5n3vnopRY8/BRS0p/d4CJeHKYUOm w3wiScuY69fOxP5RINF+01G6K1o/Nl0yrw8wj4HQ9BvVOnwFWIl2kednTD2AegymFaoa hQXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LpoZ9clh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nv6-20020a17090b1b4600b001faf9ba369fsi6275557pjb.164.2022.09.17.06.29.05; Sat, 17 Sep 2022 06:29:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LpoZ9clh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbiIQNZV (ORCPT + 99 others); Sat, 17 Sep 2022 09:25:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbiIQNZR (ORCPT ); Sat, 17 Sep 2022 09:25:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E22BF26119; Sat, 17 Sep 2022 06:25:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D1DD60E75; Sat, 17 Sep 2022 13:25:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49CFBC433D6; Sat, 17 Sep 2022 13:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663421114; bh=ppWAv9KdCNYGZslmkybA3attMp8lGeI43yrrtw1qkQ4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LpoZ9clhC3OGzLsTjzAOJVm8ZJUt9zd4BDohT0yykTRP2wXEG7J0rCRY/EQNDGKtD U+8x5vJgBSxc/a+e054ALVFIJSmJvvRb7HpMntbdigSlDemxiZw90O1IeqiAG9ol0L ykfMsjLhQQdDV4M6rD6zSdl7s8rizpj3tqnneliJINXtGpz1pWfAb5d2ML1O3uHmjX +oT7VkbQrEHKA32OEi+VaWJjBZ3g46mMF6tkNXGiLezO4BF4c5T/t4dyXSaZsnutjA pHeXyxXl9iu9jGMFP00xVaOvxIDhRnpiEPq1Mg3mXpNXTTjJYh39mHNI0o4qWx+Lrr nl3edG2+aPuWA== Date: Sat, 17 Sep 2022 14:25:16 +0100 From: Jonathan Cameron To: Angel Iglesias Cc: linux-iio , Lars-Peter Clausen , Andy Shevchenko , Nikita Yushchenko , Paul Cercueil , Ulf Hansson , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 7/9] iio: pressure: bmp280: Add support for BMP380 sensor family Message-ID: <20220917142516.3fc145b6@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Sep 2022 01:52:13 +0200 Angel Iglesias wrote: > Adds compatibility with the new generation of this sensor, the BMP380. > > Includes basic sensor initialization to do pressure and temp > measurements and allows tuning oversampling settings for each channel. > > The compensation algorithms are adapted from the device datasheet and > the repository https://github.com/BoschSensortec/BMP3-Sensor-API. > > Signed-off-by: Angel Iglesias There is one place (around the reset handing) in here where I suspect we'll end up revisiting it because the matching by device ID is not particularly extensible to new devices. Anyhow, can handle that at the time. I had to hand apply parts of this because of the clash Andy raised. As a general rule it's better to keep one linear flow of patches unless they are on well separate parts of a driver. Saves me effort :) Here it was just one line to cut and paste, but you still get to now check I didn't mess that up ;) Applied - please check result in testing branch of iio.git. Note I plan to rebase that branch after the first pull request is accepted as I have some dependencies blocking other patches and a fast forward rebase is the easiest way to deal with those cleanly. Jonathan