Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Sep 2022 22:15:26 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Vincent Guittot <vincent.guittot@linaro.org>,
        Tim Chen <tim.c.chen@intel.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Juri Lelli <juri.lelli@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Aaron Lu <aaron.lu@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        Yicong Yang <yangyicong@hisilicon.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Ingo Molnar <mingo@redhat.com>,
        "Dietmar Eggemann" <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] sched/fair: Choose the CPU where short task is
 running during wake up
Message-ID: <YyXWfmH6cJayun3I@chenyu5-mobl1>
References: <20220915165407.1776363-1-yu.c.chen@intel.com>
 <YyRiZTTi2KQfJebc@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <YyRiZTTi2KQfJebc@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2IiYNPQoWx3IY6B681FgYcgkmANrzzYRzYMY1IT0q6515wMBX88TbXweTW32?=
 =?us-ascii?Q?DFnxzhB75Y3O7ZGkRG6tJ7NJ0ZhP9YeWOojQ/iqfRJgkfC7r3iSF5nMKPgyN?=
 =?us-ascii?Q?ziUB9kblEeGaRxYYeSV9apGuk8PUczQHijxVxj6MmcwUcbP69vr4jHZEPlf5?=
 =?us-ascii?Q?MnVGEtgYdNPEBascOdgryn9a4QqwI/FbUrFm2DAFAlGkCEarxNKtGRKqqeO1?=
 =?us-ascii?Q?RI+0lHslwpTInm4ep5hxra9fdoh9VWp4GN0dMnNx5Am6LE0I0ZrcZ7kw5apP?=
 =?us-ascii?Q?H0RDkA7OjPnQ0x9QyUleXk6bP6p7L8Buc0XeMI+MnhQcf5TcM9mYwAmzIY9/?=
 =?us-ascii?Q?yEaPi+k3141WeC/pK3axT4wBZzglAAOR5XOTHW7lc+P2oOM175L4tyvxNJxN?=
 =?us-ascii?Q?1xxeXeu0RXXLrh1BV/Lyb2SBplyQJdzfkX1Pgyi4R7D8qA/WgFf2f7DXVdPc?=
 =?us-ascii?Q?2f0kFMo1QHMqxGoBe0sVnTs27O/lRT6UsmLKXmSZjVkERA9rE+m1ZlMhJHoH?=
 =?us-ascii?Q?p6yDJmidY6bzQ6OTKlkTGSFpYDWquFJGoUv2TGEq1swhvjhIHap5i3vWgWNP?=
 =?us-ascii?Q?FTWgtDWv8xMqPj9x8HqeiVsgRwVZ1wNf9w7jw8o5/61hlp+eOioLvQaf49WU?=
 =?us-ascii?Q?RNMuvvhP53oiXiX8h/z8i5wLVq6aqVllgUM5Q3IxAsEUKqYkK2WH1i9SYAY1?=
 =?us-ascii?Q?bC6/NXx/7edYaOoELTAyWbocZOiOGngGldZOsmdnzW25inz2MDdLZq9EuAOW?=
 =?us-ascii?Q?M67qiFA98w1eiv6rRJQij5nCFlWrf+8o9fYk2EqtbOCUscXxgx/oVJAdVbZ9?=
 =?us-ascii?Q?mnRrcZROwGot6BtsSmGhjxyMxhjvHCp8wAqooUnDTExdEYHXUMqjuvLXGwt6?=
 =?us-ascii?Q?pHuqLZPzBWloVb0yADZNYH15EiwBiRU9QvO7KletVQ7IC2gFtBefmDiuRJWh?=
 =?us-ascii?Q?ReuPpV9NO5NV6zWYHOgV3zDKZTi6jG51/P4iyam1bO2W8jh/kiXKB/RqgdZg?=
 =?us-ascii?Q?+MiLro1sC16W0vvjVDqnSPfWMj52spblEU9RbpVEHAnhtwljZaoE1uBcoqOU?=
 =?us-ascii?Q?iVsi6e15Z7qi+/hTrLHG3ssiliJ5e3362vabv0PV+2wqiuhAXClHldFY49QF?=
 =?us-ascii?Q?RKUszai4IPXlzJ9HrBw/vqlYpniNeYPxaS7G2XkRzPVoQ5QTeLPXB3dKPc7T?=
 =?us-ascii?Q?hjOpBccwBpN0CSCOzv4t1XEN2HP/3wCs3d/eYFuZsEtH2f/2RrQ/oU89sPm6?=
 =?us-ascii?Q?VDojn/YwkiJ6DobQjS4GXpj0l7qCx2YXIDG1EuSIHjYyHactyTyPArjDwMWa?=
 =?us-ascii?Q?kEqgnG9lYZnN7TrlBKgnVRTDcpVVwFPIBVyPQOf/nxtnGKYyGWLEtFN476iD?=
 =?us-ascii?Q?lrCJPbM+QVrAE2q8HcGCThfe5nNecirMJW/FDeUYO+ey1TRKUYrPItFh5C1N?=
 =?us-ascii?Q?gRQLw/e/MxAjrm1biTR3Q8tk0xJM7JUYxOEv6vj1gOUbC2tKUOzmQv8Uoqpn?=
 =?us-ascii?Q?QTsQoZmgPNDLvRJP1/J51qT5jciFV5ZxoCO36Qxixxi0q1vCxV3Dk8jASIzC?=
 =?us-ascii?Q?mc995H1JzngU8R/R5e43PDGu1QfA3EQL3nx7hFpU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f766eb7-e67f-45a5-d1fb-08da98b71d47
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2022 14:15:46.6373
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6n68nRBL+a7VpDJZM2hyn7zHvH1ReFUNMONizhbpKoQT4gIDJN9aUYlhmh6/rtLKzyG4Wp475O+B1WM3nsH8JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4814
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-09-16 at 13:47:49 +0200, Peter Zijlstra wrote:
> On Fri, Sep 16, 2022 at 12:54:07AM +0800, Chen Yu wrote:
> 
> > Current proposal is a variant of 2:
> > If the target CPU is running a short-time slice task, and the wakee
> > is also a short-time slice task, the target CPU could be chosen as the
> > candidate when the system is busy.
> 
> Since this benchmark only has short running tasks, the result is that
> you always pick the local cpu and therefore the migrations are reduced?
>
Yes, local cpu is preferred.
> Doesn't this inhibit spreading the workload when there's geniunely idle
> CPUs around?
Yes, there could be some idle CPUs undetected, although this strategy is
in effect when the system is busy. And maybe we could raise the bar to
enable this strategy. For example as Tim mentioned, if the target CPU is
running a short-running task, and the nr_running is 1, meanwhile there's no
ttwu_pending flag on this CPU, we can choose the target. I don't have
good idea on how to extract the criterias to descibe the scenario, for
example, how to detect if the sched_domain has too many context switch and
we can safely inhibit spreading the workload.

thanks,
Chenyu