Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Sep 2022 17:11:52 +0000
To:     "Luke D. Jones" <luke@ljones.dev>
From:   =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>
Cc:     hdegoede@redhat.com, markgross@kernel.org,
        corentin.chary@gmail.com, linux@roeck-us.net, jdelvare@suse.com,
        acpi4asus-user@lists.sourceforge.net,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] asus-wmi: Expand support of GPU fan to read RPM and label
Message-ID: <qf0UI0B6IRDrhWfipl2Yv_LaJN2NsaEhHx8oqzQIvLu0DwDM5xUsVep8so-SE1QyqH1CaXjQXIF7COGUkoCXyI9aoL0u8QLGTZwWGJRPB0w=@protonmail.com>
In-Reply-To: <20220916004623.10992-1-luke@ljones.dev>
References: <20220916004623.10992-1-luke@ljones.dev>
Feedback-ID: 20568564:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi


2022. szeptember 16., p=C3=A9ntek 2:46 keltez=C3=A9ssel, Luke D. Jones =
=C3=ADrta:

> The previously added patch to add support for pwm change for TUF laptops
> also is usuable for more than TUF. The same method `0x00110014` is
> used to read the fan RPM.
>=20
> Add two extra attributes for reading fan2 plus fan2 label.
>=20
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
> ---
>  drivers/platform/x86/asus-wmi.c | 36 +++++++++++++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-=
wmi.c
> index ae46af731de9..7fe6ce25da0a 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -72,6 +72,7 @@ module_param(fnlock_default, bool, 0444);
> [...]
> +static ssize_t fan2_input_show(struct device *dev,
> +=09=09=09=09=09struct device_attribute *attr,
> +=09=09=09=09=09char *buf)
> +{
> +=09struct asus_wmi *asus =3D dev_get_drvdata(dev);
> +=09int value;
> +=09int ret;
> +
> +=09ret =3D asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_GPU_FAN_CTRL, &val=
ue);
> +=09if (ret < 0)
> +=09=09return ret;
> +
> +=09value &=3D 0xffff;
> +
> +=09return sysfs_emit(buf, "%d\n", value < 0 ? -1 : value * 100);

Can `value` can be negative here? I am not sure because of the `value &=3D =
0xffff` part.
And maybe it would be better to return -ENODATA or something similar instea=
d of printing "-1".


> +}
> [...]


Regards,
Barnab=C3=A1s P=C5=91cze