Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220825191946.1678798-1-maccraft123mc@gmail.com> <b245787a-38fa-4202-cc7a-8fe18bc2308d@redhat.com>
In-Reply-To: <b245787a-38fa-4202-cc7a-8fe18bc2308d@redhat.com>
From:   Maya Matuszczyk <maccraft123mc@gmail.com>
Date:   Sat, 17 Sep 2022 21:22:08 +0200
Message-ID: <CAO_MupKvwvG8Sg98psArQMHoqpBVxmgwpOzMpw340DoeDkPSng@mail.gmail.com>
Subject: Re: drm: panel-orientation-quirks: Add quirk for Aya Neo Air
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hey,

sob., 17 wrz 2022 o 20:00 Hans de Goede <hdegoede@redhat.com> napisa=C5=82(=
a):
>
> Hi,
>
> On 8/25/22 21:19, Maccraft123 wrote:
> > From: Maya Matuszczyk <maccraft123mc@gmail.com>
> >
> > Yet another x86 gaming handheld.
> >
> > This one has many SKUs with quite a few of DMI strings,
> > so let's just use a catchall, just as with Aya Neo Next.
> >
> > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>
> Thanks, I have pushed this out to drm-misc-next now.
>
> Note for future drm_panel_orientation_quirks.c patches please Cc me,
> I am not subscribed to dri-devel.
Yeah i forgot to Cc you on this patch, and had no idea how to bring it up.
I'll do my best to remember in future.
Thanks for picking this up!

Best Regards,
Maya Matuszczyk

>
> Regards,
>
> Hans
>
>
> > ---
> >  drivers/gpu/drm/drm_panel_orientation_quirks.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/g=
pu/drm/drm_panel_orientation_quirks.c
> > index fc1728d46ac2..0b011b615495 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -103,6 +103,12 @@ static const struct drm_dmi_panel_orientation_data=
 lcd800x1280_rightside_up =3D {
> >       .orientation =3D DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
> >  };
> >
> > +static const struct drm_dmi_panel_orientation_data lcd1080x1920_leftsi=
de_up =3D {
> > +     .width =3D 1080,
> > +     .height =3D 1920,
> > +     .orientation =3D DRM_MODE_PANEL_ORIENTATION_LEFT_UP,
> > +};
> > +
> >  static const struct drm_dmi_panel_orientation_data lcd1200x1920_rights=
ide_up =3D {
> >       .width =3D 1200,
> >       .height =3D 1920,
> > @@ -152,6 +158,12 @@ static const struct dmi_system_id orientation_data=
[] =3D {
> >                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "AYA NEO 2021"),
> >               },
> >               .driver_data =3D (void *)&lcd800x1280_rightside_up,
> > +     }, {    /* AYA NEO AIR */
> > +             .matches =3D {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "AYANEO"),
> > +               DMI_MATCH(DMI_BOARD_NAME, "AIR"),
> > +             },
> > +             .driver_data =3D (void *)&lcd1080x1920_leftside_up,
> >       }, {    /* AYA NEO NEXT */
> >               .matches =3D {
> >                 DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
>