Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2ef10724-553b-6f90-22ce-0ce3606f69ad@redhat.com>
Date:   Sat, 17 Sep 2022 21:38:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block
 comment
Content-Language: en-US
To:     Kang Minchul <tegongkang@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Fabio Aiuto <fabioaiuto83@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20220917181130.3237159-1-tegongkang@gmail.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220917181130.3237159-1-tegongkang@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/17/22 20:11, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
> 
>   WARNING: Block comments use * on subsequent lines
>   #206: FILE: rtw_recv.c:206:
>   +/*
>   +signed int     rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> 
>   WARNING: Block comments use * on subsequent lines
>   #216: FILE: rtw_recv.c:216:
>   +/*
>   +caller : defrag ; recvframe_chk_defrag in recv_thread  (passive)
> 
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
>  }
>  
>  /*
> -signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> -	return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int	rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * 	return rtw_free_recvframe(precvframe, queue);
> + * }
> + */
>  
>  
>  
>  
>  /*
> -caller : defrag ; recvframe_chk_defrag in recv_thread  (passive)
> -pframequeue: defrag_queue : will be accessed in recv_thread  (passive)
> -
> -using spinlock to protect
> -
> -*/
> + * caller : defrag ; recvframe_chk_defrag in recv_thread  (passive)
> + * pframequeue: defrag_queue : will be accessed in recv_thread  (passive)
> + *
> + * using spinlock to protect
> + *
> + */
>  
>  void rtw_free_recvframe_queue(struct __queue *pframequeue,  struct __queue *pfree_recv_queue)
>  {