Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 17 Sep 2022 22:29:31 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Tao Lan <taolan@huawei.com>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: hix5hd2: Add some debug enhancement for register
 access
Message-ID: <YyYuK1UD7CpZQoFr@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Tao Lan <taolan@huawei.com>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220913124820.48715-1-taolan@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="87LZbo8elNr19Yap"
Content-Disposition: inline
In-Reply-To: <20220913124820.48715-1-taolan@huawei.com>
Precedence: bulk


--87LZbo8elNr19Yap
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 13, 2022 at 12:48:20PM +0000, Tao Lan wrote:
> From: taolan <taolan@huawei.com>
>=20
> Sometimes, to locate a fault, we need to know how the register is
> configured and whether the configuration is incorrect. Currently, no
> better method is available for analysis.
>=20
> This patch tries to solve the problem by naming the registers and
> printing the accessed values.
>=20
> Signed-off-by: taolan <taolan@huawei.com>

Such debug helpers are not suitable for upstream because they need quite
some resources for rare cases...

> +		pr_notice("write 0x%04x to %s\n", val, g_i2c_reg_name[idx >> 0x2].name=
);

=2E.. and using this loglevel you will flood logs of users.


--87LZbo8elNr19Yap
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmMmLicACgkQFA3kzBSg
KbZGKg/+PsF/rh5RLE13VjDTAs9pTXGYCyHdijNibiDeKSiBn/jvoVp956JCR8/x
Q0XIm7XOn4Rgm3U5XaYtnDPnlTLduwL63fYM/wL9d0EU8WcPvcgvcjKLQi1fem8A
+0VihJUcvmfbonK5Xqr8WvCpX2EL/aNcCq5YTXpQOaVZA0Uv6xMo1LvlAOpBtrAt
kPeVQN91AU/6NmhLsTp6BBoL7jTzBxJNH3blh0bK7hvJjNQ2UOZI+QThxhIyeJV6
pUSiFKTcpncisCfvrf2cRrfpKZaL1ZZ1gsx+/SNgQbq2rFPmb1LFl6QScEK7mGuc
skJLwuBhIINh9sUlSqSiqg3XbpU8JtFHdcQWqEkkYWcH6dCWffAHTZygu9e4Zwl7
U6jvqlls6QRPnswWEwGcYaHvp//FC1fTaMUCh94RQa0dNchBevLdems/MqKPf9HL
Z/ccn8CbJmb6Ock/2jII4ugtNtHHKWrWRPbDIhhuyLwPfAInSQHW3Trp/QP/FlTl
fUU+69cwIjjJPV3bJc1fRItb65l4GjQz47v2doiY0yLZ0sRLStSy6fh8QVoPTjdw
4ZtNlL866v/sZZLmRImFXVEK9oz5+ta4L5+rN54iesesIl7bX3m2QXfaKxRLX+ut
YGJ9Qc+Djt4lD3sDnYlv1DaYE3dFJm9phrNyDIg/+WAJL45K1sM=
=ed/D
-----END PGP SIGNATURE-----

--87LZbo8elNr19Yap--