Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 18 Sep 2022 00:04:25 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Dominik Brodowski <linux@dominikbrodowski.net>, g@pengutronix.de
Cc:     linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] pcmcia: sa1100: Make sa11x0_drv_pcmcia_legacy_remove()
 return void
Message-ID: <20220917220425.yb2damz43q7fghz6@pengutronix.de>
References: <20220714214534.63517-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jakt3vbz2qf65knj"
Content-Disposition: inline
In-Reply-To: <20220714214534.63517-1-u.kleine-koenig@pengutronix.de>
Precedence: bulk


--jakt3vbz2qf65knj
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Dominik,

On Thu, Jul 14, 2022 at 11:45:34PM +0200, Uwe Kleine-K=F6nig wrote:
> sa11x0_drv_pcmcia_legacy_remove() returns zero unconditionally. Letting it
> return void instead makes it easier to see in the caller that there is no
> error to handle.
>=20
> This is a preparation for making platform remove callbacks return void.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

This patch still applies on top of v6.0-rc1. I didn't get any feedback
about it yet. Is there someone else I should send this patch to?

Best regards
Uwe

> ---
>  drivers/pcmcia/sa1100_generic.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/pcmcia/sa1100_generic.c b/drivers/pcmcia/sa1100_gene=
ric.c
> index 47b060c57418..c2b6e828c2c6 100644
> --- a/drivers/pcmcia/sa1100_generic.c
> +++ b/drivers/pcmcia/sa1100_generic.c
> @@ -125,7 +125,7 @@ static int sa11x0_drv_pcmcia_legacy_probe(struct plat=
form_device *dev)
>  	return ret;
>  }
> =20
> -static int sa11x0_drv_pcmcia_legacy_remove(struct platform_device *dev)
> +static void sa11x0_drv_pcmcia_legacy_remove(struct platform_device *dev)
>  {
>  	struct skt_dev_info *sinfo =3D platform_get_drvdata(dev);
>  	int i;
> @@ -134,8 +134,6 @@ static int sa11x0_drv_pcmcia_legacy_remove(struct pla=
tform_device *dev)
> =20
>  	for (i =3D 0; i < sinfo->nskt; i++)
>  		soc_pcmcia_remove_one(&sinfo->skt[i]);
> -
> -	return 0;
>  }
> =20
>  static int sa11x0_drv_pcmcia_probe(struct platform_device *pdev)
> @@ -167,8 +165,10 @@ static int sa11x0_drv_pcmcia_remove(struct platform_=
device *dev)
>  {
>  	struct soc_pcmcia_socket *skt;
> =20
> -	if (dev->id =3D=3D -1)
> -		return sa11x0_drv_pcmcia_legacy_remove(dev);
> +	if (dev->id =3D=3D -1) {
> +		sa11x0_drv_pcmcia_legacy_remove(dev);
> +		return 0;
> +	}
> =20
>  	skt =3D platform_get_drvdata(dev);
> =20
>=20
> base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--jakt3vbz2qf65knj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmMmRGcACgkQwfwUeK3K
7AlTWggAhFblRRwxmbE0w4eEpOd5atCR6Xd0/LR4JDOK1c6A8MIXyGsaYGAESO3T
4Utehf5VqOg5bzs5B1T8XZ2X6IcaEihVvHaa60g1/IwHR+RtDu318EdjAUhSX2fw
uawT7qPxFZqxjAqNAdf8NwapwDS04B+hhVmYRy+A8krTL4vEM3evL8Wbjk+IitJL
otdAZCaAFHa4l/w9hxoXtS/DNi/JcsV82jU2DQOYx34UkxrnLonS1YEWxuCP7NY5
WBZiXq3l2fL6oz+YkY7NAg1decEj/gsh3s3x5GhUpwfFOzS5p6U8tiWbhNNQK37w
b69wkRx13h6pEM+JqTExiqhLwDDOHw==
=hnfH
-----END PGP SIGNATURE-----

--jakt3vbz2qf65knj--