Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp959304rwb; Sat, 17 Sep 2022 20:09:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5tEpR8LFeM9OPFtSP2ryIsLhDmWxRfqPFIHnlVfdAkzLwZ0iiIGUh7Txk2pbMFBeIgcN3l X-Received: by 2002:a17:90b:38cb:b0:200:aaa6:6428 with SMTP id nn11-20020a17090b38cb00b00200aaa66428mr24253291pjb.47.1663470565317; Sat, 17 Sep 2022 20:09:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663470565; cv=none; d=google.com; s=arc-20160816; b=LshLlKm02srpl2hKUaS5EwEJnKaVNJ70vO4wNrDPCP+8WmY92/q8Z5A4hiGZmrFp7N M1UNAhZCuGH/fzAc0GYRliuntbJlc4Vv4x1k7TmZ+mlSBtM3mw+X4zurCRKMSFRit7Af EwGccXoBDfT/yem8qLvwcWsUlxLI/Epbe+C+8cqSPGrpO3zYdbUsFyijHANE3Of8Qh1x /YiRgAy+Uyr1msKOUcqGFnC0PpvpHMi84bpJmdY67/i557+ivvqgiZMGfHTg0LFO/CdK 25tBONWVq7u6CqWwgoRe3j2UVmFb7EZlU1J1hGiWkAsuw0G3Ij/ywIkReWscNQvHcZcs TAGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=um5UnD1ZnyEAgcctB8e0bdxExLm3AihflJVjXCDL3Fo=; b=d7/lDhpKoaNo5/ByHfFCTRa7TOEv/WiCUUwrbVC6TxmvL/jYMgqB3vU1f8NXxVracx i3admawwHKmOdUF0tYiSvDPvft8siDVjyEF7PEv4U0ZgOB7E6SLw+Hz2lf5wjNVW4qzZ ji/daH87xplK/1G+HC2O8os1KvzgX+0YXd3VQpdDVDok0K8hRdGcwYfV/j2vlv6/7ZZq P/2CnhAwy80mjf8vVBVvzzHslaEa644lNDkzDdz0UTDPgavY8rTQyXsVLzgwjndBBZmn jTAyKq0AUViH/Y/qAewYtd6TIIFtcHj6sfZg6aPLR4Q3bmiCBRlaowRs6tzH0/f5xC54 tgGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b="tg/t0BdH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 17-20020a17090a195100b00200287ed212si6736819pjh.120.2022.09.17.20.08.49; Sat, 17 Sep 2022 20:09:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b="tg/t0BdH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbiIRCnI (ORCPT + 99 others); Sat, 17 Sep 2022 22:43:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiIRCnH (ORCPT ); Sat, 17 Sep 2022 22:43:07 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C69B0286CC for ; Sat, 17 Sep 2022 19:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=um5UnD1ZnyEAgcctB8e0bdxExLm3AihflJVjXCDL3Fo=; b=tg/t0BdHfoKvwqeStHEJvYxCKj rZLUKqRuZxEk9hbAMHPuAFwmEhGHIZ6DndFQ2wPvRlSV3suMSM4OyKJveh8Vv09AaMO2FKBCcA533 5H1Ut8f2doPHZ7EDBTjeUyRxhVkXnjyjkGvHFIxS3Gh3gHa7SyN8VVm51NpYowegkigee6Y7tJ6Fz pHpYSKZGN2R9BNFja/qEOggFQIRBJNfDS1bHEr/GyqPFNQpjCIgoLnf+axOH6JuoOyteMTlr7eChs rMizovJ1fSZAPgXEwPIBeApYRO8px2NjfuL0cpsy3ox6axpfpnPBRMv6yX/oG7VOGqURNrhSDS4dp 0i77AEbA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1oZkGj-000Okm-3D; Sun, 18 Sep 2022 02:42:54 +0000 Date: Sun, 18 Sep 2022 03:42:53 +0100 From: Al Viro To: Zhaoyang Huang Cc: "zhaoyang.huang" , "Eric W. Biederman" , LKML , Ke Wang Subject: Re: [PATCH] fs: use kvmalloc for big coredump file Message-ID: References: <1661842523-26716-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 18, 2022 at 10:29:10AM +0800, Zhaoyang Huang wrote: > loop Eric W > > On Tue, Aug 30, 2022 at 2:56 PM zhaoyang.huang > wrote: > > > > From: Zhaoyang Huang > > > > High order page allocation observed which even introduce kernel panic when generating > > coredump file, use kvmalloc_array instead of kmalloc_array Frankly, I would rather cap argc here - if you are trying to feed that many arguments to your userland helper, your core_pattern is probably bogus.