Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp959306rwb; Sat, 17 Sep 2022 20:09:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4qDRGVQJilFzyHLsjjwJg0pxbM1PW4JP0D0+jAQJEyOPdZGzhiGnX7o5oMPqRt2FZ2KYPl X-Received: by 2002:a63:4a11:0:b0:439:1b3:9e4b with SMTP id x17-20020a634a11000000b0043901b39e4bmr10961511pga.537.1663470565335; Sat, 17 Sep 2022 20:09:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663470565; cv=none; d=google.com; s=arc-20160816; b=EIhqbXArFwiAyaP+KkK3Xk5XhFSVBB3KUi6kLbhkKD30u31Qk36pAV5jORMD5e2Ryu 0jv0u7rgG/DXORIoU4PxY9d7A27HpQItOQVPxJ0jrpsoTb0pHQjEGSB85pGe2EH57ETI txO1MyGlsloZAAM0P9fF0LFt1PWAYnjQNa37AzklrBYfsAVcA//Agxwj0cKhl69f91aE LuoXljFQYzV3aWBTsU3jR/So9+HxPL1HXsYQq+0Z/TuTTbtjst/ZSXckloc9yPfEj70L LPDAkASQL13huvdu9JvYyGKkA88TktXCwJiSbryz6N2VFrHYmG6S4eIkcPf4Q6a4ZG8K feEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=mt4EevSP2UXpOuDshgDqIVBSaTOuTupp17SEl5NDqXg=; b=p2s7dwBTppigojlVG3P6fti7L32Ub47CMVP72b3pUVGy9cxqnr9SEVroasNOZAdEmT 7CAdQnwVdI2ZI0+lFUE/w6uDY1pxouSSCDpP1VaavIUo1I9wbWni7HWs3l/4dF+O9h6S ZGmQQm4SFS8erFHyhFMGz7nf/ry3yLzizfsT3VJnDPnghdBVfZTs4Jqyjb/CC5/fxCP+ 7xwCINm1nkOt/UH9VjB9DmoDn5ciC4m8lGfD3FRpmj3sAwTCXwV6gXs+ecXDw4nYsmCq B8RXFnpJfWd/z9wAz1SqctZ3EaEet4pShsQQEq2czrGXxsw86INdUzfIVJ1wG+t3M7HY 2b8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=TJvEPU5E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m72-20020a633f4b000000b004299ab791c3si26424189pga.684.2022.09.17.20.08.49; Sat, 17 Sep 2022 20:09:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=TJvEPU5E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbiIRCgs (ORCPT + 99 others); Sat, 17 Sep 2022 22:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiIRCgq (ORCPT ); Sat, 17 Sep 2022 22:36:46 -0400 Received: from out2.migadu.com (out2.migadu.com [IPv6:2001:41d0:2:aacc::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F6BA240B2 for ; Sat, 17 Sep 2022 19:36:44 -0700 (PDT) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663468603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mt4EevSP2UXpOuDshgDqIVBSaTOuTupp17SEl5NDqXg=; b=TJvEPU5EJxYQYfqjeqgXwtBInyVyBZ9dIKb7eJCybflERk/L6hMKDFVlSpHNOVON8Tey/m DSCEb9RgIRzqUnB9f+AQLBzUD3udAl/bn2PFN9r/Lr8xwJg5W37xRYbRY8KsLPX/KUSL46 PwOhViZkUj8Q5M5elAIVdQs7HM/kApA= MIME-Version: 1.0 Subject: Re: [PATCH] mm/damon: return void from damon_set_schemes() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <1663341635-12675-1-git-send-email-kaixuxia@tencent.com> Date: Sun, 18 Sep 2022 10:36:39 +0800 Cc: sj@kernel.org, Andrew Morton , damon@lists.linux.dev, Linux MM , linux-kernel@vger.kernel.org, Kaixu Xia Content-Transfer-Encoding: 7bit Message-Id: <6843CCD1-F6F3-40AA-9A5C-7DFD65475864@linux.dev> References: <1663341635-12675-1-git-send-email-kaixuxia@tencent.com> To: xiakaixu1987@gmail.com X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sep 16, 2022, at 23:20, xiakaixu1987@gmail.com wrote: > > From: Kaixu Xia > > There is no point in returning an int from damon_set_schemes(). > It always returns 0 which is meaningless for the caller, so > change it to return void directly. > > Signed-off-by: Kaixu Xia Reviewed-by: Muchun Song Thanks.