Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2d7334210b41b256f6d7dc2cfd34036375ebf755.camel@gmail.com>
Subject: Re: [PATCH v6 7/9] iio: pressure: bmp280: Add support for BMP380
 sensor family
From:   Angel Iglesias <ang.iglesiasg@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio <linux-iio@vger.kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Paul Cercueil <paul@crapouillou.net>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-kernel@vger.kernel.org
Date:   Sun, 18 Sep 2022 12:06:45 +0200
In-Reply-To: <20220917142516.3fc145b6@jic23-huawei>
References: <cover.1663025017.git.ang.iglesiasg@gmail.com>
         <f1da2a2f1bc5bb083f318335c23b4f3d9bb8e536.1663025017.git.ang.iglesiasg@gmail.com>
         <20220917142516.3fc145b6@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Sat, 2022-09-17 at 14:25 +0100, Jonathan Cameron wrote:
> On Tue, 13 Sep 2022 01:52:13 +0200
> Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
>=20
> > Adds compatibility with the new generation of this sensor, the BMP380.
> >=20
> > Includes basic sensor initialization to do pressure and temp
> > measurements and allows tuning oversampling settings for each channel.
> >=20
> > The compensation algorithms are adapted from the device datasheet and
> > the repository https://github.com/BoschSensortec/BMP3-Sensor-API.
> >=20
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> There is one place (around the reset handing) in here where I
> suspect we'll end up revisiting it because the matching by
> device ID is not particularly extensible to new devices.

Yeah, after the first time you raised that concern I've been thinking that =
maybe
it would be better to add a new "init" or "preinit" callback executing firs=
t
boot tasks for a sensor, such as this reset. Please, let me know how I can =
help
with this matter. On the other hand, I'll have the BMP390 and BMP581 on my =
hands
in a week or two. The BMP390 is almost the same regmap and operations as th=
e
BMP380, so I think it will be an easy addition. The BMP581 is a new beast t=
hat
brings in lots of changes, but still has a good bunch of similarities.

> Anyhow, can handle that at the time.
>=20
> I had to hand apply parts of this because of the clash Andy
> raised.=C2=A0 As a general rule it's better to keep one linear
> flow of patches unless they are on well separate parts of
> a driver.=C2=A0 Saves me effort :)=C2=A0 Here it was just one line to
> cut and paste, but you still get to now check I didn't mess
> that up ;)

Sorry about that. Thanks to you and Andy for the extra patience with my mes=
sy
patches.

> Applied - please check result in testing branch of iio.git.
>=20
> Note I plan to rebase that branch after the first pull request
> is accepted as I have some dependencies blocking other
> patches and a fast forward rebase is the easiest way to deal
> with those cleanly.
>=20
> Jonathan

With kind regards,
Angel