Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1628730rwb; Sun, 18 Sep 2022 10:50:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4CLdWY9QCQ/lmK/9PJb23QCYQdkCbgxP0rTV4phFROpdWgXJ74ttg91eMkdBoXmNO4fZTf X-Received: by 2002:a05:6402:3486:b0:451:b8d3:c52c with SMTP id v6-20020a056402348600b00451b8d3c52cmr12052859edc.406.1663523442598; Sun, 18 Sep 2022 10:50:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663523442; cv=none; d=google.com; s=arc-20160816; b=StHX87woek0VgBRzg7FZM+yML9CNfFZ3ZVXBiKm/SGHA6EU4iQxW3pE7NxSv9/+pNN IMTFc7L0UyhIgkEO+X+TxvaYtMFHuKt9RIyBNFQ/UsRsbzSqvhzxdg5UCT4aWXEoK538 zqGyV6Nj42g46Bkei8vnht+W1rN3EuyjbsieWpa6zNMQx+zQ4Ng6DmmUGG4/YZuo05R8 SSkzl+zmt8LJlFn8SKjO8mrPgEeM1761baNhGmqV7s398L2ZEckc373tAsAPdN5+wnNn rjiON4GLTgaouMhdLFtFQ6ESpkPLuUPTu4w8eYXdHQhilL6ooIXX+kNB1zrXnWBcW6sI KYrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nG3BzO8rElQFb9v9I5XNVhhlvQs1WwjIWMG00Nk4ISY=; b=geMOacGg2vhiXKBtwQhc8nSTOJB1a8OSj3B5hwk/MFtyupxppE1TSNrs8dtghBzS53 oq7Ra85IwR1n1Z4jY41zPOMC1Thx0z8uELEhdUOrY415vm9bBlurQkJU7oLEpEfnD9km o7HOzfTB8To2mLzFlX2ppffzCcwT3AZ+qWvWJbOkDABpKBEyufJw8JGyDIvv9LY2hfC1 IT0INGCUSF5jQzqCRIPw2WCPqayES6cvzj/GnGcPTBu8l55TV1WNmgrh8SxcfLOxJYw6 l6CVxVJygL/7HaQo4pjuWNtGcGiaxqr6Qxj2Mv29S6LvUJ9ESd2D4NprlxY70ntntVQ2 vHMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L2tBmmhE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb34-20020a1709076da200b00780b95a07b4si4096158ejc.873.2022.09.18.10.50.16; Sun, 18 Sep 2022 10:50:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L2tBmmhE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbiIRR03 (ORCPT + 99 others); Sun, 18 Sep 2022 13:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbiIRR01 (ORCPT ); Sun, 18 Sep 2022 13:26:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E19D7186C8; Sun, 18 Sep 2022 10:26:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 71D9D615B3; Sun, 18 Sep 2022 17:26:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DB17C433C1; Sun, 18 Sep 2022 17:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663521984; bh=LFojQE3Tofgqym9S96rNzo5hxMzpgPxPJkTV1h+fBII=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L2tBmmhEOVDk6M6LGlh/D76yQd9iS8OhTLshev0q8bd5fPOm7KnfnphFY/Lx3Th70 u6p5p8mvvQ8R8cJtsR4Jfa/Uj8BJnHHUC/2mN0EN7Ftr5Ece4+A6TCcp6iWkUPrTr8 8NZNGg10a/e14InFy32JuaL1A8VRtqthw7SGVq+odKjHxFv49bF+bl12fh3NAdE/qI VmHwWoRuIq01grHs+3vSD3LDTf8IBric47qJiLNG3nIM/8g18KBzEvAUf28roi0c97 zBbOYgqT2grv+KyqMI2Ca0tINvA3vJPCoDVqWyWcyQIXDuinjPYGKyiNfDOlKT3Vgh JanupFjNjU2XQ== Date: Sun, 18 Sep 2022 18:26:26 +0100 From: Jonathan Cameron To: Andrea Merello Cc: Andy Shevchenko , Andrea Merello , Mauro Carvalho Chehab , linux-iio , Linux Kernel Mailing List , devicetree , Lars-Peter Clausen , Rob Herring , Matt Ranostay , Alexandru Ardelean , jmondi , Bagas Sanjaya Subject: Re: [v7 13/14] iio: imu: add BNO055 I2C driver Message-ID: <20220918182626.00aae26d@jic23-huawei> In-Reply-To: References: <20220907132205.28021-1-andrea.merello@iit.it> <20220907132205.28021-14-andrea.merello@iit.it> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Sep 2022 08:42:01 +0200 Andrea Merello wrote: > > Hmm... It has my tag but I have noticed something to improve. > > One comment below, OK for the rest. > > > ... > > > > > +#define BNO055_I2C_XFER_BURST_BREAK_THRESHOLD 3 /* FIXME */ > > > > Can we elaborate what to fix and why it can't be fixed right now? > > Ah, this is a stale comment; I'll drop it.. I fixed up Andy's comments on this patch whilst applying. Thanks, Jonathan