Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220917165820.2304306-1-mike.rudenko@gmail.com>
 <6779635c-a162-0b7e-d124-d88d1ed9e162@sholland.org>
User-agent: mu4e 1.9.0; emacs 28.1
From:   Mikhail Rudenko <mike.rudenko@gmail.com>
To:     Samuel Holland <samuel@sholland.org>
Cc:     stable@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Fix otg port initialization
Date:   Sun, 18 Sep 2022 20:46:33 +0300
In-reply-to: <6779635c-a162-0b7e-d124-d88d1ed9e162@sholland.org>
Message-ID: <87tu54r2w1.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


On 2022-09-17 at 12:12 -05, Samuel Holland <samuel@sholland.org> wrote:
> On 9/17/22 11:58, Mikhail Rudenko wrote:
>> There are two issues in rockchip_usb2phy_otg_port_init(): (1) even if
>> devm_extcon_register_notifier() returns error, the code proceeds to
>> the next if statement and (2) if no extcon is defined in of_node, the
>> return value of property_enabled() is reused as the return value of
>> the whole function. If the return value of property_enable() is
>> nonzero, (2) results in an unexpected probe failure and kernel panic
>> in delayed work:
>
> This should be fixed by the following patch which is accepted already:
>
> https://lore.kernel.org/lkml/20220902184543.1234835-1-pgwipeout@gmail.com/

Ah, I see now. Sorry for the noise!

--
Best regards,
Mikhail Rudenko