Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 18 Sep 2022 20:48:58 +0200
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Jagath Jog J <jagathjog1996@gmail.com>
Cc:     a.zummo@towertech.it, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] rtc: maxim: Add Maxim max31329 real time clock
Message-ID: <YydoGsEU/UPkXvXn@mail.local>
References: <20220912190753.10158-1-jagathjog1996@gmail.com>
 <20220912190753.10158-3-jagathjog1996@gmail.com>
 <YyHBKNC/YHbvIn40@mail.local>
 <CAM+2Eu+jCA9yJma2UtD736opw0=_uCz4Zbiem89ehexTEU7mQw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM+2Eu+jCA9yJma2UtD736opw0=_uCz4Zbiem89ehexTEU7mQw@mail.gmail.com>
Precedence: bulk

On 17/09/2022 16:09:54+0530, Jagath Jog J wrote:
> > This doesn't feel right, doesn't that break start-year?
> >
> > What is the actual time range supported by this RTC? Shouldn't you set
> > the century?
> 
> The time range supported by RTC is 2000 to 2199.
> The alarm registers don't have a century bit.
> I have tested the alarm for
> 2122-09-17T01:22:00
> 2142-09-17T01:22:00
> 2160-02-29T00:00:00
> 2196-02-29T00:00:00 etc
> 
> I will add another condition such that if the century bit
> from the time register is not set then configuring the
> alarm for the next century is not allowed.

The actual check should be for the alarm to not exceed 100 years in the
future then. Else, this wouldn't work well with datetime offsetting.

> > > +static int max31329_set_time(struct device *dev, struct rtc_time *tm)
> > > +{
> > > +     struct max31329_data *max31329 = dev_get_drvdata(dev);
> > > +     u8 regs[7];
> > > +     int ret;
> > > +
> > > +     ret = max31329_get_osc_status(dev);
> > > +     if (ret)
> > > +             return ret;
> > > +
> >
> > Checking the oscillator is not needed here but resetting the status is.
> 
> Resetting the device will resets the digital block,
> I2C-programmable registers and oscillator also,
> The oscillator is taking some time around 80 milli sec
> to be back as usual.
> 
> Is it required to reset every time during the time setting?
> 

Not but resetting the osc status is.


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com