Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp1716038rwb; Sun, 18 Sep 2022 12:47:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM70kR1yPuGA21VpuoGdeOTgxRlxEq1OhRLP7cT19lWDaY6dqxAwnzECnkpZFgIL1o1jlnt6 X-Received: by 2002:a17:90b:390a:b0:202:cbf9:cd73 with SMTP id ob10-20020a17090b390a00b00202cbf9cd73mr26810739pjb.175.1663530463731; Sun, 18 Sep 2022 12:47:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663530463; cv=none; d=google.com; s=arc-20160816; b=stETV72L8d8PPoA2fCuKlK9bGdsKnyv6tqL16PFFVdkEY3blyzZYrpp0G4tuixIJLN AQfVPX//lcYL60XrhfEHySnRAFpFQEwTKYjzX0qQGgJdjlBXH2O9XFdZnVq3U9YvOZWl obQU/Ey3VM7IhBKuWdOy2w2oanfKzzLGn3u88D2GjyQzmlzevKxqESiTjzS3fHI3DGcx eg0WNINjALQRDEsoalC5OMpZ16+0GXQx0PeqVr4oHsH3sjJcl9K6JGEw6GMUjVjwUqti 2IL1RYBhnWhYDwPMBisbnXNM3HQLe3lj7PPxCkteAaFjhiLn38igFtHy7/Vtbjwx1/HN kHXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EWdwI+9F6KbF5P7EBjHLyJIqBo8SY/a75JkGfnay0dI=; b=K9x2F/D58+T47kMQuwlnii0MyIKeiL8PG2rRFXId9CZ2G/Sj9qFPjHHtPSLdbVKDYf QQuM2CXou1o/1kWyaLLtPqW75miB5a0fxbG4NR2qH2a34OGPKKrwtytAdjXosL22FFWn q93pCYlgX3BklPseoBHD9pbQ/T0BGIkXhUWumdEYxHohOTIHoQUoWFn2jIcEjSheGml+ PBfgRmyvy/F08GLQtPJGmWpuum6i7lvIsXfnj8/8iRB75GZ0gPjYAREu1TR8sRNsXSVF 8kzxBIRpP6xr86aA++URa4+s/SvH77CU+iCKzjwTRlrgoc8am4G7XSztftnetTHjYFsS 01VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=U00QM7wS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 66-20020a630845000000b00439e0327602si5735608pgi.254.2022.09.18.12.47.32; Sun, 18 Sep 2022 12:47:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=U00QM7wS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229593AbiIRTEb (ORCPT + 99 others); Sun, 18 Sep 2022 15:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiIRTE3 (ORCPT ); Sun, 18 Sep 2022 15:04:29 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E0A42A5; Sun, 18 Sep 2022 12:04:26 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7d5329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7d5:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3BF0D1EC02F2; Sun, 18 Sep 2022 21:04:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1663527861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=EWdwI+9F6KbF5P7EBjHLyJIqBo8SY/a75JkGfnay0dI=; b=U00QM7wSHikbt8CJZUY9HK8HpzlQnvUC7Msxf6QTULbZ/Qo651n+VVa/uZc/BJ+Vwn8cgi Kg+6Qi6TqSsIqXXSO95iiOFmeW/OusCe7Ar0JwQJNz2kEXGHTlcH44hJTDvCtnvHcR8JN6 szhpScE/k56x/NxjnCXUvgaOC6uvYVM= Date: Sun, 18 Sep 2022 21:04:16 +0200 From: Borislav Petkov To: Sean Christopherson Cc: Jim Mattson , Avi Kivity , Babu Moger , "Chang S. Bae" , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Joerg Roedel , Josh Poimboeuf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Pawan Gupta , Peter Zijlstra , Thomas Gleixner , Wyes Karny , x86@kernel.org Subject: Re: [PATCH 2/5] KVM: svm: Disallow EFER.LMSLE on hardware that doesn't support it Message-ID: References: <20220916045832.461395-1-jmattson@google.com> <20220916045832.461395-3-jmattson@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 16, 2022 at 10:33:29PM +0000, Sean Christopherson wrote: > ... > Either way, KVM appears to be carrying a half-baked "fix" for a buggy guest that's > long since gone. So like we did in commit 8805875aa473 ("Revert "KVM: nVMX: Do not > expose MPX VMX controls when guest MPX disabled""), I think we should just revert > the "fix". If, as message 0/5 says, setting this bit so that SLE11 Xen 4.0 boots as a nested hypervisor is the use case, then sure, unconditional NO_LSMLE and we all should go on with our lives. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette