Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Subject: [PATCH net-next v6 0/9] net: marvell: prestera: add nexthop routes offloading
Date:   Sun, 18 Sep 2022 22:46:51 +0300
Message-Id: <20220918194700.19905-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pMC/4dKfE4k8ff/1QJKGsud/gQ9hILctTCOBubc01bz/rdPT6JAo5EpgngPi?=
 =?us-ascii?Q?I048CVqz69d5cGK1IYa9qbo0+2SB+v55XEMzEf6Ph5T1K+9xctmKHUxKZeov?=
 =?us-ascii?Q?WmjuDENlH14iJvtQ0m6vX9kbjZ0Fx0aODmukGOBonr8r3Crovc47HlWyrrA4?=
 =?us-ascii?Q?mJ+S07HmqA+s+lsBOxZqyaD6BTU4KIVm9fOsFdN046ZNn3t0EucYCDeenkLt?=
 =?us-ascii?Q?hSk/KRZxxpOnCMYD/7Gbjf5VQpGD0W8b5DYSitBRCmI5W6m6bsu9s9MNV35v?=
 =?us-ascii?Q?kdqbSoWynmJGzoeND+TtVtAg7YQ2HU5QotQUHeTKMnakpPyyI+s1Fm/4pe0u?=
 =?us-ascii?Q?1owVARNqphW7KbzzMz8pmrJZhl4gULalscEYsGdPUio62EQe2j9lcOdhxmBH?=
 =?us-ascii?Q?41FU9h+P7Kt0g+G/ID7nWiuWwKdxO9lYGyvYoMx3uDFm+oaoBdRsMGMc2x68?=
 =?us-ascii?Q?OU0bZ7mPC9fhGB967b70FiG2gh4yNPwo2DmmUYmaybTuOi7SxPhX1T4bgZQ1?=
 =?us-ascii?Q?4sSA1R3mdWquUBgtHvQkM9vIJ9fWpNQwi84zPRc6pU+GedBEyBH3Np55ltDm?=
 =?us-ascii?Q?Ujn/ogkrgISlqF0v5MSYHbxi5cQFml/w+6M58lhLQTUDccxTzo9M5Jjh/6EB?=
 =?us-ascii?Q?lkTQI6YKt03qTwwZXTJuX+v+CcnjI+cWedrm20FjOYTTEm8FB5aYJUsYxZx8?=
 =?us-ascii?Q?qMOgeDHOwXAZvDI9D6rCHUzCKwq7hu13IouXlMU9COt/quv4u/u6LVC91ECz?=
 =?us-ascii?Q?JF0+sf+AjVUAfDNMAvGTMjuRYqKUaQagE6imiaRuic9SKyYvq5VLC2+8ZdIh?=
 =?us-ascii?Q?XtAaa7xhc9Ywd9cEwW27Y8eLtDvbdZX++wDlktOHVRXal2BIzBLIVhkQqFVS?=
 =?us-ascii?Q?ECUxrdl0IfnjD0dUaU4p8L88wvmlQyWlVLEpzY141X5sswd8v9XajasjF8Lt?=
 =?us-ascii?Q?23wSryYIh8p64w5IJVcUSRHX8Lp3NJh2nzADWOLe7cw4VdIYbjAXxFYgUktF?=
 =?us-ascii?Q?gOYA94a9tEyuYt/J6VJB4rw6gifd0mmn/Zs9NArY++QBK2briUT2/QW2Rm48?=
 =?us-ascii?Q?fjM3Qek8PgGR0ej3tNvzyBpk8BNVSHjaVdSQJc3j27k8lN8hjPuD6cIiu30G?=
 =?us-ascii?Q?i9lWIpWbWQFsg+vCNEPZF28JT5tX8WCrcqZMBmxEEqhxmcEnQJ+GpbImTtSi?=
 =?us-ascii?Q?Pz2fOrFDN9xN7Lj0SN9elEeTZs8mgHk3o8JMZWbpU6hZgHvlGtZiEPEUVnsU?=
 =?us-ascii?Q?sc76ulJu/n5+tRizNg2sP3FuQuaccJ7sH79FmWgkvLIdll/38crvFjhjRjxP?=
 =?us-ascii?Q?n/sZxIl7unoLH+FJXyBOFJLKNbEG1nl0Sl/Pp7GgPCcPkVrU22Zz9zR8f5cR?=
 =?us-ascii?Q?j0T5yNPRXQ59z3i8LFTI8IxPLUyh8CATvRNeLB2JXsKAgMDkAX4FQjbYif1X?=
 =?us-ascii?Q?srMt1Pgmq5vhnPANZI93HcN1RjfGyztbCJvQ4WByYOA6Y7Edn8d4unzInewC?=
 =?us-ascii?Q?7g6AApO7Xj6vNltopF4Y6WS5t/eV05ZVQxAEIBQQ5c1TTl2lBhAnEmXO2bHS?=
 =?us-ascii?Q?eU/87Y5RqPayYGrDX+8fPzccpsqulle8+oL+CsOX+SdzPcWYuOEAFzgK3GxM?=
 =?us-ascii?Q?Ug=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 8def508f-8566-4f06-b54e-08da99ae9652
X-MS-Exchange-CrossTenant-AuthSource: PAXP190MB1789.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2022 19:47:15.3426
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2XJS/OpfvS95kw2iwVNdgFJnOs2mTrFgLv6ofxLs7LLdOMGcfnTukDEP8gGUt+C9I5udTm+djwbr2lh2zQ1VcNpL/CNiiRHkqo4fi2w3pRw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P190MB1927
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add support for nexthop routes for Marvell Prestera driver.
Subscribe on NEIGH_UPDATE events.

Add features:
 - Support connected route adding
   e.g.: "ip address add 1.1.1.1/24 dev sw1p1"
   e.g.: "ip route add 6.6.6/24 dev sw1p1"
 - Support nexthop route adding
   e.g.: "ip route add 5.5.5/24 via 1.1.1.2"
 - Support ECMP route adding
   e.g.: "ip route add 5.5.5/24 nexthop via 1.1.1.2 nexthop via 1.1.1.3"
 - Support "offload" and "trap" flags per each nexthop
 - Support "offload" flag for neighbours

Limitations:
 - Only "local" and "main" tables supported
 - Only generic interfaces supported for router (no bridges or vlans)

Flags meaning:
  ip route add 5.5.5/24 nexthop via 2.2.2.2 nexthop via 2.2.2.3
  ip route show
  ...
  5.5.5.0/24 rt_offload
        nexthop via 2.2.2.2 dev sw1p31 weight 1 trap
        nexthop via 2.2.2.3 dev sw1p31 weight 1 trap
  ...
  # When you just add route - lpm entry became occupied
  # in HW ("rt_offload" flag), but related to nexthops neighbours
  # still not resolved ("trap" flag).
  #
  # After some time...
  ip route show
  ...
  5.5.5.0/24 rt_offload
        nexthop via 2.2.2.2 dev sw1p31 weight 1 offload
        nexthop via 2.2.2.3 dev sw1p31 weight 1 offload
  ...
  # You will see, that appropriate neighbours was resolved and nexthop
  # entries occupied in HW too ("offload" flag)

Co-developed-by: Taras Chornyi <tchornyi@marvell.com>
Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
Co-developed-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>

Changes for v2:
* Add more reviewers in CC
* Check if route nexthop or direct with fib_nh_gw_family instead of fib_nh_scope
  This is needed after,
  747c14307214 ("ip: fix dflt addr selection for connected nexthop"),
  because direct route is now with the same scope as nexthop (RT_SCOPE_LINK)

Changes for v3:
* Resolve "unused functions" warnings, after
  patch ("net: marvell: prestera: Add heplers to interact ... "), and before
  patch ("net: marvell: prestera: Add neighbour cache accounting")

Changes for v4:
* Rebase to the latest master to resolve patch applying issues

Changes for v5:
* Repack structures to prevent holes
* Remove unused variables
* Fix misspeling issues

Changes for v6:
* Rebase on top of master
* Fix smatch warnings

Yevhen Orlov (9):
  net: marvell: prestera: Add router nexthops ABI
  net: marvell: prestera: Add cleanup of allocated fib_nodes
  net: marvell: prestera: Add strict cleanup of fib arbiter
  net: marvell: prestera: add delayed wq and flush wq on deinit
  net: marvell: prestera: Add length macros for prestera_ip_addr
  net: marvell: prestera: Add heplers to interact with fib_notifier_info
  net: marvell: prestera: add stub handler neighbour events
  net: marvell: prestera: Add neighbour cache accounting
  net: marvell: prestera: Propagate nh state from hw to kernel

 .../net/ethernet/marvell/prestera/prestera.h  |   12 +
 .../ethernet/marvell/prestera/prestera_hw.c   |  130 ++
 .../ethernet/marvell/prestera/prestera_hw.h   |   11 +
 .../ethernet/marvell/prestera/prestera_main.c |   11 +
 .../marvell/prestera/prestera_router.c        | 1141 ++++++++++++++++-
 .../marvell/prestera/prestera_router_hw.c     |  377 +++++-
 .../marvell/prestera/prestera_router_hw.h     |   76 +-
 7 files changed, 1716 insertions(+), 42 deletions(-)

-- 
2.17.1