Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Taras Chornyi <tchornyi@marvell.com>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Subject: [PATCH net-next v6 4/9] net: marvell: prestera: add delayed wq and flush wq on deinit
Date:   Sun, 18 Sep 2022 22:46:55 +0300
Message-Id: <20220918194700.19905-5-yevhen.orlov@plvision.eu>
In-Reply-To: <20220918194700.19905-1-yevhen.orlov@plvision.eu>
References: <20220918194700.19905-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2rRStmM3IinfKo0aWxK9XvKgQltTPhxRwC+WSLZdmZTN/O+cd38Tq9J065gT?=
 =?us-ascii?Q?RD9jpqMUt22tcri7OZiABrXOrNXC8ZqjUO+RJipuvuwKiNiYBjvroc6jl2fw?=
 =?us-ascii?Q?nGeJvoFBuGYIgNQY18AO8X3vxkmtV055h/jpOWus1AKWIL6BisfogPRG8syT?=
 =?us-ascii?Q?gxI6MChSzab3JoZ8GVNOYn0DNrE29jA8svTlo4kT3pnX8CsKExCOZ7hfr2fR?=
 =?us-ascii?Q?L94ls+yChIWflz+fYxV0x/q/SFtwN1eSERv6MWuqvGOO026lYLelegk4plkm?=
 =?us-ascii?Q?VHQr6dC1IXJKUOEMCRDFswOFIA+IjZ50kgsAeUvmO1mLfp/A9f4FS9JYmV0q?=
 =?us-ascii?Q?je+5bVPx5qK0nx11I5JeHwWQbvyioE9mWbT6TJU1LCQxSVjumbpc4BWyWdLX?=
 =?us-ascii?Q?V+zZUi5WDs4ZoMgWQFMr067kGiWGusLM1iS3WN9bXg8Xo/6aDicHk+hOAipF?=
 =?us-ascii?Q?+38XWX9gVSXlgSP6YzuuYdvTmdqg9NSLLzm2UAxIqgesNj0oWpWhZl+FbJ0Q?=
 =?us-ascii?Q?bC6PeR9yS0xfTCjfeBEG1G7gYFoCahRKTO6ZWI61IIfXvITYS0e3zy/4OBrS?=
 =?us-ascii?Q?q3GK5zsn5NbQpN3bTz10gw2+j45mQCqJ7yG+QUizzHWSucUcKI6WDTtL0Ddk?=
 =?us-ascii?Q?wocJM8vyviQNPYcsOV8YMep5piPgQlSA2+uCr2CGGrPW24eoVzb0XC5/n51N?=
 =?us-ascii?Q?RBMIMMtgW0bpkY5eGweEnAYPaaptVV4CrmPM8ShqUuTPSZdrkEc0PmXEyPBK?=
 =?us-ascii?Q?xF+vXBV8z64RTrwvqXk0XaakQEe+xQtLgHq2Z4T1bEDzJ20e5YWAKp+Grchs?=
 =?us-ascii?Q?z0UYJU3Z2Qjt2Y90C9R9e4Z0g0FA4OhB6C3ld0mGByjOdgcOmFi0DJyQX+Ac?=
 =?us-ascii?Q?KldQ1KuLl4g/pqkVSgWognwb09Wlp2sGmI7SZ+F4UunVzRTIr5/0kfDrDXCR?=
 =?us-ascii?Q?H2ycBGF940lmUJOHoY2UlpXKGYyZbWOIU/mTX7ujsGBZkEdRRP1uA5Mq0vXW?=
 =?us-ascii?Q?dqTuYp1b1VGW78ngl6sasEdv0Y7czoIL5Es9Or8eyv03yT5t2eJzIjVTQNSz?=
 =?us-ascii?Q?bO3d7JxDVLGL8V7daoP+uq8EkN3grRGAv5RJ5+rSfXi1e3j8WpQYg7qCdR0G?=
 =?us-ascii?Q?4iVnHHmwsx/oN5bxQc+4X6fDd56kewJ1+fIGfwVL3S9oet2y7nZ/yw4D1NcZ?=
 =?us-ascii?Q?3QbqooRH8T0JK8ZCX+8QanuavbX1kIFi8ftwDNOTWhygk6xbjtnZgUZYnu+B?=
 =?us-ascii?Q?iuTixMMf6/R/ZwkAqTI94X86OV9Ef9wEOj8JAPullgvmuuaJdnyf4NkHa1BX?=
 =?us-ascii?Q?sbgVe1R6NAeesKXk2dfXzmcJeHvFFADgnjO8EAobbOj3kxrHgqEnMjmyxKBu?=
 =?us-ascii?Q?IrmAXLVSoI07lG7e/V37dzyGNf3WakGbcI3BUSYfz3atuCfLuG14G2idSQum?=
 =?us-ascii?Q?VNgA4XnQU6u8tifhgqy696PdtyiRVzTTMjIJKo7CI9ERmVHn8j+8gffbp2K0?=
 =?us-ascii?Q?/It0u9KRwQIrfcgpWMpcKqfDLG0bO8u22z08C2dFfPSwPzDwmBgnkWqupj4b?=
 =?us-ascii?Q?gA4ATRz4MOIT3207P/2xsP5TLGEUF+Vd58Mn6koaF1/+5Re4e7fZZY+lxY+W?=
 =?us-ascii?Q?wA=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 59b38e52-faed-4881-59e0-08da99ae99d8
X-MS-Exchange-CrossTenant-AuthSource: PAXP190MB1789.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2022 19:47:21.2048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JuIYPa5TV27NBesmMCY3bA/OgmzTcmSgwjvvIVF/Yj5jHw+ihHFtELdOQLYTdjvOnBCW3wJvTtJ1/NteIveS87g/Ho0DchQeNIS6VYCJQXU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P190MB1927
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Flushing workqueues ensures, that no more pending works, related to just
unregistered or deinitialized notifiers. After that we can free memory.

Delayed wq will be used for neighbours in next patches.

Co-developed-by: Taras Chornyi <tchornyi@marvell.com>
Signed-off-by: Taras Chornyi <tchornyi@marvell.com>
Co-developed-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
 drivers/net/ethernet/marvell/prestera/prestera.h      |  2 ++
 drivers/net/ethernet/marvell/prestera/prestera_main.c | 11 +++++++++++
 .../net/ethernet/marvell/prestera/prestera_router.c   |  1 +
 3 files changed, 14 insertions(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera.h b/drivers/net/ethernet/marvell/prestera/prestera.h
index 903e2e13e687..fe0d6001a6b6 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera.h
+++ b/drivers/net/ethernet/marvell/prestera/prestera.h
@@ -367,6 +367,8 @@ int prestera_port_cfg_mac_write(struct prestera_port *port,
 struct prestera_port *prestera_port_dev_lower_find(struct net_device *dev);
 
 void prestera_queue_work(struct work_struct *work);
+void prestera_queue_delayed_work(struct delayed_work *work, unsigned long delay);
+void prestera_queue_drain(void);
 
 int prestera_port_learning_set(struct prestera_port *port, bool learn_enable);
 int prestera_port_uc_flood_set(struct prestera_port *port, bool flood);
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 3956d6d5df3c..c0794603a733 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -36,6 +36,17 @@ void prestera_queue_work(struct work_struct *work)
 	queue_work(prestera_owq, work);
 }
 
+void prestera_queue_delayed_work(struct delayed_work *work, unsigned long delay)
+{
+	queue_delayed_work(prestera_wq, work, delay);
+}
+
+void prestera_queue_drain(void)
+{
+	drain_workqueue(prestera_wq);
+	drain_workqueue(prestera_owq);
+}
+
 int prestera_port_learning_set(struct prestera_port *port, bool learn)
 {
 	return prestera_hw_port_learning_set(port, learn);
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c
index bd0b21597676..c8ef32f9171b 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c
@@ -645,6 +645,7 @@ void prestera_router_fini(struct prestera_switch *sw)
 	unregister_fib_notifier(&init_net, &sw->router->fib_nb);
 	unregister_inetaddr_notifier(&sw->router->inetaddr_nb);
 	unregister_inetaddr_validator_notifier(&sw->router->inetaddr_valid_nb);
+	prestera_queue_drain();
 
 	prestera_k_arb_abort(sw);
 
-- 
2.17.1