Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yevhen Orlov <yevhen.orlov@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org,
        Yevhen Orlov <yevhen.orlov@plvision.eu>
Subject: [PATCH net-next v6 3/9] net: marvell: prestera: Add strict cleanup of fib arbiter
Date:   Sun, 18 Sep 2022 22:46:54 +0300
Message-Id: <20220918194700.19905-4-yevhen.orlov@plvision.eu>
In-Reply-To: <20220918194700.19905-1-yevhen.orlov@plvision.eu>
References: <20220918194700.19905-1-yevhen.orlov@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vlA1JDRlvojTisd0ZlunHPGL/cLyURYZ3ocuPrKUkBCbiWSlQNC6tvX/rFF0?=
 =?us-ascii?Q?xptv9i9AqhRFcRE8TpAtro3W9g1YpvgRAONbCcf41x8zS80kEgWN/CgdUj3u?=
 =?us-ascii?Q?MidbS/PODt7DsPuLpY8m8jU4IBf8pfUauFM07UqxOqNoOqdMdf9spcJzKuh0?=
 =?us-ascii?Q?pwzFNDO+xN862YJJXRey1jgWSVYcVp/hI7MaU72zP9Ctl+zioCUoDVUcaIyU?=
 =?us-ascii?Q?ewz9FNuL2ugc51SAhQQcZw2rK72pdjF6ox1xZc2OxdvRywjSxJMk0AShBHnv?=
 =?us-ascii?Q?+Rv2+rA7h28xP7cqt/qwHEszxC/UpmKE5/5roRc5keHJaVCLfZETHbK/yc23?=
 =?us-ascii?Q?0/+K6o+wxcvZJ17+vqeBbUAgOzEzdtO1mWm5H0kc2JD5GDca3/4q6fEjhOWP?=
 =?us-ascii?Q?3I5vrx7oiAkR6kd83qEFsghXCiX9MA4PIRDLNq7X0kzz36uC/K0qnXFRIcjo?=
 =?us-ascii?Q?FoWD0cspnLd7x2/WkuOtTTX1Jzh5wfTfBQYHAvPcwLtb6UYZ6dn3sU0bqYid?=
 =?us-ascii?Q?G4Kw0wqcyzbaEJOiEeGL/LT8Mxfrd5zd7Ni6s8ctdEKawYGMlGWAe59dGS5Z?=
 =?us-ascii?Q?VbYptor5YB8530EEukZHkgwpYcI1290U1E7i+mVPKvI/GYLsEn/OcMoa6+oV?=
 =?us-ascii?Q?PG0izMmj5Dso2xdl3V/0fJ4i9IcMRsypsHZfqaKI3+ac0IjmvhaVqEU38Me9?=
 =?us-ascii?Q?nuVb7bWrUDBTMShSFE8j+SqMT6v9RQYa/HI8VvoG830futPCjc1fTCOMdh5W?=
 =?us-ascii?Q?CCNS7p4G7GCLym0CO1bjqjQyD8z2bF8vILTwCcs3D0ARAlQw87zuCKBqw+dn?=
 =?us-ascii?Q?XP+pZo/JQsjtUeYnIDYyxQ2jk/ACU53xio58Y9pDgL5Y5TfqdfNbQSke6BII?=
 =?us-ascii?Q?plbU9Nksj9PBpgadttzY2LoB71oS7jDCcPVsTbOM31EE4yRgyGJ1CuhQ8rWF?=
 =?us-ascii?Q?G+QHi60SyXr4utvZa3hK+11CCSR0P6K49EtOujdBVhMVGwcUrjYS8jpfjL/Y?=
 =?us-ascii?Q?JWbv7f3aG4ivLArnbP2hMhbhX9+UA3WCczUDdZW4nVT9HxHgh8BdRH75+RN8?=
 =?us-ascii?Q?D2nKtXb21HV7gTPOHRMZ3ZHIH2KNBiEvC5Rf4qxyKqTtsaNKq5linsGMPV29?=
 =?us-ascii?Q?HoXJH0LC/jxx5wGUG6FeXakdjxUUGy9KFK8CuGwQacu9BygZBdVo/RzLlPkX?=
 =?us-ascii?Q?PyUGjqyU5J3p/jzDggQDcrDjTq6bFyVjuJtzEHv72W6jnHpz8S3I46g3NKzA?=
 =?us-ascii?Q?JrFcArBvwE0CtyYi/dwLDW9LR0cjRCInR+keNyiPyd6Ia7xNaoCVUSH+fbJ0?=
 =?us-ascii?Q?VxxE8YADo2Y8BROJrzuM3KUyvwT9isPVFX2/KGZhJ3MyTtz949kfGtZMxquS?=
 =?us-ascii?Q?rHiEhJzSD5/6ITJ+s+yuuxg/A5oWOk787avgTg3styRc4ATHAQ5aDq6kurqs?=
 =?us-ascii?Q?OtonS+raxubw2TH7DAyxIdpQ2zhRdgwMkg874FMQVDDFMuu5IQjfeGHeDUbw?=
 =?us-ascii?Q?myVTDB+xJbxVHcJ/kbkuG2JLZyaLNhcPO+cV6qQPYvEEiHSt/4BIDl7zVbnd?=
 =?us-ascii?Q?HkR/Szms0ZHAWjD7tRsazm95loAu082uNS6C8p9FWHfNRWagnqVdiM6Yv/Fy?=
 =?us-ascii?Q?uQ=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 08159167-61ea-4208-2889-08da99ae990b
X-MS-Exchange-CrossTenant-AuthSource: PAXP190MB1789.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2022 19:47:19.8756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QuNbyXwWmuoIhB9w4NYoH+slvpMhhYK/2p92UASmoPFobloJ+5h5V7L1Xl/WHLlNa7zH/e3QFdWMDrumih2NbHha2CVDQdN+xugUBRzSSdA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P190MB1927
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This will, ensure, that there is no more, preciously allocated fib_cache
entries left after deinit.
Will be used to free allocated resources of nexthop routes, that points
to "not our" port (e.g. eth0).

Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
---
 .../marvell/prestera/prestera_router.c        | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_router.c b/drivers/net/ethernet/marvell/prestera/prestera_router.c
index a8548b9f9cf1..bd0b21597676 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_router.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_router.c
@@ -336,6 +336,49 @@ prestera_k_arb_fib_evt(struct prestera_switch *sw,
 	return 0;
 }
 
+static void __prestera_k_arb_abort_fib(struct prestera_switch *sw)
+{
+	struct prestera_kern_fib_cache *fib_cache;
+	struct rhashtable_iter iter;
+
+	while (1) {
+		rhashtable_walk_enter(&sw->router->kern_fib_cache_ht, &iter);
+		rhashtable_walk_start(&iter);
+
+		fib_cache = rhashtable_walk_next(&iter);
+
+		rhashtable_walk_stop(&iter);
+		rhashtable_walk_exit(&iter);
+
+		if (!fib_cache) {
+			break;
+		} else if (IS_ERR(fib_cache)) {
+			continue;
+		} else if (fib_cache) {
+			__prestera_k_arb_fib_lpm_offload_set(sw, fib_cache,
+							     false, false,
+							     false);
+			/* No need to destroy lpm.
+			 * It will be aborted by destroy_ht
+			 */
+			prestera_kern_fib_cache_destroy(sw, fib_cache);
+		}
+	}
+}
+
+static void prestera_k_arb_abort(struct prestera_switch *sw)
+{
+	/* Function to remove all arbiter entries and related hw objects. */
+	/* Sequence:
+	 *   1) Clear arbiter tables, but don't touch hw
+	 *   2) Clear hw
+	 * We use such approach, because arbiter object is not directly mapped
+	 * to hw. So deletion of one arbiter object may even lead to creation of
+	 * hw object (e.g. in case of overlapped routes).
+	 */
+	__prestera_k_arb_abort_fib(sw);
+}
+
 static int __prestera_inetaddr_port_event(struct net_device *port_dev,
 					  unsigned long event,
 					  struct netlink_ext_ack *extack)
@@ -602,6 +645,9 @@ void prestera_router_fini(struct prestera_switch *sw)
 	unregister_fib_notifier(&init_net, &sw->router->fib_nb);
 	unregister_inetaddr_notifier(&sw->router->inetaddr_nb);
 	unregister_inetaddr_validator_notifier(&sw->router->inetaddr_valid_nb);
+
+	prestera_k_arb_abort(sw);
+
 	kfree(sw->router->nhgrp_hw_state_cache);
 	rhashtable_destroy(&sw->router->kern_fib_cache_ht);
 	prestera_router_hw_fini(sw);
-- 
2.17.1