Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Eric W. Biederman" <ebiederm@xmission.com>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Zhaoyang Huang <huangzhaoyang@gmail.com>,
        "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Ke Wang <ke.wang@unisoc.com>, Oleg Nesterov <oleg@redhat.com>
References: <1661842523-26716-1-git-send-email-zhaoyang.huang@unisoc.com>
        <CAGWkznE5LhYq6dWB0zFkF2XdD-gd3MBcQ9fnUJmW59YL1GisMQ@mail.gmail.com>
        <YyaFrarLHYW3HSnu@ZenIV>
Date:   Sun, 18 Sep 2022 16:55:17 -0500
In-Reply-To: <YyaFrarLHYW3HSnu@ZenIV> (Al Viro's message of "Sun, 18 Sep 2022
        03:42:53 +0100")
Message-ID: <87wna073ga.fsf@email.froward.int.ebiederm.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [PATCH] fs: use kvmalloc for big coredump file
Precedence: bulk


Adding Oleg as well.

Al Viro <viro@zeniv.linux.org.uk> writes:

> On Sun, Sep 18, 2022 at 10:29:10AM +0800, Zhaoyang Huang wrote:
>> loop Eric W
>> 
>> On Tue, Aug 30, 2022 at 2:56 PM zhaoyang.huang
>> <zhaoyang.huang@unisoc.com> wrote:
>> >
>> > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
>> >
>> > High order page allocation observed which even introduce kernel panic when generating
>> > coredump file, use kvmalloc_array instead of kmalloc_array
>
> Frankly, I would rather cap argc here - if you are trying to feed that many arguments
> to your userland helper, your core_pattern is probably bogus.

Yes.  More than 512 arguments seems ridiculous.  I only count
16 different values that can be place in corename so frankly a cap
of about 20 seems sensible.

I would suggest counting the number of spaces in core pattern and not
allowing it to be set if the result would be more than
"PAGE_SIZE/sizeof(void *)" arguments.

I would reduce that by one more argument so that helper_argv is
completely unnecessary.  Unless I am misreading something the
only reason for helper_argv is to add a NULL at the end of
the argv array.  It should be no problem to have format_corename
do that work as well.


If you have a real world case where that is a problem please post
the useful corepattern so that we can stare in disbelief and finally
come around to figuring out how to support such a core pattern.

Thank you,
Eric