Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v2 01/13] trinity: Add base driver
Reply-To: myungjoo.ham@samsung.com
Sender: MyungJoo Ham <myungjoo.ham@samsung.com>
From:   MyungJoo Ham <myungjoo.ham@samsung.com>
To:     Jiho Chu <jiho.chu@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>
CC:     "arnd@arndb.de" <arnd@arndb.de>,
        "ogabbay@kernel.org" <ogabbay@kernel.org>,
        "krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yelin Jeong <yelini.jeong@samsung.com>
In-Reply-To: <20220919110040.80b06ab4aa7460ad02c3246e@samsung.com>
Message-ID: <20220919025712epcms1p14191bcd1e53c354fd797414d6c27b0eb@epcms1p1>
Date:   Mon, 19 Sep 2022 11:57:12 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20220919110040.80b06ab4aa7460ad02c3246e@samsung.com>
        <20220917072356.2255620-1-jiho.chu@samsung.com>
        <20220917072356.2255620-2-jiho.chu@samsung.com> <Yyb0a96poEWZUe1y@kroah.com>
        <CGME20220917072357epcas1p17b277154f0d020435417450fa0337906@epcms1p1>
Precedence: bulk

> On Sun, 18 Sep 2022 12:35:23 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Sat, Sep 17, 2022 at 04:23:44PM +0900, Jiho Chu wrote:
> > > It contains the base codes for trinity driver. Minimal codes to load and
> > > probe device is provided. The Trinity Family is controlled by the
> > > Memory-Mapped Registers, the register addresses and offsets are
> > > described. And user api interfaces are presented to control device under
> > > ioctl manner.
> > 
> > Where is the documentation for how the userspace api works?  And where
> > is a link to the userspace code that talks to these devices?  That
> > belongs here in this commit changelog text please.
> > 
> 
> Hi, Greg
> Thanks for your review.
> 
> The user space library is published in:
> https://review.tizen.org/gerrit/gitweb?p=platform/adaptation/npu/trix-engine.git;a=summary
> 
> It needs to login to tizen, access guide is:
> https://docs.tizen.org/platform/get-started/open-source-project/
> 
> And, this information will be included in commit log.

The URL without log-in is more appropriate.

Please use https://git.tizen.org/cgit/platform/adaptation/npu/trix-engine/
instead of review.tizen.org.

Cheers,
MyungJoo