Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2035249rwb; Sun, 18 Sep 2022 20:45:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ZeJYI4WpmLvJ4kYFd9nlHTRB6y7P8q60l63GFhmFVvm8MLhD3+0+AXuv27FUskD+GofXC X-Received: by 2002:a17:907:7d8f:b0:780:37e7:d3b4 with SMTP id oz15-20020a1709077d8f00b0078037e7d3b4mr11456971ejc.594.1663559114985; Sun, 18 Sep 2022 20:45:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663559114; cv=none; d=google.com; s=arc-20160816; b=UknGyQtRD+CGf8RCN9L+gocn7xEGtcIrbHkE28a5E3Ex9oGZoaYtd8pqwgVVfafmY+ I3IwCmBQt6e2BuzvrvlYmbE5ETRBsDkikwDcG7d9pmXbf7cIEfMZxzuMnVTKFsm6qVTK LOV2dcTzK8SeYMwqUnMtBy7UGymAvbRvHNbkTKmfNeKjkVNqnXc23WopOY3SIJOYrxsr XbTnlOjedPU1yAs9NrsuHFM2IoGWI76eF6omQadRBhq2FROn88+r1zdE6y6DcDaOpAoo vT/y+QVnw+DuU3gOBuw0naJdctGVLJO419Re7+h0dXP3C1X4Yv5cwfopSw2sX/pPdI7L 6oMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nivcFdhE0KZ+yUlxen5cMm44Ml5cA2xUqodS1djhp6s=; b=YhGDanKUFRAMHxoirxHeAzLK86K3bkoP70avaUxG4wGwrFMffea89dYzlniYx3dzHO lATlR8KngZZV6KVBlxZFJAWNosMzBbrWqff7taioEcnFGfvzwyvlvbjcPUsZ7HvC+Aa0 22du1tZz3bXA18y/hZZ4OabwBNrxlvSkwGqgg9kPIpPIB40EV89RHD1sOX/1uShb4iOe Rio5X1/drtHAqEioqDZSf0NxLWjGPt6aJhbohn8fodzpAvGLp/I6+B0PB4kgdNyD1cNt B44ikbWqxdPAgx9WIG7CuUiHJd+kgB10on/ja2UxqKbZYY/TM2i4HZi7McclzE54BKRD VQDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w9-20020a056402268900b00448b8836866si9303911edd.586.2022.09.18.20.44.47; Sun, 18 Sep 2022 20:45:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbiISDPU (ORCPT + 99 others); Sun, 18 Sep 2022 23:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiISDPS (ORCPT ); Sun, 18 Sep 2022 23:15:18 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F180A12D18; Sun, 18 Sep 2022 20:15:14 -0700 (PDT) Received: from localhost.localdomain ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 28J3EGkP013488-28J3EGkS013488 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 19 Sep 2022 11:14:20 +0800 From: Dongliang Mu To: Linus Walleij , Bartosz Golaszewski , Marc Zyngier Cc: Dongliang Mu , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] gpio: tqmx86: fix uninitialized variable girq Date: Mon, 19 Sep 2022 11:12:49 +0800 Message-Id: <20220919031250.770285-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu The commit 924610607f19 ("gpio: tpmx86: Move PM device over to irq domain") adds a dereference of girq that may be uninitialized. Fix this by moving irq_domain_set_pm_device into if true branch as suggested by Marc Zyngier. Fixes: 924610607f19 ("gpio: tpmx86: Move PM device over to irq domain") Suggested-by: Marc Zyngier Signed-off-by: Dongliang Mu --- v1->v2: modify fix method to moving irq_domain_set_pm_device into if true branch as suggested by Marc Zyngier drivers/gpio/gpio-tqmx86.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c index fa4bc7481f9a..e739dcea61b2 100644 --- a/drivers/gpio/gpio-tqmx86.c +++ b/drivers/gpio/gpio-tqmx86.c @@ -307,6 +307,8 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_simple_irq; girq->init_valid_mask = tqmx86_init_irq_valid_mask; + + irq_domain_set_pm_device(girq->domain, dev); } ret = devm_gpiochip_add_data(dev, chip, gpio); @@ -315,8 +317,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev) goto out_pm_dis; } - irq_domain_set_pm_device(girq->domain, dev); - dev_info(dev, "GPIO functionality initialized with %d pins\n", chip->ngpio); -- 2.35.1