Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ecb6c1b6-132e-ae75-88f3-20b6793a3d23@amd.com>
Date:   Mon, 19 Sep 2022 11:24:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] perf test: Skip wp modify test on old kernels
Content-Language: en-US
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, ravi.bangoria@amd.com
References: <20220914183338.546357-1-namhyung@kernel.org>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20220914183338.546357-1-namhyung@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2JKSFV1WlhPZzAzRmhhaWcvTHNrOWZmeDdKUVIwN0pUZUg5UGhpOE0wUmFN?=
 =?utf-8?B?SG9Ld0pFN1lGbzRacFRoTU12NjNoNnIxMkRGanJaYmtYSVhrRU9lMjhwbVRm?=
 =?utf-8?B?TzlDc1JaOEROd0FvcisyQ1k0WE1rVGhCdXh0TnVpKzBWSVBmVGtTMDJmRmZL?=
 =?utf-8?B?NWJNRGxPQ1hNNE5YZ0RXeUFRWG9PYnRoMlM4dkVUYlNxQmdqaWd2djNIdlRX?=
 =?utf-8?B?alZScy9NV3RKV1NYQzVIeG4vSjNETW96Nm9HQStvWHUyYTF3UnFuL0RkdFIy?=
 =?utf-8?B?dExTTFNoamZHVmZNV2habFdxbXNPQ05JRzFJbmVtM2I2QWprWWYvMWdQM3o3?=
 =?utf-8?B?cXZCcUpHSXR3cUhuVzd6Y2s4V3FVOHQzb01yZU8wenlxekprRE1ZVzR5cmwx?=
 =?utf-8?B?UXdrMDRVVlNCWUI5VERCdXFDTCtkY2g0K3NpelNIRG8weVYwbkNHOElNSVZD?=
 =?utf-8?B?bHNhV09KbEd4ZmpnUmZtWUFDeXBQL0tKVFlKMnFjU0pmaW9Ed0Noa1BmTnIy?=
 =?utf-8?B?WGFHemNLK0tNNGFOWU5kN3N6WUlZT0phWEc3eTU2TDJVRlh2eHFlbjhsN1VP?=
 =?utf-8?B?N0k1WjJ0TWFUcDcvMGtXaDRDZXFKdkR3WitKRDVseHNSYU8vRGgxdmZOYUZQ?=
 =?utf-8?B?dGU2czhoQmp4L2VTSVpyNVdaNXRuaWRDWFM3TDM5SUs4QmdWRkRRODNobUJO?=
 =?utf-8?B?anhNM1BWZDlGTkhqc1Nub1dKT2MrL1I3YTYyaWlhL1RPRUE1MXZXMGVacGdo?=
 =?utf-8?B?NmtzM3g1aGRTNUhYWEpWaklnUjU1OEhZd3hJSGhnTGVqVkxhMUhoRFU0M0JM?=
 =?utf-8?B?a0VoVUR0MnpPOUlUSHUxUmw0TUFrN013aVRXMzNtUWVHVmZUK2ErY1VoRzFX?=
 =?utf-8?B?WTlCSjBQY1Q1M3g2aWNBbW5sSlZBTXN0VlBucHJWRUhybHF3cE9QQ0hqU1Zm?=
 =?utf-8?B?cUdLMVJkVFBFMjhOZGxkUDF2dmdrYVFGVG1hMU5IdVBla2dobG1vblI4ZXlw?=
 =?utf-8?B?UUJtV2ptSFdwcE5QQ1I5VW5pZnl3VHdkcEJGTGdpend0UG53dytQWWxDd0xI?=
 =?utf-8?B?LzNHVUtmQ0VwL29OZnhXRlVhVDlXeUdzMDRmcDBaQlUrek1ZeUdCajh2UENv?=
 =?utf-8?B?L3BXQTAwQmZqVHlLZkVSc0dkOVQ0aU5IL1U5MVVMNFNCc2M2Tmhnd0NDQ2FR?=
 =?utf-8?B?b0tRUDBxZzMrK253V2JWQjZySCtZTUw5M0VGbjFZcnlLSm5kTEJtckZaOFBW?=
 =?utf-8?B?aG42OTJ6bW9aSGtaS1ZnK0FaOHV0R2FlVGlhcGJkcHdEcjVReWhDMk1uRzBO?=
 =?utf-8?B?TkdIeWhZSk9kUDhWWkNEZnJvYzhaTU1IRXM3RE9objQyUDRsMmNwVFZvN205?=
 =?utf-8?B?SkwvOHVhVnFOZGNRWENPeENXY281SGlSYVdFcjcxSitLL05YbU16Yy9rYWlx?=
 =?utf-8?B?Vi9iLzVubVNRVnZROWxJd3ltVzRSYko2Zzd6amUvTUhlM1lvOW5yWk55YnJG?=
 =?utf-8?B?R0k2elZEd05pUzBUZlQvM0lzQzQxTXBzbHFKLzRMQUdVazFYbU9wY2Zjc2h2?=
 =?utf-8?B?cEQ5bFNCN1JqanRHQmJCQ2RtT05pRFpKNmwxU0ttS0tHNjhBOWo1aDBXQmQ4?=
 =?utf-8?B?VkIxbzliaFJyeDZ0UkJBRW5Xbkk2RE9mSG8vU1g3ZWd3Mkwrdm9kYTlNQU44?=
 =?utf-8?B?RTN3b0lrekxmQjQ3WnJURCthZ0hXQzlEK3ZsUHRVUGdnWFZ2V3ozZnRwWStl?=
 =?utf-8?B?bGw4VlN4WHJsTDlrYVlIalJMUDQ2Ry9ZRGQ2RW9QM3BiWmMwc0tVbUEwcDBM?=
 =?utf-8?B?c1BmRmRvVUNENzZIaDI0YWNNWmp2RXdSL1orMXpVdVhOaFN6TXgwL080bGl2?=
 =?utf-8?B?NGtUNUd5RnhSdmlDemQyV2tpZ2l1QXBPRUhaeXdQRFNDVkVSRlVLWUJuR0JQ?=
 =?utf-8?B?NUNnMFdyY21LYmZZQXphc1h4eFpwVi9UUUNUdHRUYjFSOE9vNHE3RnJ0dld0?=
 =?utf-8?B?NzFtOGk0M1lBUkx2Ylkrb3BQUmY1YlVpakFxQUUvdUU2dUgrUUJnVWx5Q0U0?=
 =?utf-8?B?RmNQbTg4UkFiQkIwTmJCa1RHZS81NXh5WllqQVFZVVB1cFlOb3cxUVdHL2xO?=
 =?utf-8?Q?RqK5xTjbYmZcynOmMafjhVVJz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3549d62-6efe-4cda-7bd2-08da9a0365cb
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 05:54:21.3978
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r+FGXcwtj/pS8PRwAIWVt2sjTHnza0IIONBA/hrjZWhPP2Ci82SDjle/5T0DBW5+WH+vRb8Y9UfvPW7ZScFnhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5226
X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15-Sep-22 12:03 AM, Namhyung Kim wrote:
> It uses PERF_EVENT_IOC_MODIFY_ATTRIBUTES ioctl. The kernel would return
> ENOTTY if it's not supported.  Update the skip reason in that case.

Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>

> I'd like to add Fixes: 2e85d5979e8d tag here but it'd conlict with the
> later change in e47c6ecaae1d.

Is it worth to backport?

Thanks,
Ravi