Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 09:35:12 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Wolfram Sang <wsa@kernel.org>, Kees Cook <keescook@chromium.org>,
        Peter Rosin <peda@axentia.se>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] i2c: mux: harden i2c_mux_alloc() against integer
 overflows
Message-ID: <YygNoO3Xr17ThMlY@kadam>
References: <YyMM8iVSHJ4ammsg@kili>
 <202209160046.016AC8B4@keescook>
 <YyQxuHi2iQIvj0Lj@kadam>
 <YyTPLkOfPlgkLaxq@shikoro>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YyTPLkOfPlgkLaxq@shikoro>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?40W+S2Z8/GRptHVdyjor1NBhjNBrrG3T1rreau/C85VZ75GHDjOyN1TX8jYc?=
 =?us-ascii?Q?jl4nL5ffENosuun4xu7OYpnVlm0gChrhmAw3SVl+sAUm+jcR6+zc1l7ebkNO?=
 =?us-ascii?Q?bzHYRTSi6e2SUYw7eg1S7anvXOLbRzQkv/BvqmzP2fiyx5QOkAOMjk82FVf9?=
 =?us-ascii?Q?OIhwdOkQeh7q46LQVXZ8VNI/Ep2869uC1sRBrop/63aqM83rL2LDBkRNePR0?=
 =?us-ascii?Q?juOQVjuoPY7GUW+uY2TDKWSLuC2I97O64/ISQEIWMyCzFSxtrPrdegbMfqZ2?=
 =?us-ascii?Q?q4Hsjv/vVk1Fgz6EdSt2BETSdz1PSK2JA/ive9GnaD3xN5ZTyYsth9oiLZqQ?=
 =?us-ascii?Q?7L8hCvh0EJNBJ9xzWCDoUiXF2u6zUB0NUm3R6BlJ5hhl0eFDpjdwjOY8P9Zu?=
 =?us-ascii?Q?eUvzjXTYAjB18FfQHCdYUKdyQK6t7EriJBq4e0caGQdPYvcJkv+sRQxwjIVI?=
 =?us-ascii?Q?KDtPTJg/1AziXbawTKW3/GtPAaez1MxaowHymYyOiWNIaYrb8aKdNDpciSZg?=
 =?us-ascii?Q?C6mmX6fsipPqiFOUaL1ZAC0LNC9uMcQVULoMaNXyFrSxeUg8vQ/TIYQsVi/X?=
 =?us-ascii?Q?3qBxMUfGMnbQIjd4fTWyvW+rJ0zl3WwILHI06OlVUnV8fIqhk7FsVfQYZkzw?=
 =?us-ascii?Q?V6/W7D+e9X+07XuTxvDjpyRhGu8JmPeSVEKRRjrxoZkNOp62FPuEj/jtZXDj?=
 =?us-ascii?Q?4L2F44pknOTLDrwKdaYgfFDwyMPcetDTfWBBjFtdMJo+TosFYUywg0GvsutK?=
 =?us-ascii?Q?l2s5Oh/bE3UlZ8k4xTRso8BR+9q+sJuTySGkqgX/sOJDnmHOZOKctRNId/wW?=
 =?us-ascii?Q?T+e1vqRsFC9l4qZ0czrot4HWoeTgddv7qfVnEg1qte2hSzJcPnZZD5JaSz0/?=
 =?us-ascii?Q?h7gbBOuDxXdXGtIpVo68ggoRlNoCATsOud6evKQ9QOMnLUGMtpoBccG3v1s0?=
 =?us-ascii?Q?HO6F+IR46mR9fMJOWzOjUQtJ1iGhUBRfD/B45PB5ZO88GRdERen1tcxPcOZa?=
 =?us-ascii?Q?wPAgWjCvqgBdl7GH2t4R2F5jT2fVd/cB1MteeU350+s9ou1QvpOpENgPgyUW?=
 =?us-ascii?Q?1F7x8Hfnq+JsfQTvfZFj/HtRVyt+BwFuQim+w7rvaxoXBj+I9VqNiJn44aJR?=
 =?us-ascii?Q?v2v1J9GF/8ybPK1yTBhrv06HHvFzzMqMBPuehAqPUuzumqAVxhQWKf1Lti6X?=
 =?us-ascii?Q?z7dyKjo75PRHMW/Nn05J+hj0cgrOUlyBzEdfM5nmutOihriZmu+D/N4bOkWY?=
 =?us-ascii?Q?r7Thl3l7mGeqciXumGVmp5qxvvWxgHOwxSIPyeVlgy7eHfU+/xJlnn7AOxjJ?=
 =?us-ascii?Q?sFbyUjW8EovEsffJ54lrM/dCqN7s77n0V47ZktBtziQvGRbyvdlb9s5Pi0lg?=
 =?us-ascii?Q?K9uA8zKeZtatOhg+hx9MH+kISWQvMMVQR8hY5WnSXi17vKI/XdBqfmagOB1x?=
 =?us-ascii?Q?JQCZ/MNr6LhdY9Yh7AvexojSPtobBYGuqXmLNSh6qnU5gI9MxkywoVxRt+o1?=
 =?us-ascii?Q?SdTeWJj4XxIU416GQ6Qgv55lSOVUxdju6VFEPiIGkwIuv1rEJUybxV1jWpp+?=
 =?us-ascii?Q?jJbmpAanIJTkQBVNFTqoa56AwaysectapDYZ1lly5b06m4/jmwQcvC1ZCoh5?=
 =?us-ascii?Q?Lg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 285e9c58-8b9a-4492-9dba-08da9a092942
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 06:35:37.0367
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HJ5phfAluJ8PSDHHSV0Ty4X4D9v4XAPmOkWwaY6d46W5WKoukKm/mqf1++9iPvMCU2wD504JfCFAy7SVvep5EJ2IAuRkR9RiUV9ttTa+pqM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4935
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-19_03,2022-09-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=933
 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2209190043
X-Proofpoint-ORIG-GUID: SQ3AS3TtPn6o67_jrm_tnzveRtBp9eh7
X-Proofpoint-GUID: SQ3AS3TtPn6o67_jrm_tnzveRtBp9eh7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 16, 2022 at 08:31:58PM +0100, Wolfram Sang wrote:
> 
> > > The new variable makes it more readable, but beyond that, do you see any
> > > reason not to just directly compose the calls?
> > > 
> > 
> > You could do that too.
> > 
> > You pointed this out in your other email but the one thing that people
> > have to be careful of when assigning struct_size() is that the
> > "mux_size" variable has to be size_t.
> > 
> > The math in submit_create() from drivers/gpu/drm/msm/msm_gem_submit.c
> > is so terribly unreadable.  It works but it's so ugly.  Unfortunately,
> > I'm the person who wrote it.
> 
> I can't parse from that if the patch in question is okay or needs a
> respin? Could you kindly enlighten me?
> 

It doesn't need a respin.  We were just discussing related bugs with the
integer overflow safe functions.

regards,
dan carpenter