Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec0f97e9-33b7-61d8-25b8-50175544dbdd@gmail.com>
Date:   Mon, 19 Sep 2022 15:26:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [PATCH v14 00/11] KVM: x86/pmu: Guest Last Branch Recording
 Enabling
Content-Language: en-US
To:     Jim Mattson <jmattson@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Joerg Roedel <joro@8bytes.org>, ak@linux.intel.com,
        wei.w.wang@intel.com, kan.liang@intel.com,
        alex.shi@linux.alibaba.com, kvm@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org
References: <20210201051039.255478-1-like.xu@linux.intel.com>
 <CALMp9eRC2APJgB3Y7S4MWsTs9wom3iQycd60kM2eJg39N_L4Ag@mail.gmail.com>
From:   Like Xu <like.xu.linux@gmail.com>
In-Reply-To: <CALMp9eRC2APJgB3Y7S4MWsTs9wom3iQycd60kM2eJg39N_L4Ag@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/9/2022 7:42 am, Jim Mattson wrote:
> How does live migration work? I don't see any mechanism for recording
> the current LBR MSRs on suspend or restoring them on resume.

Considering that LBR is still a model specific feature, migration is less 
valuable unless
both LBR_FMT values of the migration side are the same, the compatibility check
(based on cpu models) is required (gathering dust in my to-do list);

and there is another dusty missing piece is how to ensure that vcpu can get LBR 
hardware in
vmx transition when KVM lbr event fails in host lbr event competition, the 
complexity here is
that the host and guest may have different LBR filtering options.

The good news is the Architecture LBR will add save/restore support since Paolo 
is not averse to
putting more msr's into msrs_to_save_all[], perhaps a dynamic addition mechanism 
is a prerequisite.

Please let me know what your priority preferences are for these tasks above.