Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 11:50:11 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: drivers/cpufreq/qcom-cpufreq-hw.c:333 qcom_lmh_dcvs_notify() error:
 uninitialized symbol 'throttled_freq'.
Message-ID: <202209181024.rhoJMAL1-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ypDFDNVP3L5dy80voPTARZgh3H10NmyDk2TO37T1xARm5ObnM14rhdrqBr5r?=
 =?us-ascii?Q?6AX1JIdRMf1tkmqTV9p3o7wUvDLLumV80Pucw7NulJcVOdFVbisOhpHNztGN?=
 =?us-ascii?Q?2k+Tglh9Z0VthUSwoQ3Ond1jpL5M1WeuSvHmSB81POO6FvxqPoi/wDEx4tRg?=
 =?us-ascii?Q?n6fRBHAfS6eJcO03Hr3b1fbU1anl+IkCcEH/HKznMG1cTQdHedYQHEQvYQlH?=
 =?us-ascii?Q?rX+dkZuaOQASVdJQvjbG372h2tYYklnRGCCFxN1Hge9IGFxWmxj2E+fHNmOR?=
 =?us-ascii?Q?rHNJmv2oZgkQl6hdRQDedMqOWJSDk+oNTCgP5gUjxvQ5cBCcDmXnjfW5V6OQ?=
 =?us-ascii?Q?EqSUXPl7CV1z2zWlGcjRQURzVBu0SxM7wnWfK4ryE6LvISIFx9W8tUKO14Y/?=
 =?us-ascii?Q?mYNDvZN96Q2x47DUptRKB5XWEaV3bG1uIVDvXYmfV3BEF90wOInQvfbP4txd?=
 =?us-ascii?Q?vtYvub2aK0Jth3Wf0Tp01toMMs/ODXb5JA95xwU40HkUcLAPLUNS0rl4HutF?=
 =?us-ascii?Q?3Lw8eEtwGx9oypGaYJVR+HSg83U3VmzpPpeXXlD76fbjAC1KbhqoXYGdy1Tk?=
 =?us-ascii?Q?1tnPxK6FbyYq5kSuq+vk+Y13VAW/dJoj+YADI99Sk8jV1LRD2F8UEU3itp2+?=
 =?us-ascii?Q?uxwMxSWirBanzZ2YXNlY3Ozbh787jd4zjMXBTE9vwJHHy+qJsXUTjAk8PiPA?=
 =?us-ascii?Q?cnIjf1bvsXv1lt6TOmsQ7eCtRvpo8h267I+25SE3vidbcqfu3ZAp60r66M6W?=
 =?us-ascii?Q?Y5G8eG8E3i5H8j7sodq6KURJ49jQD8TKuO/L4+etKx8HR9YCHnKXpH8uWwen?=
 =?us-ascii?Q?3hy89L4zB/79VR5C6lkicnBfkvv43Rrn68q0C64GsHGEJ+S+cdSAYv/Xn7Oc?=
 =?us-ascii?Q?l0BgfcmwPkmXx43XM732FkilUPA3nc91zI+EBEb+sOmUt/jT6iN8AVxP4azR?=
 =?us-ascii?Q?C/S2+qxOpqy0LVsJw5/2IJkvAl93PGuDL+CGiVeUwu7Ts/Y9F7Kj/gdwrs0P?=
 =?us-ascii?Q?U20MooiewHD+OLjNPxkXYisSeYMaJrffzFPWz9rxynghAc35pcO3umWCFsrT?=
 =?us-ascii?Q?xVS7UVq2xXXPDectXkpq0ZBgZ2+ldc2EP8bSVOnMAceBduKnei5UrKZs8TlE?=
 =?us-ascii?Q?uZ0rhgxikiYNZBdPDyGXuVaESF7jQLbvCQip/lq8lEwZmPNvOWjBYZRhPMjB?=
 =?us-ascii?Q?KmILeZCyovK9ES4Z0Q2pG1K08goybsMFucINqUWaftMr1i4DO8347X/i1fkl?=
 =?us-ascii?Q?3GMCI0K2Sb1AIRrSr47WV08FfYQ4hRReest7ZoJ44mjAJ+bKzz0g0moNOPSI?=
 =?us-ascii?Q?N3c5VMwG6xvjRyX1fhcJOkGN8Xu/4+iHuhGxDqNb/iWZwUmdI5e3f9DUKQ5r?=
 =?us-ascii?Q?cwW1R1PtdeKrNbAORMqQ7WLK1E9pptvG5q5Q8WwZHDEt68QqG0Kzy1cPjawE?=
 =?us-ascii?Q?aUkw7T68Sjf08faH5LRpfJ/lClJygCQLL2jKA0RQBSbkGI2IJRSEwBrarVyB?=
 =?us-ascii?Q?MZPxxLKvn2gDnMorNtv/4x0LWNH1ouP36TKrWdNaOQMakqURLABejWm7MA8X?=
 =?us-ascii?Q?R7uJp/3im0REwqUAOgNcFIIhV8Pha5v6iSCTliri4WwZprapkRiNpTTfRfod?=
 =?us-ascii?Q?iA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34691720-ff90-4ede-d954-08da9a1c07b7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 08:50:40.6847
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lEV2x8p7ghDKy7F0rbMNTREvFtSZSNEYZ/PrYmYKPIlOxarZjAwmVAF81Tl7c9UjgtbQ+49LnDnr60ewPVgOTCvE9O0PRBjyQesBH5ZIAn4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4989
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-19_04,2022-09-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 spamscore=0
 bulkscore=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209190058
X-Proofpoint-ORIG-GUID: pAQThB3X-M0hFQHedd6wkXQa_z15KYJv
X-Proofpoint-GUID: pAQThB3X-M0hFQHedd6wkXQa_z15KYJv
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEXHASH_WORD,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a335366bad1364a07f49df9da1fdfa6d411a5f39
commit: 6240aaad75e1a623872a830d13393d7aabf1052c cpufreq: qcom-hw: fix the opp entries refcounting
config: arm-randconfig-m041-20220918 (https://download.01.org/0day-ci/archive/20220918/202209181024.rhoJMAL1-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/cpufreq/qcom-cpufreq-hw.c:333 qcom_lmh_dcvs_notify() error: uninitialized symbol 'throttled_freq'.

vim +/throttled_freq +333 drivers/cpufreq/qcom-cpufreq-hw.c

275157b367f479 Thara Gopinath   2021-08-09  290  static void qcom_lmh_dcvs_notify(struct qcom_cpufreq_data *data)
275157b367f479 Thara Gopinath   2021-08-09  291  {
275157b367f479 Thara Gopinath   2021-08-09  292  	struct cpufreq_policy *policy = data->policy;
5e4f009da6be56 Dmitry Baryshkov 2022-03-26  293  	int cpu = cpumask_first(policy->related_cpus);
275157b367f479 Thara Gopinath   2021-08-09  294  	struct device *dev = get_cpu_device(cpu);
0258cb19c77deb Lukasz Luba      2021-11-09  295  	unsigned long freq_hz, throttled_freq;
275157b367f479 Thara Gopinath   2021-08-09  296  	struct dev_pm_opp *opp;
275157b367f479 Thara Gopinath   2021-08-09  297  	unsigned int freq;
275157b367f479 Thara Gopinath   2021-08-09  298  
275157b367f479 Thara Gopinath   2021-08-09  299  	/*
275157b367f479 Thara Gopinath   2021-08-09  300  	 * Get the h/w throttled frequency, normalize it using the
275157b367f479 Thara Gopinath   2021-08-09  301  	 * registered opp table and use it to calculate thermal pressure.
275157b367f479 Thara Gopinath   2021-08-09  302  	 */
275157b367f479 Thara Gopinath   2021-08-09  303  	freq = qcom_lmh_get_throttle_freq(data);
275157b367f479 Thara Gopinath   2021-08-09  304  	freq_hz = freq * HZ_PER_KHZ;
275157b367f479 Thara Gopinath   2021-08-09  305  
275157b367f479 Thara Gopinath   2021-08-09  306  	opp = dev_pm_opp_find_freq_floor(dev, &freq_hz);
275157b367f479 Thara Gopinath   2021-08-09  307  	if (IS_ERR(opp) && PTR_ERR(opp) == -ERANGE)
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  308  		opp = dev_pm_opp_find_freq_ceil(dev, &freq_hz);
275157b367f479 Thara Gopinath   2021-08-09  309  
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  310  	if (IS_ERR(opp)) {
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  311  		dev_warn(dev, "Can't find the OPP for throttling: %pe!\n", opp);

throttled_freq not set on this path.  Just return?

6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  312  	} else {
275157b367f479 Thara Gopinath   2021-08-09  313  		throttled_freq = freq_hz / HZ_PER_KHZ;
275157b367f479 Thara Gopinath   2021-08-09  314  
0258cb19c77deb Lukasz Luba      2021-11-09  315  		/* Update thermal pressure (the boost frequencies are accepted) */
0258cb19c77deb Lukasz Luba      2021-11-09  316  		arch_update_thermal_pressure(policy->related_cpus, throttled_freq);
275157b367f479 Thara Gopinath   2021-08-09  317  
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  318  		dev_pm_opp_put(opp);
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  319  	}
6240aaad75e1a6 Dmitry Baryshkov 2022-03-26  320  
275157b367f479 Thara Gopinath   2021-08-09  321  	/*
275157b367f479 Thara Gopinath   2021-08-09  322  	 * In the unlikely case policy is unregistered do not enable
275157b367f479 Thara Gopinath   2021-08-09  323  	 * polling or h/w interrupt
275157b367f479 Thara Gopinath   2021-08-09  324  	 */
275157b367f479 Thara Gopinath   2021-08-09  325  	mutex_lock(&data->throttle_lock);
275157b367f479 Thara Gopinath   2021-08-09  326  	if (data->cancel_throttle)
275157b367f479 Thara Gopinath   2021-08-09  327  		goto out;
275157b367f479 Thara Gopinath   2021-08-09  328  
275157b367f479 Thara Gopinath   2021-08-09  329  	/*
275157b367f479 Thara Gopinath   2021-08-09  330  	 * If h/w throttled frequency is higher than what cpufreq has requested
275157b367f479 Thara Gopinath   2021-08-09  331  	 * for, then stop polling and switch back to interrupt mechanism.
275157b367f479 Thara Gopinath   2021-08-09  332  	 */
275157b367f479 Thara Gopinath   2021-08-09 @333  	if (throttled_freq >= qcom_cpufreq_hw_get(cpu))


Uninitialized.

275157b367f479 Thara Gopinath   2021-08-09  334  		enable_irq(data->throttle_irq);
275157b367f479 Thara Gopinath   2021-08-09  335  	else
275157b367f479 Thara Gopinath   2021-08-09  336  		mod_delayed_work(system_highpri_wq, &data->throttle_work,
275157b367f479 Thara Gopinath   2021-08-09  337  				 msecs_to_jiffies(10));
275157b367f479 Thara Gopinath   2021-08-09  338  
275157b367f479 Thara Gopinath   2021-08-09  339  out:
275157b367f479 Thara Gopinath   2021-08-09  340  	mutex_unlock(&data->throttle_lock);
275157b367f479 Thara Gopinath   2021-08-09  341  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp