Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 11:47:35 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Hector Martin <marcan@marcan.st>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: [asahilinux:bits/090-spi-hid 18/22]
 drivers/soc/apple/rtkit-helper.c:46 apple_rtkit_helper_shmem_setup() warn:
 variable dereferenced before check 'helper->sram' (see line 35)
Message-ID: <202209180216.pPTbUHZl-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?16bw3JURs4+FeDHTMeF9OaZAQrW/gSPLnA4c4UO+2bxJ1iFcFN6vE9q2kZzs?=
 =?us-ascii?Q?5QbfW+lVWDGkakFeRLSkPhiW7b6B7bOtU3fMwtDcYMsCXhvcqr6546a4LJqt?=
 =?us-ascii?Q?5Xnhn0/xAJnUeTLLP1Y89xqWMOz4FMtCN0r/xredHRBETbJYopfw2tgQ5XNv?=
 =?us-ascii?Q?OPOAyQOo8Vta1ZfsMZwI6gGPflf15YyZoOm2LhFai8WK1t0ozxWLZrFuyoSn?=
 =?us-ascii?Q?QAuNu5PmIKd4fYzRYITWXUhSC5P8DsMv/bNETjfrzA7zW/HDgZ1maxlWuU+U?=
 =?us-ascii?Q?bWJ/eAOPeFYuTzNxJ0P0B9LlQsSWfQM6Lssm0Frmn0YlQ+B0Ym7qIJ+azUut?=
 =?us-ascii?Q?O3NeBouNc1BO5e1L7Be42B+eJMyfqyFp1Zhhyk049aaee3s3/2hiVToZZl7X?=
 =?us-ascii?Q?89MO2WoABc9fBSv3FJl026CTOnvziFmCcuhnumjZrt2s7iTf35PZsmIzafbF?=
 =?us-ascii?Q?ChL2iIOhEN0VKbAx3wMHe7MkWQao11ZnLFkiKzeE4zjMcJSBy0wYw/gzXaLg?=
 =?us-ascii?Q?2oZd5Mk9lnBieNPGvJfiUXNSvjgE2PKHMtjw3kJ3pWjgqwGzCwVuZXN66KoR?=
 =?us-ascii?Q?WOI3tn/GGRZ1whuTy6DpobRpufNX+3BpFoxyW7XwfR3PwFkR3mtV6/YsYF2/?=
 =?us-ascii?Q?3DzO8QPhT6wV/wVXAoSU3vWQuPAgGybIdqwrINgoHLKy6hT2WHpxKqdWPPYi?=
 =?us-ascii?Q?5mlTqQngHUxwWEeCYXRnH+S/35cHlWiHkDzgNnSY5jy+50nsn/dAgcdZCL2N?=
 =?us-ascii?Q?u+ll15OoUzqm+mwIcBVsZX8OKB2UR6MINLk0+mnGWU0XJMDm0onOCw288Dbj?=
 =?us-ascii?Q?4nKd240nxttOsMc9t7GaodFkBZiuqC03YOWBr4yyjhmHsTIjA0d5nxh44dNv?=
 =?us-ascii?Q?6jnAzdQB/myABI2T9jOs7CPD37N+BCTti0tYljen1OtpDeMqifoLPul7bVoe?=
 =?us-ascii?Q?GsOviOFVD13JNr1WlHEvKYYYi3oHTMdyR6D2NrQ7vyu41dhg5RBdmTCLvdTs?=
 =?us-ascii?Q?4RM1tiWQXT5k7cjdZHysrVlOlh7FjLClQP8WLevA0ZDhT3Ef/FFhW7akCWPm?=
 =?us-ascii?Q?KnF+WqdlYqBU3QibRzO4XoYHBUycfT4ugBPuGLSAqCv8jvrWnu5bG0qR476l?=
 =?us-ascii?Q?WXM9TlsRmReXsYT7LIN3iEtj2d6U6fTuH7Y240P6VJ10XN5orCTBOtHxt8gX?=
 =?us-ascii?Q?/AeTNQxvVOG/Ij3KzPjKtPw+0UChse+f0yMsZjWBLrI73qr9EGFcFr4+kZMP?=
 =?us-ascii?Q?OmkrkOTz5p8M22XFelNkwgxk6Sk38UziiGh3MJ/XpoJmHheyAfc7IET57KMq?=
 =?us-ascii?Q?fub7T07uNYsLy1mik3P239lkuyS7HfDi0dFws13cNWH0kJgCzvt+7McN68SH?=
 =?us-ascii?Q?kNTzShvXajmWh4p2tTTSq1tHo4D63O4sLwO/vIrS/G2LOgUaCMIPmaTo+aGA?=
 =?us-ascii?Q?lZ3B1RwxmqWIUGr6mO9ml/3/MwM14N2L/4WW6fb+7l3txFWFdrgmeKEiB2wl?=
 =?us-ascii?Q?LpNY+4ILMs/PH0/hI54W8VdVbFzSZUiFEf3I+v0GQlJUysPNWEBEcFxbxv9f?=
 =?us-ascii?Q?vlp46tuzQeA+5ILLpIJ6bEgNvbs6qMhSNQ2IWRrW?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f729b5d-1ed6-4cb7-f239-08da9a1ba837
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 08:48:00.6504
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2x1HcIHthl5YRl7oTjZh2WLvDSdK2jmhU7OxTTPC8P1PO/9FfJB8siZBz4i43hXkKaqgP6WjCLlQpXXbWte7hYAVKpbSKmlVCpndMi3wOLs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4989
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-19_04,2022-09-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209190058
X-Proofpoint-ORIG-GUID: pt4xrfDwgLC5gOKicvzfzLNQgvViGZZz
X-Proofpoint-GUID: pt4xrfDwgLC5gOKicvzfzLNQgvViGZZz
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://github.com/AsahiLinux/linux bits/090-spi-hid
head:   ecf1fb81499a2f1724cb90497ca3c1cec831c9b6
commit: 51f1f2b38adcb95f2e04665ae54fe99ba6bd7844 [18/22] soc: apple: Add RTKit helper driver
config: arm-randconfig-m041-20220918
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/soc/apple/rtkit-helper.c:46 apple_rtkit_helper_shmem_setup() warn: variable dereferenced before check 'helper->sram' (see line 35)

vim +46 drivers/soc/apple/rtkit-helper.c

51f1f2b38adcb9 Hector Martin 2022-07-03  28  static int apple_rtkit_helper_shmem_setup(void *cookie, struct apple_rtkit_shmem *bfr)
51f1f2b38adcb9 Hector Martin 2022-07-03  29  {
51f1f2b38adcb9 Hector Martin 2022-07-03  30  	struct apple_rtkit_helper *helper = cookie;
51f1f2b38adcb9 Hector Martin 2022-07-03  31  	struct resource res = {
51f1f2b38adcb9 Hector Martin 2022-07-03  32  		.start = bfr->iova,
51f1f2b38adcb9 Hector Martin 2022-07-03  33  		.end = bfr->iova + bfr->size - 1,
51f1f2b38adcb9 Hector Martin 2022-07-03  34  		.name = "rtkit_map",
51f1f2b38adcb9 Hector Martin 2022-07-03 @35  		.flags = helper->sram->flags,
                                                                 ^^^^^^^^^^^^^
Dereference

51f1f2b38adcb9 Hector Martin 2022-07-03  36  	};
51f1f2b38adcb9 Hector Martin 2022-07-03  37  
51f1f2b38adcb9 Hector Martin 2022-07-03  38  	if (!bfr->iova) {
51f1f2b38adcb9 Hector Martin 2022-07-03  39  		bfr->buffer = dma_alloc_coherent(helper->dev, bfr->size,
51f1f2b38adcb9 Hector Martin 2022-07-03  40  						    &bfr->iova, GFP_KERNEL);
51f1f2b38adcb9 Hector Martin 2022-07-03  41  		if (!bfr->buffer)
51f1f2b38adcb9 Hector Martin 2022-07-03  42  			return -ENOMEM;
51f1f2b38adcb9 Hector Martin 2022-07-03  43  		return 0;
51f1f2b38adcb9 Hector Martin 2022-07-03  44  	}
51f1f2b38adcb9 Hector Martin 2022-07-03  45  
51f1f2b38adcb9 Hector Martin 2022-07-03 @46  	if (!helper->sram) {
                                                     ^^^^^^^^^^^^
Checked too late.

51f1f2b38adcb9 Hector Martin 2022-07-03  47  		dev_err(helper->dev,
51f1f2b38adcb9 Hector Martin 2022-07-03  48  			"RTKit buffer request with no SRAM region: %pR", &res);
51f1f2b38adcb9 Hector Martin 2022-07-03  49  		return -EFAULT;
51f1f2b38adcb9 Hector Martin 2022-07-03  50  	}
51f1f2b38adcb9 Hector Martin 2022-07-03  51  
51f1f2b38adcb9 Hector Martin 2022-07-03  52  	if (res.end < res.start || !resource_contains(helper->sram, &res)) {
51f1f2b38adcb9 Hector Martin 2022-07-03  53  		dev_err(helper->dev,
51f1f2b38adcb9 Hector Martin 2022-07-03  54  			"RTKit buffer request outside SRAM region: %pR", &res);
51f1f2b38adcb9 Hector Martin 2022-07-03  55  		return -EFAULT;
51f1f2b38adcb9 Hector Martin 2022-07-03  56  	}
51f1f2b38adcb9 Hector Martin 2022-07-03  57  
51f1f2b38adcb9 Hector Martin 2022-07-03  58  	bfr->iomem = helper->sram_base + (res.start - helper->sram->start);
51f1f2b38adcb9 Hector Martin 2022-07-03  59  	bfr->is_mapped = true;
51f1f2b38adcb9 Hector Martin 2022-07-03  60  
51f1f2b38adcb9 Hector Martin 2022-07-03  61  	return 0;
51f1f2b38adcb9 Hector Martin 2022-07-03  62  }