Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 11:21:43 +0300
From:   Vitaly Chikunov <vt@altlinux.org>
To:     Sasha Levin <sashal@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.15 22/41] video: fbdev: pxa3xx-gcu: Fix integer
 overflow in pxa3xx_gcu_write
Message-ID: <20220919082143.g4gn5ssbzolnc57b@altlinux.org>
References: <20220628022100.595243-1-sashal@kernel.org>
 <20220628022100.595243-22-sashal@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20220628022100.595243-22-sashal@kernel.org>
Precedence: bulk

On Mon, Jun 27, 2022 at 10:20:41PM -0400, Sasha Levin wrote:
> From: Hyunwoo Kim <imv4bel@gmail.com>
> 
> [ Upstream commit a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7 ]
> 
> In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of
> type int.  Then, copy_from_user() may cause a heap overflow because it is used
> as the third argument of copy_from_user().

Why this commit is still not in the stable branches?
Isn't this is the fix for CVE-2022-39842[1]?

Thanks,

[1] https://nvd.nist.gov/vuln/detail/CVE-2022-39842

> 
> Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
> Signed-off-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/video/fbdev/pxa3xx-gcu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c
> index 9421d14d0eb0..9e9888e40c57 100644
> --- a/drivers/video/fbdev/pxa3xx-gcu.c
> +++ b/drivers/video/fbdev/pxa3xx-gcu.c
> @@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff,
>  	struct pxa3xx_gcu_batch	*buffer;
>  	struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file);
>  
> -	int words = count / 4;
> +	size_t words = count / 4;
>  
>  	/* Does not need to be atomic. There's a lock in user space,
>  	 * but anyhow, this is just for statistics. */
> -- 
> 2.35.1
>