Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 11:45:27 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Hyunwoo Kim <imv4bel@gmail.com>
Cc:     lkundrak@v3.sk, linux-kernel@vger.kernel.org, arnd@arndb.de,
        linux@dominikbrodowski.net
Subject: Re: [PATCH v4] char: pcmcia: scr24x_cs: Fix use-after-free in
 scr24x_fops
Message-ID: <Yyg6N+yS9YyAepFk@kroah.com>
References: <20220919093801.GA307492@ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220919093801.GA307492@ubuntu>
Precedence: bulk

On Mon, Sep 19, 2022 at 02:38:01AM -0700, Hyunwoo Kim wrote:
> A race condition may occur if the user physically removes the
> pcmcia device while calling open() for this char device node.
> 
> This is a race condition between the scr24x_open() function and
> the scr24x_remove() function, which may eventually result in UAF.
> 
> So, add a mutex to the scr24x_open() and scr24x_remove() functions
> to avoid race contidion of krefs.
> 
> Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
> Reported-by: kernel test robot <lkp@intel.com>

The robot did not report this original problem :(

> ---
>  drivers/char/pcmcia/scr24x_cs.c | 73 +++++++++++++++++++++++----------
>  1 file changed, 52 insertions(+), 21 deletions(-)

You failed to put below the --- line what changed from previous versions
as the documentation asks for.

thanks,

greg k-h