Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 12:19:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Thomas Zimmermann <tzimmermann@suse.de>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Javier Martinez Canillas <javierm@redhat.com>
Subject: drivers/gpu/drm/display/drm_hdcp_helper.c:254 drm_hdcp_request_srm()
 error: uninitialized symbol 'fw'.
Message-ID: <202209191450.Y4sMY2Om-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BjMjUzNTIlbSOjIeKeFsMsD+YGM6PxKeFlMTNw0AItw3l23eGactfe2BeGjp?=
 =?us-ascii?Q?eM2H8npEyQY/Enxwppa/zJD2/1AvNb96JPKIGoWrwtoMq9k+FVxpclwVVD3J?=
 =?us-ascii?Q?RTmVtSLcem+kaFoTXH9YcsMT8u3sBiErimVA/IpL0m2uEJEveJafP/hMxT5t?=
 =?us-ascii?Q?XCONlcG8Qr36oK7O7gMlhMZXf13ZpwPzTtqkGxEumZ1LFnJCNnwfLLn7Cg6V?=
 =?us-ascii?Q?JO/Bmh4vudnKkfSQvMzM6ZslfbjuxRa4/GzyJzl+VPWPU36XJN7K54fbJGMo?=
 =?us-ascii?Q?V2i0xGunMC1h20ri3anrjLMjgkS0Fse2/fV1MxJxmPqtIPHVw+28GGZCwMjZ?=
 =?us-ascii?Q?+KdqahYq36u6ir0dOvAIMmvQU7LjADb4rdO0gw3LYMYMt26IUCxhHwjLU1Yv?=
 =?us-ascii?Q?joJx4rqDZ+nJ5sUiYfBHd9OnQzEHW/0YUmMi8d313a7yBYOfVqnhXgAoX1in?=
 =?us-ascii?Q?FLcKgUsR7fd/cJiZeqYCe7Ma0CpM7dAwifDwel0eaDaAYeRQHW6sVed2SA57?=
 =?us-ascii?Q?OKLfNGBxrFnu+h+SfzAMXjYD1ymqKMZABA6a/4jDXHhO6OzqsJCoNMT/SmBK?=
 =?us-ascii?Q?GFw7ltaFSmOs22Ro9zYPf41zmIT8Ht5iLAPAJrl2n4iHIkdoHOOldDWsZvL/?=
 =?us-ascii?Q?DdYV8mtAxc2qQlYZheU//9JSAndVt9eVw0sLND87PxryNfHBv6NIDoadHm8/?=
 =?us-ascii?Q?MAmCAGgiDL3D2o/I9gwjzvH9A1lga4Qja1RLG3fuv8o9o1gigO/qjfJ+VPau?=
 =?us-ascii?Q?/RdzIzhSVjYjBwabfkcRiJR2GD9wLNVwh6VJwzzFLnseh77x57bQEuONUcWl?=
 =?us-ascii?Q?IDDxUfaZXNfNltMf8oU7ulcfjpKFDBZ8Og/XTGgXuz6NQ6tQxJNtcFdExyJI?=
 =?us-ascii?Q?eSGgPdKsmOMkkfEvtZJX+M1a8CKpuKvd8cRY2HQ1WRacItZ2w9cAg/ccf1c/?=
 =?us-ascii?Q?sX5pmt+RQxnI3X9UVgqcpLl07+lUJcxxptlcDkEm/SYF5QyTeg40wGf3/kQK?=
 =?us-ascii?Q?/0BtxjtK36AOhLnk5r+bvslkUKS1FOoP3eIYtXUQKkwSTSBaZkgxg0r+64eR?=
 =?us-ascii?Q?BpYybbZtq9yTXkKwxSZ5oy+MdjSxIrUR1MVCCCkVqioLz7XgpgY33J9C8gir?=
 =?us-ascii?Q?/xv/ZIhM6HcUCDjCPXrmZGCqorudeKEKAyUsrKGpjEi2whh2PbvfpBD+e4Re?=
 =?us-ascii?Q?k/TTtACr7LoEIqBMuq2jO5zECQS7MnAsYSkzcdInnmAeI5+if82rFsj3FJ3j?=
 =?us-ascii?Q?/GwSlczNKIgGCWMC3q93jQScRtvuw+i70dDaDwtxUTm89XQ6bbLCBr607jBc?=
 =?us-ascii?Q?8Vu+OIHU1MP0P+P4RljLT1uOYmxYrvgnFhRSxe2XOKJgI/KCpO4N4j5X5y1u?=
 =?us-ascii?Q?Cd8ebZPZZYtc6iQWHKBQFsn36N/KPvD/cEHZGmLw0A9DzxAoEVqzuD2Eu15m?=
 =?us-ascii?Q?ediomt3AGdx4jcDhvtkNsUVbyO//BONTwiFhB5DFo3DvU0n+VM3yxRHEz6O/?=
 =?us-ascii?Q?8I9v/DveB+9zTJUdY2T6SMWfPuEEGeWMwwMmO5UhpazmXYP3qgPSuUf+Vn9w?=
 =?us-ascii?Q?N6PoZluBudOuSgjHMc0b8CdmdI4PGO4jP+kg7OGTNQ5BLMSm0mhy2CM3rfDR?=
 =?us-ascii?Q?5w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75aa0b90-9ee7-4301-cdde-08da9a201fc3
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 09:19:59.1871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rx9dlt9Px5d+LvrucACSqS4RTXvjTspB/wgB1Nkl1DM/Rw22DK2biDpWy4Pp4T8n8gCFhMOlClvsFjGiRywRXdc/pTejIOiLFlRlqioST9U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5043
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-19_05,2022-09-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 spamscore=0
 bulkscore=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209190062
X-Proofpoint-GUID: kxVzyMoEOqUgA9MBZqb-kpZT0lULQzNi
X-Proofpoint-ORIG-GUID: kxVzyMoEOqUgA9MBZqb-kpZT0lULQzNi
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Thomas,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   521a547ced6477c54b4b0cc206000406c221b4d6
commit: 6a99099fe1d6c46cbcd74298eeb386c4b9048f77 drm/display: Move HDCP helpers into display-helper module
config: arc-randconfig-m041-20220919 (https://download.01.org/0day-ci/archive/20220919/202209191450.Y4sMY2Om-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/display/drm_hdcp_helper.c:254 drm_hdcp_request_srm() error: uninitialized symbol 'fw'.

vim +/fw +254 drivers/gpu/drm/display/drm_hdcp_helper.c

79643fddd6eb2d drivers/gpu/drm/drm_hdcp.c Ramalingam C 2020-02-12  233  static int drm_hdcp_request_srm(struct drm_device *drm_dev,
79643fddd6eb2d drivers/gpu/drm/drm_hdcp.c Ramalingam C 2020-02-12  234  				u8 **revoked_ksv_list, u32 *revoked_ksv_cnt)
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  235  {
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  236  	char fw_name[36] = "display_hdcp_srm.bin";
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  237  	const struct firmware *fw;
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  238  	int ret;
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  239  
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  240  	ret = request_firmware_direct(&fw, (const char *)fw_name,
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  241  				      drm_dev->dev);
5fe89a6acd668c drivers/gpu/drm/drm_hdcp.c Sean Paul    2020-04-14  242  	if (ret < 0) {
5fe89a6acd668c drivers/gpu/drm/drm_hdcp.c Sean Paul    2020-04-14  243  		*revoked_ksv_cnt = 0;
5fe89a6acd668c drivers/gpu/drm/drm_hdcp.c Sean Paul    2020-04-14  244  		*revoked_ksv_list = NULL;
5fe89a6acd668c drivers/gpu/drm/drm_hdcp.c Sean Paul    2020-04-14  245  		ret = 0;
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  246  		goto exit;

"fw" isn't initialized so this will crash.  Just "return 0;"

5fe89a6acd668c drivers/gpu/drm/drm_hdcp.c Sean Paul    2020-04-14  247  	}
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  248  
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  249  	if (fw->size && fw->data)
79643fddd6eb2d drivers/gpu/drm/drm_hdcp.c Ramalingam C 2020-02-12  250  		ret = drm_hdcp_srm_update(fw->data, fw->size, revoked_ksv_list,
79643fddd6eb2d drivers/gpu/drm/drm_hdcp.c Ramalingam C 2020-02-12  251  					  revoked_ksv_cnt);
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  252  
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  253  exit:
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07 @254  	release_firmware(fw);
79643fddd6eb2d drivers/gpu/drm/drm_hdcp.c Ramalingam C 2020-02-12  255  	return ret;
6498bf5800a302 drivers/gpu/drm/drm_hdcp.c Ramalingam C 2019-05-07  256  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp