Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759180AbXFTL40 (ORCPT ); Wed, 20 Jun 2007 07:56:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754282AbXFTL4T (ORCPT ); Wed, 20 Jun 2007 07:56:19 -0400 Received: from bipbip.grupopie.com ([195.23.16.24]:34513 "EHLO bipbip.grupopie.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751260AbXFTL4S (ORCPT ); Wed, 20 Jun 2007 07:56:18 -0400 Message-ID: <467915DD.7020906@grupopie.com> Date: Wed, 20 Jun 2007 12:56:13 +0100 From: Paulo Marques Organization: Grupo PIE User-Agent: Thunderbird 1.5.0.12 (X11/20070509) MIME-Version: 1.0 To: Mike Frysinger CC: Satyam Sharma , Andrew Morton , linux-kernel Subject: Re: [PATCH] remove usage of memmem from scripts/kallsyms.c References: <4678013C.5090402@grupopie.com> <200706200033.16708.vapier@gentoo.org> In-Reply-To: <200706200033.16708.vapier@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 801 Lines: 21 Mike Frysinger wrote: > On Tuesday 19 June 2007, Satyam Sharma wrote: >> So we could remove the "#define _GNU_SOURCE" at the top >> of scripts/kallsyms.c too, presumably? If not (i.e. if there are >> more GNUisms left in that file anyway), then I'm not sure if we >> really gain by the change. > > yes, i believe this is true I only tried in on x86 with my toolchain and it works, but I don't know if it is worth the risk of breaking someone's setup for virtually no gain... -- Paulo Marques - www.grupopie.com "God is real, unless declared integer." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/