Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2311342rwb; Mon, 19 Sep 2022 03:14:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5phF7QT7A0Mfdths2/cKcYZEPjgCo5vz8InvyqIWTsSKNgBmXYwDP1+FszPsYHaKNfaRvn X-Received: by 2002:a17:90b:3752:b0:200:b29b:f592 with SMTP id ne18-20020a17090b375200b00200b29bf592mr19006439pjb.81.1663582476690; Mon, 19 Sep 2022 03:14:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663582476; cv=none; d=google.com; s=arc-20160816; b=h0aioki4CZo/aNmL7TB43ruyV0wkB6A8w0282JDc1/AGTLVaqjN647JQe49SW2F6IG 7DxPRP5vfKm2iudqPgUmSaxJl81rUZtjZjG7zbOf47gj7QgCEoOwKyfdgEX5IM4GogDF X/KHICM4Jjb7HilFHU366X5Lngd0LUeh8rk75XrRUnxYk3LItS4CLfZzfPsuhF2ehaCP /0DVGL1raZ06RNXm8Gqgt2xJRD6wJiUINhSIHFGSNmWJx/3qbe3bfGNg33ZUrABSMroU 5tnHKPuVf4P2wy4FkSDsZLAPttCpZkhMvYFTZiL5vyOKc/QzqJ2S9WDYOEFs2re9C7ME b3fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=E/6rguEg/ZdWc1ukf7xlwUxy6XdvsLO+DoWiEuYD7Kc=; b=RAch/LVyAu+q1qfwy+m/eh43HWAVzSbhFJ7QKTxdo/GP3OZ2CRmbdOg0NciTWzUgeb 6WfkxRhhwhfuRYOYNIZjznxr+YqnNopjq4oczLxCguMFGCpsD5RP3bl1SyVpNvvkKuU7 J0Xng3a9Ah91oW1iqyzdQ0FKQxIgh1qeSQS7GBk48J9FhGzSHqLVcrIRZvjy9sXCwjoJ EQ3RaSIMkI+YXEkuWd2TRQ1Q9zM6zz0PSHNX7EWcliRACDWlSvfitA02Veg7iHeYBPBZ 8xXaVLudinyFj306SgAzZ2ihJUXF+mXUWpV2OID1HvK3WlIS3Oot7thhN+phjt3MdquT Islg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="R/d5F8iQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a056a0022cc00b0052b75c32fd2si31075720pfj.48.2022.09.19.03.14.23; Mon, 19 Sep 2022 03:14:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="R/d5F8iQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230171AbiISKGN (ORCPT + 99 others); Mon, 19 Sep 2022 06:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbiISKGI (ORCPT ); Mon, 19 Sep 2022 06:06:08 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC32B626C for ; Mon, 19 Sep 2022 03:06:07 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id u18so46074587lfo.8 for ; Mon, 19 Sep 2022 03:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=E/6rguEg/ZdWc1ukf7xlwUxy6XdvsLO+DoWiEuYD7Kc=; b=R/d5F8iQ5A3MJQq2a2urDyF3hOpf96JRd6MMVeuZytNnN38d+CMzYHcqO67WLlgjrF 1YOTkwdBXx89EEa5IHZCIOnsH/D7ixYq0fnqz7E6WzF9juomojx3oI04uV+WLIpC7pSq VUlPCpXDbtXt1bOBZICVgjdP5lDuEF6FW9ya//+jjjjvV4Rdu1Io9wwK6PShHtWVk05C myyCftKiYalXiuQf3wsSfCHOD5hrDwaw9Dy4z1o7/Lkli8O3u6KPW46z/bDhJILuJ5Ea qFQ/gGWd+eX6p+JCLsf4mZezgCkL2wP/f0kkg5zBeR73KILKAfNYbrWR6TYXWl5SvOyO YuDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=E/6rguEg/ZdWc1ukf7xlwUxy6XdvsLO+DoWiEuYD7Kc=; b=yiW4OlWG5rfn7AoA8fMULE+PP82wI2meBEXfx37EXpnS0ZAxQUXcV3BVssfobMhsFn cjweQR0bUC6qEA+e5ZVOC9xNczJP6QRBLLidhdfytpIL/KhgDODA6hnrjtY2x1j+NSLN AlseP+v+8ZqkJUub1Xn9SkkhhPFbZdpU5TQExYR92Aa3acigkwb2pZWrIIP4Xl6YqBQw mI4u5HNu2/t/lT6gy9LRs3l/eUt2K5zg9AquJdAJMS32VGYail4O8Fxu/ZvxryK2EbuI jc347mfBjQVzMrBlelHg1hEen3f7UCY4wgqBgYzgKaEtknrqimsQwn/s4MQ3vKRna68C vB6w== X-Gm-Message-State: ACrzQf0I1WMHREf3tYPKvPXNQm/5TYd3Z6SpexwhpjsPqtJbwRykuDuq Ww/CmWoB8tJfo+CQn9zV+FIM0A== X-Received: by 2002:a05:6512:e9a:b0:498:ff3b:4639 with SMTP id bi26-20020a0565120e9a00b00498ff3b4639mr5805175lfb.388.1663581966082; Mon, 19 Sep 2022 03:06:06 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id n4-20020a05651203e400b00492d064e8f8sm5141134lfq.263.2022.09.19.03.06.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 03:06:05 -0700 (PDT) Message-ID: Date: Mon, 19 Sep 2022 12:06:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188 Content-Language: en-US To: Jianguo Zhang , "David S . Miller" , Rob Herring Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Matthias Brugger , Biao Huang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220919080410.11270-1-jianguo.zhang@mediatek.com> <20220919080410.11270-2-jianguo.zhang@mediatek.com> <4c537b63f609ae974dfb468ebc31225d45f785e8.camel@mediatek.com> <88412fcc-96be-cd9d-8805-086c7f09c03b@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/09/2022 11:56, Jianguo Zhang wrote: >> No, this does not justify new entry. You need specific compatible, >> but >> not new entry. >> >>> On the other hand, mt8188 and mt8195 have same ethernet design, so >>> the >>> private data "mt8195_gmac_variant" can be resued to reduce >>> redundant >>> info in driver. >> >> And you do not need new entry in the driver. > Do you mean that I can use "mediatek,mt8195-gmac" as compatible for > ethernet in mt8188 DTS file? Yes, as a fallback. Example schema describes such case. Best regards, Krzysztof