Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220915233852.415407-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <CAMuHMdUhq6nJSPdR4XfFvune2g0xHLxB-jP38yhVdwFyO8VQBg@mail.gmail.com> <CA+V-a8tbO2okH3oku+15nrd+KRdGoFQ8WRck5sAMuGhV9WcHpA@mail.gmail.com>
In-Reply-To: <CA+V-a8tbO2okH3oku+15nrd+KRdGoFQ8WRck5sAMuGhV9WcHpA@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 19 Sep 2022 11:49:40 +0200
Message-ID: <CAMuHMdVeDLSbea4pYJoajQXg0RroGeNuQcS6sBbU--GnmNu0aw@mail.gmail.com>
Subject: Re: [PATCH] ARM: shmobile: Kconfig: Drop selecting SOC_BUS
To:     "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc:     Magnus Damm <magnus.damm@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Prabhakar,

On Mon, Sep 19, 2022 at 11:46 AM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Sun, Sep 18, 2022 at 10:32 AM Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Fri, Sep 16, 2022 at 1:39 AM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > >
> > > Don't automatically select the SOC_BUS config option as we already have
> > > automatically selected it as part of the SOC_RENESAS config option [0]
> > > as renesas-soc.c [1] uses the APIs provided by SOC_BUS config option.
> > >
> > > [0] drivers/soc/renesas/Kconfig
> > > [1] drivers/soc/renesas/renesas-soc.c
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > i.e. will queue in renesas-devel for v6.1.
> >
> > > --- a/arch/arm/mach-shmobile/Kconfig
> > > +++ b/arch/arm/mach-shmobile/Kconfig
> > > @@ -6,5 +6,4 @@ menuconfig ARCH_RENESAS
> > >         select GPIOLIB
> > >         select NO_IOPORT_MAP
> > >         select PINCTRL
> > > -       select SOC_BUS
> > >         select ZONE_DMA if ARM_LPAE
> >
> > Nice catch!
> > I guess it would make sense to move the GPIOLIB and PINCTRL selects
> > to drivers/soc/renesas/Kconfig, too, as they are needed for all
> > (arm32/arm64/riscv) Renesas SoCs?
> >
> Agreed, shall I move them under SOC_RENESAS?

That's the place I had in mind ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds