Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f72e133e9aec70724702054e5f6a8712b649d34f.camel@mediatek.com>
Subject: Re: [PATCH 1/2] stmmac: dwmac-mediatek: add support for mt8188
From:   Jianguo Zhang <jianguo.zhang@mediatek.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        "David S . Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>
CC:     Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "Biao Huang" <biao.huang@mediatek.com>, <netdev@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
Date:   Mon, 19 Sep 2022 17:56:30 +0800
In-Reply-To: <88412fcc-96be-cd9d-8805-086c7f09c03b@linaro.org>
References: <20220919080410.11270-1-jianguo.zhang@mediatek.com>
         <20220919080410.11270-2-jianguo.zhang@mediatek.com>
         <d28ce676-ed6e-98da-9761-ed46f2fa4a95@linaro.org>
         <4c537b63f609ae974dfb468ebc31225d45f785e8.camel@mediatek.com>
         <88412fcc-96be-cd9d-8805-086c7f09c03b@linaro.org>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Krzysztof,

On Mon, 2022-09-19 at 11:27 +0200, Krzysztof Kozlowski wrote:
> On 19/09/2022 10:37, Jianguo Zhang wrote:
> > Dear Krzysztof,
> > 
> > 	Thanks for your comments.
> > 
> > 
> > On Mon, 2022-09-19 at 10:19 +0200, Krzysztof Kozlowski wrote:
> > > On 19/09/2022 10:04, Jianguo Zhang wrote:
> > > > Add ethernet support for MediaTek SoCs from mt8188 family.
> > > > As mt8188 and mt8195 have same ethernet design, so private data
> > > > "mt8195_gmac_variant" can be reused for mt8188.
> > > > 
> > > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com>
> > > > ---
> > > >  drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-
> > > > mediatek.c
> > > > b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
> > > > index d42e1afb6521..f45be440b6d0 100644
> > > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
> > > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c
> > > > @@ -720,6 +720,8 @@ static const struct of_device_id
> > > > mediatek_dwmac_match[] = {
> > > >  	  .data = &mt2712_gmac_variant },
> > > >  	{ .compatible = "mediatek,mt8195-gmac",
> > > >  	  .data = &mt8195_gmac_variant },
> > > > +	{ .compatible = "mediatek,mt8188-gmac",
> > > > +	  .data = &mt8195_gmac_variant },
> > > 
> > > It's the same. No need for new entry.
> > > 
> > 
> > mt8188 and mt8195 are different SoCs and we need to distinguish
> > mt8188
> > from mt8195, so I think a new entry is needed for mt8188 with the
> > specific "compatiable".
> 
> No, this does not justify new entry. You need specific compatible,
> but
> not new entry.
> 
> > On the other hand, mt8188 and mt8195 have same ethernet design, so
> > the
> > private data "mt8195_gmac_variant" can be resued to reduce
> > redundant
> > info in driver.
> 
> And you do not need new entry in the driver.
Do you mean that I can use "mediatek,mt8195-gmac" as compatible for
ethernet in mt8188 DTS file?
> 
> Best regards,
> Krzysztof

BRS
Jianguo