Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 12:45:11 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>
Cc:     forest@alittletooquiet.net, gregkh@linuxfoundation.org,
        philipp.g.hortmann@gmail.com, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev
Subject: Re: [RFC PATCH 2/5] staging: vt6655: change vnt_receive_frame return
 type to void
Message-ID: <Yyg6J/u23jcB2v+n@kadam>
References: <cover.1663273218.git.namcaov@gmail.com>
 <f727ea04703858920f6da694676ec323469e7b97.1663273218.git.namcaov@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f727ea04703858920f6da694676ec323469e7b97.1663273218.git.namcaov@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ww13cQ54KiVddjwKL8qUZqBeyZjGEbv+MK+BHYBPxcP7P2YDEgjtvQCFGkfH?=
 =?us-ascii?Q?MqG9/ebCMTe+yace79Swlhyx68Ildpb67AmXaf48Y3nnvZTX8cq55nFWgky4?=
 =?us-ascii?Q?LYAO0sota1AWIU8/EfFkFGG+5fH5rlVEOTneoN3HPMhUlQvqQzHAhRDnHMtg?=
 =?us-ascii?Q?8CGsx5p5FUtlyAQpA8UJk2UOVuJxV/RNiWfywJvwjiWUHgVnP3JeCXSeFPIU?=
 =?us-ascii?Q?Be0XFJtYJlqKRLslAEPkKj9QUJGHsypDYshr04xBr+ORvIOQ5V6+w64ecRrC?=
 =?us-ascii?Q?dsuW3rjV6FkuEZ8CvF81ha6tUy6ZIQJteB1KegIF2Mm8njCucWpTRN4sAzIQ?=
 =?us-ascii?Q?bkr6nXHccBYa/Xnj9C12IFVTNBi06JcOnH6q12whDJW5J/u9oebKFJK0n4TR?=
 =?us-ascii?Q?lIJ1oYolvI7Urk3Zl74aVNDPKmj0Sd+T6kMC9Z2FZOGlVp1XyMtdDoM1at4D?=
 =?us-ascii?Q?wtCR4Kg5KhrccuIMxne0gaf92VBOPt5xyxCPxANBpu/Gfv/uNiaOLNcviSVO?=
 =?us-ascii?Q?5jFKqlJUuctRjzFq2D6fp6M8EREaZTINM0G0AvPXszQSiMwpW+LlysM+nwgB?=
 =?us-ascii?Q?qsBCB+qdW9mqElrt6YcdKZQ7f41Y0MSaRfmomhQdjMmZO5Ux1o1QqLj85bJs?=
 =?us-ascii?Q?euQY51xMo1MG8xdELbzXHFaAzYDECzWy1b9QPJuQ775a/uTPOFUuyhJc01KY?=
 =?us-ascii?Q?v9D8IyLINYdca3Zw0VJtF7PnH5+W2pkm15UPVc/PNm/23PFv0uoaSZafPpv+?=
 =?us-ascii?Q?JSVfKK0Hg8PD7rEi4anaYJjWxSJtYquN5d3rKQH4+Ftxk9GJjp2rwi6Ltb9n?=
 =?us-ascii?Q?sKErTm7qY8Te0O2YgFnQtIruZb+EqHS890MMgAeer2krxEtmF67mqX99QZFu?=
 =?us-ascii?Q?swiHES+A2O9F/upxBp+V1zaBSs9x/eRjkw61X/1PHeDlwqMF1avgPPVEdJz3?=
 =?us-ascii?Q?hOpPdKPG1iyi7NjBe6yYrbwuv2c0MjNq9cPSllWY3o/2RV2wynjOkS9cpsP2?=
 =?us-ascii?Q?37QJtYHGN99ALQuh4Bfebnhd49TSyX4+Nc0hbAAxRKMYkeUx2bL6RY7/jksY?=
 =?us-ascii?Q?WcaYi92peaNy5OEP/SYuDa+cXWiYAMSrgdeaCG569RzTAJDKi2amGIsZFtzw?=
 =?us-ascii?Q?84E3rtSVHBkSOixXXCHOkhNVQPq2ZH3FhUPfMcqMnvCDAusWDoxmBkwl05UG?=
 =?us-ascii?Q?MH2R8xo5T9VkB5mi9x2wMA7cZmHeWzoWE7veec6K7d26aEtP+U5+Lfxi6Ckj?=
 =?us-ascii?Q?RzUbyC8mFfw2ugr2ugproyoM9C0E/5D6sIM4vtEKmvoksP3uftnNtGZDD3cr?=
 =?us-ascii?Q?d/GdDvXNJuIx6LgGiTvFXu4jv0E6I000OX8sKtmvSQBN+JUOK52wDFGor/0l?=
 =?us-ascii?Q?qXrKYFu4L/ySHgWcFuzcNvmcdaGsw92Jv5MuSqRHDitJ0W7Oj3+opirX3qL2?=
 =?us-ascii?Q?3fFV9flKIlawwqfRvvbVm1rKd25pFAaG9dJ2ek3rVVZoLnDWixlW9FSqk5MC?=
 =?us-ascii?Q?F8cR1dI1i5OzU7Ag/bgtee2ITs16NAKRGF/HdkkS7UvNSGsMKwjMBE+AdX8n?=
 =?us-ascii?Q?JqNua9Z2ydJqK3gciW4Mb2TpjanWHanHjRneoUvKmRaGv0Ga+NVpsh228g1E?=
 =?us-ascii?Q?cQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5871072d-ce98-43dd-c342-08da9a23b392
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2022 09:45:35.6900
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h8DxJjxkmc15rkgBJuI2dUL3EjKDezVt1v2CoRPtixDIjzQHSaKUHUpPrvWlCy9lWQxcaLJYB4YoYpKZnGvRxWPLH3Py468HFPKVWglfIoo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4845
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-19_05,2022-09-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000
 definitions=main-2209190065
X-Proofpoint-ORIG-GUID: jaD2DVi4uSFt5sp9dD72Psd5_c9FBZeg
X-Proofpoint-GUID: jaD2DVi4uSFt5sp9dD72Psd5_c9FBZeg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 15, 2022 at 10:29:33PM +0200, Nam Cao wrote:
> -bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
> +void vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
>  {
>  	struct vnt_rd_info *rd_info = curr_rd->rd_info;
>  	struct sk_buff *skb;
> @@ -133,13 +133,13 @@ bool vnt_receive_frame(struct vnt_private *priv, struct vnt_rx_desc *curr_rd)
>  		/* Frame Size error drop this packet.*/
>  		dev_dbg(&priv->pcid->dev, "Wrong frame size %d\n", frame_size);
>  		dev_kfree_skb_irq(skb);
> -		return true;
> +		return;
>  	}
>  
>  	if (vnt_rx_data(priv, skb, frame_size))
> -		return true;
> +		return;
>  
>  	dev_kfree_skb_irq(skb);
>  
> -	return true;
> +	return;

Just delete this last return (it's pointless now).

>  }

regards,
dan carpenter