Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 19 Sep 2022 11:16:29 +0100
From:   Mel Gorman <mgorman@techsingularity.net>
To:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Zhaoyang Huang <huangzhaoyang@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ke.wang@unisoc.com
Subject: Re: [RFC PATCH] mm: check global free_list if there is ongoing
 reclaiming when pcp fail
Message-ID: <20220919101629.xlafi2y2dk357wk3@techsingularity.net>
References: <1663325892-9825-1-git-send-email-zhaoyang.huang@unisoc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1663325892-9825-1-git-send-email-zhaoyang.huang@unisoc.com>
Precedence: bulk

On Fri, Sep 16, 2022 at 06:58:12PM +0800, zhaoyang.huang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> 
> Check the global free list again even if rmqueue_bulk failed for pcp pages when
> there is ongoing reclaiming, which could eliminate potential direct reclaim by
> chance.
> 
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

Patch does not apply and may be based on a custom kernel that introduced
a problem. There is no description of what problem this is trying to
fix. Checking the status of reclaim for a specific zone in this path would
be a little unexpected.  If allocation pressure is exceeding the ability
of reclaim to make progress then the caller likely needs to take action
like direct reclaim. If the allocation failure is due to a high-order
failure then it may need to enter direct compaction etc.

-- 
Mel Gorman
SUSE Labs