Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22ef7722-2f60-688d-4cf0-f59f0272a293@quicinc.com>
Date:   Mon, 19 Sep 2022 16:19:10 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH -next] cgroup: simplify code in cgroup_apply_control
Content-Language: en-US
To:     <williamsukatube@163.com>, <tj@kernel.org>,
        <lizefan.x@bytedance.com>, <hannes@cmpxchg.org>,
        <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220917084039.3177-1-williamsukatube@163.com>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20220917084039.3177-1-williamsukatube@163.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 9/17/2022 2:10 PM, williamsukatube@163.com wrote:
> From: William Dean <williamsukatube@163.com>
> 
> It could directly return 'cgroup_update_dfl_csses' to simplify code.
> 
> Signed-off-by: William Dean <williamsukatube@163.com>
> ---
>   kernel/cgroup/cgroup.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index e4bb5d57f4d1..1958f8bd93d6 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -3292,11 +3292,7 @@ static int cgroup_apply_control(struct cgroup *cgrp)
>   	 * making the following cgroup_update_dfl_csses() properly update
>   	 * css associations of all tasks in the subtree.
>   	 */
> -	ret = cgroup_update_dfl_csses(cgrp);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return cgroup_update_dfl_csses(cgrp);
>   }
> 
>   /**
> --
> 2.25.1
> 

LGTM.

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh