Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2381689rwb; Mon, 19 Sep 2022 04:27:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM70kREtG/KXZOP5hwsAlg2/Bmj1VVDaWkiP8+fOrX5o/LSp3nAWiL784FMbEewNYzYo7gMx X-Received: by 2002:a17:907:2bf8:b0:770:837a:e3b8 with SMTP id gv56-20020a1709072bf800b00770837ae3b8mr12266758ejc.562.1663586827976; Mon, 19 Sep 2022 04:27:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663586827; cv=none; d=google.com; s=arc-20160816; b=YFP6iK2sTwItry9p3C4lKiP5RHApd2KxQbkBiZI6nIgUAd90HkM6cDn5tOU0pm8+wF HnuburXRy1P0RrTe1fB5ZJ/6aQw1v333dPgFMbkHc+leHs5S9dE+lgmg/OfjAOWUS1JU 7ByEouhHeYJUoZCLLLfpaTssQbY41vaIkbab48DF3FwtYB1Q4U9ffIAvwtgU3z8Vu+hm MTNZko2nEPhf4sciwXu27v3KWFwBAd49s0oBfMbVzRxgZnzWicdFyYQYOx48hmqEaorD 9pRef539mTnrdcOpoUmQmOL3Ra5H7QiH/9FIRe/Btdfkehpa32w52AB5IQSuTDyT7vlg th/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=0PYbdglgTDEHj6N4b7YVGqncgauXNIm0qwGJaBgXzVk=; b=iJRgjfMqKyi8iMMPt6KToSI7xDn3ugzzIToSJAlNFePFJqR5itsOpWS4WHC9Xup7mE /Hsc+Pu9kcDytCrNFT32h029EQ0PKjMkJwsGhPpzzUTSdJ5pWxB9Z3drLqVC2oUKioD9 NpAEMI/H/jFsvKRjX3CMgnuoROj3/LIrKwEsPjFuYXvfTre2WwDIwc6mij2NTNPIIF2N 5uJQC9zKeE91nM4NFAVihH0BQnkFjTyYCZhfHGmG9XYG8GpL3NOHqc4XxZ9YjcrG1WkJ 9unpmAc4mya9cmm/VJQjVaVdP2X9W0QgyPai2Mbg+4kRIiIiw5HB3EnbS3z7UDKx9y26 LceQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ae1-20020a17090725c100b0077b73c98781si25380735ejc.15.2022.09.19.04.26.42; Mon, 19 Sep 2022 04:27:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbiISKuG (ORCPT + 99 others); Mon, 19 Sep 2022 06:50:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbiISKtP (ORCPT ); Mon, 19 Sep 2022 06:49:15 -0400 Received: from outbound-smtp59.blacknight.com (outbound-smtp59.blacknight.com [46.22.136.243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757372C11F for ; Mon, 19 Sep 2022 03:42:22 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp59.blacknight.com (Postfix) with ESMTPS id 195E1FA832 for ; Mon, 19 Sep 2022 11:42:21 +0100 (IST) Received: (qmail 11852 invoked from network); 19 Sep 2022 10:42:20 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 19 Sep 2022 10:42:20 -0000 Date: Mon, 19 Sep 2022 11:42:14 +0100 From: Mel Gorman To: "zhaoyang.huang" Cc: Andrew Morton , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCH] mm: check high-order page when free it to pcp Message-ID: <20220919104158.6vbzmzxk2dy6tu6w@techsingularity.net> References: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1663559238-22918-1-git-send-email-zhaoyang.huang@unisoc.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2022 at 11:47:18AM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > High-order pcp page escaped from checking when both of DEBUG_VM and debug_pagealloc > are all disabled if it allocated again from pcp_list without going to global > free list, which should be introduced by 44042b4498. > > fix:44042b4498 > > Signed-off-by: Zhaoyang Huang Is this based on the comment mentioning order-0 pages above free_pcp_prepare()? I ask because the comment is wrong and in both instances should have s/order-0// -- Mel Gorman SUSE Labs