Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2550188rwb; Mon, 19 Sep 2022 06:46:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6OKemXk8mTnM4JzMstlRTvd0PklLbBOw6vV2/7WHDuPksjCjeCmUURTE1evEi5lTQ/kkaA X-Received: by 2002:a17:902:f394:b0:176:b7b7:2 with SMTP id f20-20020a170902f39400b00176b7b70002mr12848393ple.57.1663595185264; Mon, 19 Sep 2022 06:46:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663595185; cv=none; d=google.com; s=arc-20160816; b=wXBZFBrT3xF4YJ4EFXevwFWOr7lqq9dolWrIWbSoNpJeyO0BsBuefZdJud+yvIUyoU TYzzQhbY2KluG/W37SZHAuDrciGgxPPuAK5kmy+6qi3bqyVYtW3z/r4GtBwhrXuelJl2 o1Uqy7Ka2nwZI7WF9/Cr0fHd/mjYEBYxFmhQ0YVIzHpcYcfev41hldVt5rGGmtpDiFyQ MpXU6y8BLrLZorl7oJxVweZizdokZhqQ4Yc07+4WfggQbdVndLH1KCMUcfYRRnysNjqd TZLnbCOJIE7cwb/4Anjbn3C9NCco+8cnUXbsVZINRdibgf5pp8niVHcT71CbXYF5LOxA UKkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Vhav0TRMmxNz1pp7aTEU7sIox1jnnxGX3A52ZhLd/+Q=; b=L1wzyfCxKgXyLIjKMymGC5XeXFPiP+4eclWI+ll/c7eaF1rvQHjQunCUts3IsXQ+0q WJgEd3yE4XW0t38WJRNx3FfL3nfxQMBlwOl/tGUtOBtXP2EssD1tCTARxmNU+DCpVEqf 6JodwdTbpx3dwnUdI8Lr99YeX6dJ9knYJuh2FMYYVelOeVFCWQ7FkM9452S27tUQHZJj Jga06brdMp++n7ETviIR5owhbIRcI57M9l7xUa1emsvuoZylLD2imUOUBSb1AzXOVltb Cwqr5crPW2wEq+YEoiy4+XRg7/XQmCyDDFUMT7W0tyQvfKMd3mUvema8R6AuRB8uawZX vPWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="T6P0cs8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j19-20020a170902759300b001785938f91bsi17165270pll.325.2022.09.19.06.46.13; Mon, 19 Sep 2022 06:46:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="T6P0cs8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230247AbiISM4H (ORCPT + 99 others); Mon, 19 Sep 2022 08:56:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbiISM4F (ORCPT ); Mon, 19 Sep 2022 08:56:05 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2F6A6340; Mon, 19 Sep 2022 05:56:04 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 63EA59BA; Mon, 19 Sep 2022 14:56:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663592163; bh=9Mr46YmjsLRLVKJjiWth2KE6xqw9og/WajL2NO3Thzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T6P0cs8/Wc3eM6BOHjJ92Dhs2KBhqeCDREldv0Ey5zThraVeQXt+ujxhsDBJxVwZd Ast/CRgcxmpg/A3JVsTgScgHp6wOx2EQ5KVwJyrxwndlbqDP4AUQ1sG8TsNvqK4HXe zltmcmR6NjoGIT0pHEMytrLt4b7l6MPrhmXN0Nj4= Date: Mon, 19 Sep 2022 15:55:50 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: Marco Felsch , mchehab@kernel.org, akinobu.mita@gmail.com, jacopo+renesas@jmondi.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] media: mt9m111: fix device power usage Message-ID: References: <20220916135713.143890-1-m.felsch@pengutronix.de> <20220916135713.143890-2-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2022 at 12:45:42PM +0000, Sakari Ailus wrote: > Hi Marco, > > On Fri, Sep 16, 2022 at 03:57:12PM +0200, Marco Felsch wrote: > > @@ -758,10 +751,14 @@ static int mt9m111_g_register(struct v4l2_subdev *sd, > > if (reg->reg > 0x2ff) > > return -EINVAL; > > > > + mt9m111_s_power(sd, 1); > > It would be nice to have this driver converted to runtime PM. Up to you. I second that :-) -- Regards, Laurent Pinchart