Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2562823rwb; Mon, 19 Sep 2022 06:57:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Im30TFzv/79rmpNw32cEiFiAlOeM/+n/SgZRvwEr3Xw916l4LYZkvFRZ/QRP1bEg6sA01 X-Received: by 2002:a17:90b:4a89:b0:202:b1b7:7ae with SMTP id lp9-20020a17090b4a8900b00202b1b707aemr31053948pjb.149.1663595833446; Mon, 19 Sep 2022 06:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663595833; cv=none; d=google.com; s=arc-20160816; b=MAtZeIfjHZedG5HqdX5wofrULI99KfV4xfmZa5M6W3SOA5SvXMf/X3RbGVtJ7nOKaz E/UStdlLJr4Y48BTocQjHErmi2kJ1bu1K7JLA0sjjQr7O/ZVIE2DQyRRWvnyKpmJfwSp 5Drw/d5lP7leE9BWdgCAabL6xZnV7FwUhZhORXGzM2921tOJDsoVKVTob0SvIZxEA624 HyJ08RajNv2MUZEbcowdyw5JbpRtuC1d8M35DadaPiQXaxWBCDDwJr3ePJhi6A9EHYNA TyuYTHhb5qFjn2Qwb7lB1Z3sgubrjnPYjE3HN3VEC0QwSB1i8nhW07W9OGypRWfweAYn NYiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=L1fHOMC8KuocBN///Hdjs/D4Y/Zu9zMeHLASw8piFP0=; b=jMOQCL3n2PrPE/W3KynyJFw25o3oTYk2T4P+PfZ0tI4Z5MExYGw7cPyAvI6bpFqMN3 ZbraRQPidLjYp8ko7Zp1cJgkWGcgJ9OKvsA9Wb4E1q8DsnfBdhYK/wFS8PezilUKWsyr 2/d1St0e3RfTEA/JfkA1hUgkY8kdk4cFRU6gAzuXCP05dgkVYaV+I/dH4EA2ZLSSRYxl InE7OapjfbVvCJ8fMIrf93i7+yYLioc0obnzEQu7iNmrEzRPj7NQPl6LRznIQFxWgvzg mcwZqFT3Z2Vp9Il+6A+pvxD8O+MnOfuiKJ5QQl/LWCjAR9eunc+HUWIxkpPRopjPlj5d WAJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Av6zqIxH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u15-20020a170902e5cf00b001783881c7e8si27814434plf.464.2022.09.19.06.56.59; Mon, 19 Sep 2022 06:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Av6zqIxH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231130AbiISNrX (ORCPT + 99 others); Mon, 19 Sep 2022 09:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230511AbiISNrM (ORCPT ); Mon, 19 Sep 2022 09:47:12 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E34D31207; Mon, 19 Sep 2022 06:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663595210; x=1695131210; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=jBbg9Ly3UJMnDmMmkjxG2CXACR0TAhGMOhRzvVmCwvs=; b=Av6zqIxHRTP/UYais3cmU5tsxf6ncaNJc60BELuZkx36r/ZQYyNRmZNQ xfZqT1j/03vx+0aBTXM4BsdeIrDkt4ntyHCu87nVSUeN56U+7O6AfC6Hk ZVIBbFsq6V/MP7bRhzBVkC4O/aYnoumyaqpCo2TUPyWxGtN8BO3P+B3hN Olzk/vwd1l+kNnNaQBb4K4ysrtfr5tKMCo3TPuTO4QGDOGK15eXeT4Eht LO5mP9eYOGQd8CRFLiwnhtkswH2EEA+z1oVzMAjyzxoZVj/fbmSv1wJrL PZaDIRdK6pIP2IugCn/eroVOgs/XDpC0fKHTpHytt4HnipTML6/boo8pJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="296996552" X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="296996552" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 06:46:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="651684842" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 19 Sep 2022 06:46:48 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oaH6k-004ZdO-2Q; Mon, 19 Sep 2022 16:46:46 +0300 Date: Mon, 19 Sep 2022 16:46:46 +0300 From: Andy Shevchenko To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: Lennert Buytenhek , Greg Kroah-Hartman , Jiri Slaby , linux-serial , LKML Subject: Re: I/O page faults from 8250_mid PCIe UART after TIOCVHANGUP Message-ID: References: <7fd034a9-c1e1-2dca-693b-129c9d2649@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7fd034a9-c1e1-2dca-693b-129c9d2649@linux.intel.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 15, 2022 at 07:27:45PM +0300, Ilpo J?rvinen wrote: > On Wed, 14 Sep 2022, Andy Shevchenko wrote: > > On Wed, Sep 14, 2022 at 02:10:44PM +0300, Lennert Buytenhek wrote: > > > On Wed, Sep 14, 2022 at 01:09:40PM +0300, Andy Shevchenko wrote: ... > - /* > - * The above check will only give an accurate result the first time > - * the port is opened so this value needs to be preserved. > - */ Side note: I haven't got why you removed this comment (it may be some staled info, but shouldn't be done in the separate change then?). -- With Best Regards, Andy Shevchenko