Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2577615rwb; Mon, 19 Sep 2022 07:06:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6wP26Wtt+/2PB4IQLffr7K8xmCg5fga1Fo/MWy3OwSKEtHWTsVvTZf4iI+XrWVym38YCis X-Received: by 2002:a17:906:959:b0:741:6f76:546f with SMTP id j25-20020a170906095900b007416f76546fmr13412960ejd.32.1663596417957; Mon, 19 Sep 2022 07:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663596417; cv=none; d=google.com; s=arc-20160816; b=t4oA/1CSgq/4jZzZ0rK1D1Kl4pIdg1Gjrgjm8OvXKg5/X3rYfrb1GkMY4ZG/YMjtwi JHTphXT7BunXFWIkZ17Ae9gOnAVtygRjc+Ox9LDD95wztNiewWwwMMDuodpkOV/kTfJL 4HW6ojN1C6XKzujtqgPTnTzOawBiioV5TeXyAbq57dhiLTq+xp7l52opEVxSAmC25fgD bNsNbtnCaXyhHVruqK+I0YeWJyp2BNEhLkY/MS7+ywbD0BG30Gr49PwpWDwC0n6OGcDr 6mkniaKz7F94w0zF0S45s5yYPgCzxb6UBhQI4YCTPT/KT4PbjOyezMHRu3UWC73Ykk00 FI0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jdO83EoynmI6aWZkayUtlj0DVG5iQ3eXfg+zyewIZQg=; b=uyQjUIKOUUCnYE2D0MG66luCSjt54j5Sn/87iZOceYGbzyd8feE++6svuNXFV4xeGc qSCv8TePWD52HJghS8zA+GPJDppyJzrt4tP3++SenJp6yqEW4o2awUp2pZe0jEpJd6zf pDtn0KwYvRT2+qC5Sp0vagfpXNzQn09pPASR3sDfARkez1OQdlNXOZQ5RSRvOPy1A2x3 DXpb+YV1BvqWHIiXN6BK7hbYbL3wO9Sjubk8IVyIPLiKeZNSDSrVApBvlRKBlRn/nCT+ oMFZIKBdN9gITU4CAqId5tngrcZuEJ8eQ34fQM1LnNXmTovDiX+qBiMFvOVBE2IRDikd Ut5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="BQ1/mcNi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qq17-20020a17090720d100b0077f73b07947si13552131ejb.844.2022.09.19.07.06.29; Mon, 19 Sep 2022 07:06:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="BQ1/mcNi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230233AbiISNNr (ORCPT + 99 others); Mon, 19 Sep 2022 09:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbiISNNo (ORCPT ); Mon, 19 Sep 2022 09:13:44 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 590591E3CF; Mon, 19 Sep 2022 06:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663593223; x=1695129223; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Kl8u/QncRP4RluJNzmTTBp2YYqFYhohf9QZvMNgIXnM=; b=BQ1/mcNigvlEG02MpwM5hh/h3paezewO+F82FEIuK2CUTEu4X+N0Amt4 NRbfeZgQedy9fZqHSemsv6/pfiY3wcGNPOE6J5ek+Yu1D8voo37FBblHx CFw5r30TowZd65p5xKv/HN+NsLo9c69yfZBquNacKIPlcgTPzzNj0wBBM r+s6U9CN9TcQX9cmBcxs6Ox7uFUQ90bf9SYwRVAShth4cjPXRwoZjwhvI 539kBecYfGlWA7vg6hqCIfJHsGadVdxEgLVZHgH9gEZQnyTgqTmf+4hVC v+O2jAPEe80Ai/woXG9KG1AN4EjqDSzYD8F7s9dmWgeBlCSpR0PXqN/dw A==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="282421122" X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="282421122" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 06:13:43 -0700 X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="744110405" Received: from punajuuri.fi.intel.com (HELO paasikivi.fi.intel.com) ([10.237.72.43]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 06:13:41 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id D223B202D2; Mon, 19 Sep 2022 16:13:38 +0300 (EEST) Date: Mon, 19 Sep 2022 13:13:38 +0000 From: Sakari Ailus To: Marco Felsch Cc: Laurent Pinchart , mchehab@kernel.org, akinobu.mita@gmail.com, jacopo+renesas@jmondi.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] media: mt9m111: fix device power usage Message-ID: References: <20220916135713.143890-1-m.felsch@pengutronix.de> <20220916135713.143890-2-m.felsch@pengutronix.de> <20220919131009.m2vdtsmftqntc2e6@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919131009.m2vdtsmftqntc2e6@pengutronix.de> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2022 at 03:10:09PM +0200, Marco Felsch wrote: > On 22-09-19, Laurent Pinchart wrote: > > On Mon, Sep 19, 2022 at 12:45:42PM +0000, Sakari Ailus wrote: > > > Hi Marco, > > > > > > On Fri, Sep 16, 2022 at 03:57:12PM +0200, Marco Felsch wrote: > > > > @@ -758,10 +751,14 @@ static int mt9m111_g_register(struct v4l2_subdev *sd, > > > > if (reg->reg > 0x2ff) > > > > return -EINVAL; > > > > > > > > + mt9m111_s_power(sd, 1); > > > > > > It would be nice to have this driver converted to runtime PM. Up to you. > > > > I second that :-) > > I would rather keep it this way and add 2nd patch to change. So it would > be easier to backport the patch. Works for me. -- Sakari Ailus