Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>
CC:     "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Khalil Blaiech <kblaiech@nvidia.com>
Subject: RE: [PATCH v3 5/9] i2c-mlxbf.c: support lock mechanism
Thread-Topic: [PATCH v3 5/9] i2c-mlxbf.c: support lock mechanism
Thread-Index: AQHYw6l4ztd5sEaXI0iQkdRZ858Ywq3j/mgAgALG2dA=
Date:   Mon, 19 Sep 2022 12:50:20 +0000
Message-ID: <CH2PR12MB38955CA9A05468D75940C96BD74D9@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20220908173544.32615-1-asmaa@nvidia.com>
 <20220908173544.32615-6-asmaa@nvidia.com> <YyYRGuXeXAT4FH0L@shikoro>
In-Reply-To: <YyYRGuXeXAT4FH0L@shikoro>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?za6+PrTaGf7+YdVtuwdhydxfKfpCHUEqAvAioPdZO3C65UTwXbIqUuZX22RT?=
 =?us-ascii?Q?acchhFHmSPLWxYaoBgu5Ii8jsiElhqUaoIGO43TjkE/eQ9BOGCqK6U3pELuN?=
 =?us-ascii?Q?15d4gmsYiSF1BaYQ3JNxzriS1XwOjStlyRQmnWUokrtViUM+B21/HMxmc/Gn?=
 =?us-ascii?Q?2xby3UPUybI6yl/WDaoxp9tjBojyQZ42W8whjwTL2vzhikELWHOeszgP/k50?=
 =?us-ascii?Q?9JSeuGEVN2hmWMfrLrJotnmsKF5yGyUKduW5SZO5caopBzuupBipkqpFPEyd?=
 =?us-ascii?Q?ikD0uDqbHJdATSZQVsJtkX6K3ScFDC/hAzL3x9mG8T160wAxYL//f/+YT047?=
 =?us-ascii?Q?lQQiJSH5X8vdiJMQIb16DQu7mvdhrjcUTmIAz2ma99kGs5+txXQLz/We3fpT?=
 =?us-ascii?Q?r4iFLSbP5Gt8WT1ObIQs8ECEBbwXFteLmBXttZMZ/cD2EYAzdSBc0HPuT/MB?=
 =?us-ascii?Q?HEFfma7uzUfA84E1KyRW+iHnUx6nxmEsln/nJ3B4G4L4IHYRa2vkO1TUg4pu?=
 =?us-ascii?Q?m4KvsiZniI+NC/MzCuGDThRQU79hi2POtg/obtd+zAjZ6+8tLPi8p0ExLLTh?=
 =?us-ascii?Q?abce1eeMcV2w2EluYJqfDAmMNMr6z0UqDvxZNIRGfsA8zVIHOSvObcPZAkSv?=
 =?us-ascii?Q?Z/oNb25X/TkiB/7x01Ojul2VgSCk2ishYHRKXprTOhGSyMuqyvePZRNhxdYn?=
 =?us-ascii?Q?GbSBmWNkPO5u23a2R/t4BaHK0Sk99H/22/ck7d3PGAhSq6XLVubYzahha+vH?=
 =?us-ascii?Q?ZmMCJMDp/XVcLlsmeZZTwLlvVdTidHU6mx5N3SMRKar0Kq/16UbH2PdY+/li?=
 =?us-ascii?Q?mNbvuAczH9/ayyX2ABEmvxKLcZAvzwx7bWos4idIr7DNJp21FY17xcQNiroZ?=
 =?us-ascii?Q?3/iQO2FHNn9j7z2mx4DnxBYJumtO/KDL6F/J7ctRn5Kk5VhIlfUpYEiYGhho?=
 =?us-ascii?Q?YawaqO9RLtJlE4f8HJJSAy8KvlcNFJpAoMzxbjXQB5uz083mwZrIxoFE08cW?=
 =?us-ascii?Q?nCOn2oMKWLWdjlwdLJuINMD92iJ5AJP1LwfOCzVfNSNtFsYl4j1cf1mG/L2s?=
 =?us-ascii?Q?kJwe0Alds76RE5yFtzQC9s7d5eu5TJKPDWrk50VzIegBfGM2ud7AXtl76vQB?=
 =?us-ascii?Q?l/n38JQ8fCcynDq6k6zg5PaCgAUdxnon5BQ4u1448r3bYkozMRGHqZTW01A0?=
 =?us-ascii?Q?UmR0XP7Iweh9W82w1gpj/yQ2Be/8NVGh+esdFi2I1sKixgyn323ElfzIahI0?=
 =?us-ascii?Q?0oxoTEqbLxKj32tz6/eM9POWOuDn5KT/1qbic5TMXJQCq33lcZIfhz8o0XDq?=
 =?us-ascii?Q?jk991cdAxKc3th7t9Zm/kS7wX97nUajR+YbSZ8mg0p+o9c4/KWODJ+3Oa7Cd?=
 =?us-ascii?Q?umg/Re3S0meummdxrxb3udLaNPbyaf5xhf1+9oxtd0gM80A5CS9jIIUigggj?=
 =?us-ascii?Q?wVQQAjf+z7iIttUwVJwtiayWDnqOQ1He3dOwQLTxz+KDBCrnmKg9kJlBV1a8?=
 =?us-ascii?Q?feJQS9SuVMpZURH/2uiWdxDWFk8qjMsf2wU//hrT8/2hGhm836QO2V5ECWMd?=
 =?us-ascii?Q?EgoJ/ojxQnsHncNGbeg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bcb6cf7-60d7-4296-0d1a-08da9a3d82eb
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Sep 2022 12:50:20.6315
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WGt+g/dWx6yoXahM8mW+xVe5LNFhsEj9naa7do+vGQTUo8J6lMBpuroLoBdc/5ae5JVPGPVUZ2I2T7RwVlnmWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6638
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> +	/* Try to acquire the smbus gw lock before any reads of the GW register=
 since
> +	 * a read sets the lock.
> +	 */

Please use kernel multiline comment style.

Done.
> @@ -792,6 +824,8 @@ mlxbf_i2c_smbus_start_transaction(struct mlxbf_i2c_pr=
iv *priv,
>  			priv->smbus->io + MLXBF_I2C_SMBUS_MASTER_FSM);
>  	}

Dunno if this is taste, but I think it is easier to follow the locking when=
 we have central acquire and release points for it. So, I'd suggest to add =
something like

out_unlock:

here and then goto to this place from the other locations.

What do you think?

Sure!
> =20
> +	mlxbf_i2c_smbus_master_unlock(priv);
> +
>  	return ret;