Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <83fc4085-60cc-fdc6-43ba-ac701cfde80c@I-love.SAKURA.ne.jp>
Date:   Mon, 19 Sep 2022 22:44:16 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2] lockdep: report name and key when look_up_lock_class()
 got confused
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Boqun Feng <boqun.feng@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <55111c45-0f8f-c6f9-640c-6919939b77dd@I-love.SAKURA.ne.jp>
 <YydkEtcVc0GtCizz@boqun-archlinux>
 <bd99391e-f787-efe9-5ec6-3c6dc4c587b0@I-love.SAKURA.ne.jp>
 <YyhI93taOenZMHrY@hirez.programming.kicks-ass.net>
From:   Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
In-Reply-To: <YyhI93taOenZMHrY@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/09/19 19:48, Peter Zijlstra wrote:
> On Mon, Sep 19, 2022 at 09:52:13AM +0900, Tetsuo Handa wrote:
>> Printing this information will be helpful.
>>
>>   ------------[ cut here ]------------
>>   Looking for class "l2tp_sock" with key l2tp_socket_class, but found a different class "slock-AF_INET6" with the same key
>>   WARNING: CPU: 1 PID: 14195 at kernel/locking/lockdep.c:940 look_up_lock_class+0xcc/0x140
>>   Modules linked in:
>>   CPU: 1 PID: 14195 Comm: a.out Not tainted 6.0.0-rc6-dirty #863
>>   Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
>>   RIP: 0010:look_up_lock_class+0xcc/0x140
>>
>> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> 
> Urgh, you hitting that WARN enough times to want to improve it seems to
> suggest your machine is quite sick.

My machine is not sick at all. I just wanted this hint for debugging
https://syzkaller.appspot.com/bug?extid=94cc2a66fc228b23f360 .

In a world of debugging without vmcore, printing as much hint as possible is
important. Therefore, WARN_ONCE() is more appreciated than WARN_ON_ONCE().

> 
> Anyway, patch is ok I suppose.

Thank you. Please send this patch and
https://lkml.kernel.org/r/9f42e8a5-f809-3f2c-0fda-b7657bc94eb3@I-love.SAKURA.ne.jp
via your tree.