Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Mon, 19 Sep 2022 06:27:31 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Vladimir Panteleev <git@vladimir.panteleev.md>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: sp5100_tco: Add "action" module parameter
Message-ID: <20220919132731.GA3547700@roeck-us.net>
References: <20220918140829.443722-1-git@vladimir.panteleev.md>
 <aabb7c21-9a80-696e-6a38-29de57e025ba@roeck-us.net>
 <CAHhfkvw_U_uF1UFcLTBUsw=_YoM_7pi3tw3KCovTT6PZTnH0ig@mail.gmail.com>
 <736d150c-03fe-ce39-a42e-b9b62f40a937@roeck-us.net>
 <CAHhfkvxf5P0KYQpzjAxBbEmYtK+YRs5P1QD+28=9FLZfn_awyA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHhfkvxf5P0KYQpzjAxBbEmYtK+YRs5P1QD+28=9FLZfn_awyA@mail.gmail.com>
Precedence: bulk

On Mon, Sep 19, 2022 at 01:18:53PM +0000, Vladimir Panteleev wrote:
> Hi Guenter,
> 
> On Mon, 19 Sept 2022 at 12:29, Guenter Roeck <linux@roeck-us.net> wrote:
> > I am not getting into define name editing wars. The define is named as
> > it is. There is never a good reason to rename it. If I'd accept your
> > change, someone else might come tomorrow and want it renamed to
> > "SP5100_WDT_ACTION_POWEROFF" because setting the bit to 1 causes
> > the system to power off.
> 
> Ah, sorry - this is one of my first attempts at contributing to the
> kernel, and as such I of course fully defer to you. In case I was
> misunderstood, I was just trying to explain my line of reasoning at
> the time, which is what I thought you asked for in your previous
> message. Thank you for the explanation, I was not aware of the high
> cost of renaming defines.
> 
> I will send a V2 if this is all?
> 

Sounds good.

Thanks,
Guenter