Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2664806rwb; Mon, 19 Sep 2022 08:14:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5IYqIDnUhuWkjH4J2MfBOwHlg1zMf/6ozDZEUR7A6ixmxnAQF7D2KQYHtES4eGchhOSFrd X-Received: by 2002:a17:902:d2c4:b0:178:32c4:6648 with SMTP id n4-20020a170902d2c400b0017832c46648mr255572plc.88.1663600447470; Mon, 19 Sep 2022 08:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663600447; cv=none; d=google.com; s=arc-20160816; b=vrzSZZllaSLvFT8SNTGb+hRLlwPlgfYIY89No95R/fLUAqjsz2YXHOh/GXpyVSpitO Pf59SzQW66FOLWvNO22IEdvJcH+De53MCOm+CNoiHPm6WNHzRJCtTUXI8lcxiOCAe2VL 0Ficf0H+n3kwT8jXX2Gblfzy7aetXIYRSsztI0v5Q6/r3LgRye0oTvX8VSBytpOF8iDi xOpP7GpMjZDe4Sysm4wIaCmnMVszrdCEVh8r0ISkSytRIPB1DSCxyVnyKSQ97GoiSDMI wzSHrrGXwSzM0HR5b+G0xcQ6qn2t+zLILeiQOPsUZgTe+R5oRx/av26SwJxVcu+perVD hg5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gSbjXxCmG10vSyv2JYZX2lw7eUAsc8jkVCI5sSje4ZA=; b=G5e4g/3NXjiIVpCoXdig9WADmJ6FlyJCqhmwrjYLHXA4N8T1bvbOfkL4GuifdLfBGx KHEb7R0AsCYGmm9lJsB062riSQl3gtmxLX5TbDfkf+hiXOPsEzhudc00u28FK2ra3Xf7 VtDrCiy4uzFo+tz+EtaU8opvWRLy2QjoXP27J3WlbdaMDESBq2ACJZskfodwHOPwCh3F PTMIaiWcQsZbxXcnRqyBd+glCaDNiHSrJLCGbfbsoNE+JR3D4Rx0cA26ukqsoVloh92Z tW7YJ3HB3thkqa8xnpS8ZKdjmBf9m9Dj6/RsAqIKrTK3MllgeIYN8+7IXuFwOS8Nw1Ij 945Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mw12-20020a17090b4d0c00b00200aa3c5ecdsi15657874pjb.15.2022.09.19.08.13.50; Mon, 19 Sep 2022 08:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229509AbiISOvQ (ORCPT + 99 others); Mon, 19 Sep 2022 10:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbiISOvI (ORCPT ); Mon, 19 Sep 2022 10:51:08 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C9361BC1E; Mon, 19 Sep 2022 07:51:02 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1oaI6u-0005ft-06; Mon, 19 Sep 2022 16:51:00 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 0F591C12F2; Mon, 19 Sep 2022 16:50:11 +0200 (CEST) Date: Mon, 19 Sep 2022 16:50:11 +0200 From: Thomas Bogendoerfer To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , John Crispin , linux-mips@vger.kernel.org Subject: Re: [PATCH] MIPS: lantiq: export clk_get_io() for lantiq_wdt.ko Message-ID: <20220919145010.GF7674@alpha.franken.de> References: <20220917232540.25436-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220917232540.25436-1-rdunlap@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 17, 2022 at 04:25:40PM -0700, Randy Dunlap wrote: > The lantiq WDT driver uses clk_get_io(), which is not exported, > so export it to fix a build error: > > ERROR: modpost: "clk_get_io" [drivers/watchdog/lantiq_wdt.ko] undefined! > > Fixes: 287e3f3f4e68 ("MIPS: lantiq: implement support for clkdev api") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Thomas Bogendoerfer > Cc: John Crispin > Cc: linux-mips@vger.kernel.org > --- > arch/mips/lantiq/clk.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/arch/mips/lantiq/clk.c > +++ b/arch/mips/lantiq/clk.c > @@ -50,6 +50,7 @@ struct clk *clk_get_io(void) > { > return &cpu_clk_generic[2]; > } > +EXPORT_SYMBOL_GPL(clk_get_io); > > struct clk *clk_get_ppe(void) > { applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]